Enable MaildirSettings
ClosedPublic

Authored by davispuh on Aug 28 2015, 11:07 PM.

Details

Summary

While looking at code noticed this was disabled.
Note that I didn't tested it as I've no idea what it actually does and how to trigger it, but it compiles.

Diff Detail

Branch
maildir
Lint
No Linters Available
Unit
No Unit Test Coverage
davispuh updated this revision to Diff 636.Aug 28 2015, 11:07 PM
davispuh retitled this revision from to Enable MaildirSettings.
davispuh updated this object.
davispuh edited the test plan for this revision. (Show Details)
davispuh added a reviewer: KDE PIM.
davispuh updated this object.Aug 28 2015, 11:13 PM
davispuh added a project: KDE PIM.
davispuh added a subscriber: KDE PIM.
dvratil added a subscriber: dvratil.

Looks good to me, but I'm confused as to what actually uses libnoteshared or where is this interface supposed to show up. Laurent, do you have an idea?

mlaurent edited edge metadata.Aug 29 2015, 7:25 AM

This code was here to be sure that we created a resource which was valid.

> we verified if it was an interface.

Ok perhaps we can't avoid to create a pointer for it.

(it's a very old code from kjot at the beginning).

But this patch seems good.

dvratil accepted this revision.Aug 31 2015, 9:16 AM
dvratil added a reviewer: dvratil.

If it's ok, then ship it :-) Thanks for the patch

This revision is now accepted and ready to land.Aug 31 2015, 9:16 AM
davispuh closed this revision.Sep 1 2015, 1:08 AM