davispuh (Dāvis Mosāns)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Aug 27 2015, 3:50 PM (203 w, 19 h)
Availability
Available

Recent Activity

Mar 23 2019

davispuh updated the diff for D19811: Add Smali syntax highlighting file.

Reduce size of test file

Mar 23 2019, 5:35 PM · Frameworks, Kate

Mar 17 2019

davispuh updated the diff for D19811: Add Smali syntax highlighting file.

Add a test

Mar 17 2019, 5:59 PM · Frameworks, Kate

Mar 16 2019

davispuh updated the diff for D19811: Add Smali syntax highlighting file.

Use MIT license

Mar 16 2019, 10:29 PM · Frameworks, Kate
davispuh requested review of D19811: Add Smali syntax highlighting file.
Mar 16 2019, 10:27 PM · Frameworks, Kate

Mar 15 2019

davispuh updated the diff for D19533: Don't crash on malformed syntax highlighting files.

Also check for present formats

Mar 15 2019, 5:43 PM · Frameworks, Kate

Mar 9 2019

davispuh added a comment to D19644: Reduce balooctl index/clear memory usage.

Do not create a new transaction per file, thats costly.

Mar 9 2019, 10:26 PM · Baloo, Frameworks
davispuh updated the diff for D19644: Reduce balooctl index/clear memory usage.

Don't create transaction for every file

Mar 9 2019, 10:25 PM · Baloo, Frameworks
davispuh added a comment to D19644: Reduce balooctl index/clear memory usage.

A transaction can not be split up, thats the reason it is a transaction ...

Mar 9 2019, 8:09 PM · Baloo, Frameworks
davispuh added reviewers for D19644: Reduce balooctl index/clear memory usage: dhaumann, bruns, ngraham.
Mar 9 2019, 8:07 PM · Baloo, Frameworks
davispuh requested review of D19644: Reduce balooctl index/clear memory usage.
Mar 9 2019, 7:43 PM · Baloo, Frameworks

Mar 7 2019

davispuh added a comment to D19457: Resurrect kdev-java.

ehhh, damn arc land, I didn't knew it will squash commits, oh well...

Mar 7 2019, 9:43 PM · KDevelop
davispuh committed R65:ede6824f596e: Resurrect kdev-java (authored by davispuh).
Resurrect kdev-java
Mar 7 2019, 9:36 PM
davispuh closed D19457: Resurrect kdev-java.
Mar 7 2019, 9:36 PM · KDevelop

Mar 5 2019

davispuh added a comment to D19457: Resurrect kdev-java.

Only I had to disable tests, because they depend on kdevplatform/tests/*.h which doesn't get installed with KDevelop

These headers should normally be installed.

Some distro packages of KDevelop omit them, because of explicitly setting -DBUILD_TESTING=OFF during the build process.

You should be able to copy them manually, or add the source dir as an extra include path.

Mar 5 2019, 9:35 PM · KDevelop
davispuh added a comment to D19457: Resurrect kdev-java.
In D19457#424138, @apol wrote:

Are you planning to maintain it?

Mar 5 2019, 9:27 PM · KDevelop
davispuh updated the diff for D19457: Resurrect kdev-java.

Make tests buildable

Mar 5 2019, 9:26 PM · KDevelop
davispuh updated the diff for D19533: Don't crash on malformed syntax highlighting files.

Don't duplicate code

Mar 5 2019, 8:38 PM · Frameworks, Kate
davispuh updated the diff for D19533: Don't crash on malformed syntax highlighting files.

Whoops...

Mar 5 2019, 8:26 PM · Frameworks, Kate
davispuh updated the diff for D19533: Don't crash on malformed syntax highlighting files.

Allow invalid Format()

Mar 5 2019, 8:24 PM · Frameworks, Kate
davispuh updated the diff for D19532: Don't crash when no contexts are present.

Improvements

Mar 5 2019, 8:21 PM · Frameworks, Kate
davispuh added a comment to D19532: Don't crash when no contexts are present.

Calling the ::get is no issue.

Mar 5 2019, 7:16 PM · Frameworks, Kate
davispuh added a comment to D19532: Don't crash when no contexts are present.

This would be my proposed patch + unit test.

Mar 5 2019, 7:11 PM · Frameworks, Kate
davispuh added a comment to D19532: Don't crash when no contexts are present.

Hi, first: good thing to get this fixed, yes, it shall not crash.

For the fix: Wouldn't it be enough to just change the

if (!d->m_definition.isValid()) {

applyFormat(0, text.size(), Format());

​ ...

shortcut to check for

if (!d->m_definition.isValid() || defData->isLoaded()) {

Mar 5 2019, 6:52 PM · Frameworks, Kate
davispuh added a dependent revision for D19532: Don't crash when no contexts are present: D19533: Don't crash on malformed syntax highlighting files.
Mar 5 2019, 12:10 AM · Frameworks, Kate
davispuh added a dependency for D19533: Don't crash on malformed syntax highlighting files: D19532: Don't crash when no contexts are present.
Mar 5 2019, 12:10 AM · Frameworks, Kate
davispuh added reviewers for D19533: Don't crash on malformed syntax highlighting files: cullmann, dhaumann.
Mar 5 2019, 12:09 AM · Frameworks, Kate
davispuh requested review of D19533: Don't crash on malformed syntax highlighting files.
Mar 5 2019, 12:07 AM · Frameworks, Kate

Mar 4 2019

davispuh updated the diff for D19532: Don't crash when no contexts are present.

Actually fix it

Mar 4 2019, 11:20 PM · Frameworks, Kate
davispuh added a comment to D19532: Don't crash when no contexts are present.

Creating a syntax highlighting file with few unclosed tags made Kate to crash. No matter how malformed XML it loads, editor should never crash as it can cause loss of unsaved work.

Mar 4 2019, 10:27 PM · Frameworks, Kate
davispuh added reviewers for D19532: Don't crash when no contexts are present: cullmann, dhaumann, vandenoever.
Mar 4 2019, 10:18 PM · Frameworks, Kate
davispuh requested review of D19532: Don't crash when no contexts are present.
Mar 4 2019, 10:15 PM · Frameworks, Kate

Mar 2 2019

davispuh added a comment to D19457: Resurrect kdev-java.

Only I had to disable tests, because they depend on kdevplatform/tests/*.h which doesn't get installed with KDevelop

Mar 2 2019, 4:05 AM · KDevelop
davispuh requested review of D19457: Resurrect kdev-java.
Mar 2 2019, 3:55 AM · KDevelop

Aug 8 2017

davispuh committed R32:9b999526d4fe: Remove deprecated IProject methods (authored by davispuh).
Remove deprecated IProject methods
Aug 8 2017, 4:53 PM
davispuh committed R32:571997f6c890: Remove KDELibs4Support (authored by davispuh).
Remove KDELibs4Support
Aug 8 2017, 4:53 PM
davispuh committed R32:81081262bc3e: Cleanup headers, remove header dependency on KDELibs4Support (authored by davispuh).
Cleanup headers, remove header dependency on KDELibs4Support
Aug 8 2017, 4:53 PM
davispuh committed R32:d33afdbd7e2c: Port away SVN plugin from KDialog (authored by davispuh).
Port away SVN plugin from KDialog
Aug 8 2017, 4:53 PM
davispuh committed R32:0fd2e534cbc9: Port away CVS plugin from KDialog (authored by davispuh).
Port away CVS plugin from KDialog
Aug 8 2017, 4:53 PM
davispuh committed R32:e8fc787d3b3a: Port away from KNewStuffButton (authored by davispuh).
Port away from KNewStuffButton
Aug 8 2017, 4:53 PM
davispuh committed R32:2578d05bbeee: Clean up headers for appwizard; patchreview; shell/tests (authored by davispuh).
Clean up headers for appwizard; patchreview; shell/tests
Aug 8 2017, 4:53 PM
davispuh committed R32:c3ba74a00486: Port away from KIO::NetAccess (authored by davispuh).
Port away from KIO::NetAccess
Aug 8 2017, 4:53 PM
davispuh committed R32:c7f63519567c: Remove fileutils, just use QDir (authored by davispuh).
Remove fileutils, just use QDir
Aug 8 2017, 4:53 PM
davispuh committed R32:af03deece755: Use qCDebug instead of KDebug (authored by davispuh).
Use qCDebug instead of KDebug
Aug 8 2017, 4:49 PM
davispuh committed R32:18eb79879df7: Switch to QApplication in reviewboard test (authored by davispuh).
Switch to QApplication in reviewboard test
Aug 8 2017, 4:48 PM
davispuh committed R32:5a604ac4b392: Remove deprecated TestProject::TestProject(KUrl, QObject) (authored by davispuh).
Remove deprecated TestProject::TestProject(KUrl, QObject)
Aug 8 2017, 4:48 PM
davispuh committed R32:0a6253d90961: Replace KIO::NetAccess with asynchronous KIO::storedPut in FileManager… (authored by davispuh).
Replace KIO::NetAccess with asynchronous KIO::storedPut in FileManager…
Aug 8 2017, 4:47 PM
davispuh committed R32:53ee2587fddf: Improve SourceFormatterController::formatFiles by using KIO::storedGet instead… (authored by davispuh).
Improve SourceFormatterController::formatFiles by using KIO::storedGet instead…
Aug 8 2017, 4:47 PM
davispuh committed R32:6aba4cbdc55d: Add prettyFileName test for ProjectController and replace Project::open with… (authored by davispuh).
Add prettyFileName test for ProjectController and replace Project::open with…
Aug 8 2017, 4:47 PM

Dec 10 2016

davispuh committed R138:9dccd4aee1b5: Double quote paths so they can contain whitespace (authored by davispuh).
Double quote paths so they can contain whitespace
Dec 10 2016, 6:59 PM

Dec 6 2016

davispuh committed R32:762f6bfa06f6: Use IProject->path() instead of folder() which is deprecated and will be removed (authored by davispuh).
Use IProject->path() instead of folder() which is deprecated and will be removed
Dec 6 2016, 10:02 PM

Feb 8 2016

davispuh committed R120:51266c34af7d: Add DBusMenuShortcut type overload for QDBusArgument (authored by davispuh).
Add DBusMenuShortcut type overload for QDBusArgument
Feb 8 2016, 10:56 PM

Jan 5 2016

davispuh committed R108:3e255e6969fc: Remove KWIN_BUILD_COVERAGE (authored by davispuh).
Remove KWIN_BUILD_COVERAGE
Jan 5 2016, 3:52 PM

Sep 19 2015

davispuh committed R34:489028c7c710: Use QStringLiteral for QFont (authored by davispuh).
Use QStringLiteral for QFont
Sep 19 2015, 1:47 PM

Sep 1 2015

davispuh closed D288: Enable MaildirSettings.
Sep 1 2015, 1:08 AM · KDE PIM

Aug 28 2015

davispuh updated D288: Enable MaildirSettings.
Aug 28 2015, 11:13 PM · KDE PIM
davispuh retitled D288: Enable MaildirSettings from to Enable MaildirSettings.
Aug 28 2015, 11:07 PM · KDE PIM