In D16344#349054, @aacid wrote:

In D16344#348985, @stikonas wrote:

Can you confirm that it works with TLSv1.2 only sites? (e.g. https://stikonas.eu:5281/admin/). Ideally we should test with TLSv1.3 too.

Yes, it works. And https://tls13.crypto.mozilla.org/ works too (on Konqueror using KHTML, sadly not on falkon because i guess it doesn't use the kioslave infrastructure, but that's a different story i guess)

Line 89 in https://api.kde.org/frameworks/kio/html/ktcpsocket_8cpp_source.html suggests that it is the same as QSsl:SecureProtocols.

I don't mess with keyboards enough to be able to say whether this is a good feature or a change that will be annoying.

I tested this patch and it works for me.

Maybe it be better to use SI abbreviations with decimals?
With SI units we always use the same symbol, it's 1 km, 3.5 km, 0.5 km, etc...

In D16090#340265, @acrouthamel wrote:

Can you only use amazon.de? Or can USA people use amazon.com as well?

Maybe make DocTools optional if you already touch it...

By the way, is there any backtrace? Just so that we can compare it to some of those crash on exit bugs on bugzilla... (e.g. https://bugs.kde.org/show_bug.cgi?id=384476)

Well, I guess good to go since it fixes crashes on exit. I wonder if it's the same crash on exit many people were getting but I can't reproduce.

Can you fix a spelling mistake in the comment? (casuses)

Thanks for letting me know!

In R433:7ddc10d3e51c0e0982b654a5fe6a8daa3ba10850#3684686, @wbauer wrote:

In R433:7ddc10d3e51c0e0982b654a5fe6a8daa3ba10850#3684679, @stikonas wrote:

Ah. Sorry, a small misunderstanding. Well, nothing harmful at least :).

Indeed.

So just to arrange, let's push the minimum KF5 version to 5.44?
That would also make it possible to remove some workarounds for other bugs in KF5 I added...

As I said, I plan to do that early next week. So speek up before that if you disagree. ;-)

In R433:7ddc10d3e51c0e0982b654a5fe6a8daa3ba10850#3684676, @wbauer wrote:

In R433:7ddc10d3e51c0e0982b654a5fe6a8daa3ba10850#3684675, @stikonas wrote:

I thought we agreed that we don't need to bump minimum version...

Yes, but I also wrote in the bug report that I'll do it for master/18.12:

But I'd rather wait for 18.12 with that, as you say.

I.e. I'll do it for master, and then raise the minimum KF5 version...

I probably wasn't clear enough though.

So, I do plan to raise the minimum KF5 version for 18.12.
Unless you disagree, but I somehow think you don't... ;-)

In R433:7ddc10d3e51c0e0982b654a5fe6a8daa3ba10850#3684671, @wbauer wrote:

Thanks!

I didn't forget about it though, I'll upgrade the minimum KF5 versions next week.

Submitted: https://commits.kde.org/ktorrent/8e40c371fa3982dec38688030d8733429ab5a8a2

Hi again. I'm assuming you don't have kde git commit access yet (if you do. please commit). If not, I can commit it for you but I need name, surname and email for that. I can see name and surname in your phabricator account but I need email too.

Thanks!