• Don't store bool in StateData

• Fix attributes in "KDE" and "Vim (dark)" themes

• Use QStringLiteral

• Pass schema name as parameter

• Add some comments

• Fix theme names

Convert theme names from KTextEditor => KSyntaxHighlighting and avoid using invalid KSyntaxHighlighting::Theme objects.

It isn't possible to compile, because the elm.xml file has multiple issues :(
The script "data/schema/validatehl.sh" serves to verify the XML files:

cd syntax-highlighting/data/schema/
./validatehl.sh ../syntax/elm.xml

Output:

../syntax/elm.xml:3: element language: Schemas validity error : Element 'language', attribute 'version': '1.0' is not a valid value of the atomic type 'xs:integer'.
../syntax/elm.xml:43: element WordDetect: Schemas validity error : Element 'WordDetect', attribute 'string': The attribute 'string' is not allowed.
../syntax/elm.xml:43: element WordDetect: Schemas validity error : Element 'WordDetect': The attribute 'String' is required but missing.
../syntax/elm.xml:84: element StringDetect: Schemas validity error : Element 'StringDetect', attribute 'char': The attribute 'char' is not allowed.
../syntax/elm.xml:84: element StringDetect: Schemas validity error : Element 'StringDetect': The attribute 'String' is required but missing.
../syntax/elm.xml:86: element context: Schemas validity error : Element 'context': The attribute 'lineEndContext' is required but missing.
../syntax/elm.xml:93: element context: Schemas validity error : Element 'context': The attribute 'lineEndContext' is required but missing.
../syntax/elm.xml:102: element context: Schemas validity error : Element 'context': The attribute 'lineEndContext' is required but missing.
../syntax/elm.xml:114: element itemDatas: Schemas validity error : Element 'itemDatas': This element is not expected. Expected is ( context ).
../syntax/elm.xml:4: element highlighting: Schemas validity error : Element 'highlighting': Missing child element(s). Expected is ( itemDatas ).
../syntax/elm.xml fails to validate

For example: </contexts> (line 133) must be placed before <itemDatas> and dsHexVal isn't a valid default style (use dsBaseN, look here). By solving it, maybe compile everything well.

Yes, this corresponds to the bug you mention.
In the "Vim (dark)" scheme, bold="0" doesn't work either, since all the text is bold.

• Update styles

In D19324 the icons for code and code-oss were added, which also need symbolic links for Flatpak (com.visualstudio.code & com.visualstudio.code.oss)

+1
Also missing the symlink for JDownloader (org.jdownloader.JDownloader.svg): https://flathub.org/apps/details/org.jdownloader.JDownloader

I want to check the colors of this highlighter before doing the commit

Use: cmake ./ && make to compile

I still have problems with dsError + underline="0" :(
In "autotest/html" these aren't underlined, but when I open the file "test.logcat" with Kate, it's underlined.
I even tried creating a new Unix user, but the problem persists (I'm using KDE Frameworks 5.55.0).
Even removing the underlines in "Configure Kate -> Fonts & Colors", the problem persists.
Also clarify that the file "$HOME/.config/katesyntaxhighlightingrc" doesn't exist.

Not seem, from what I see it is a recent bug. I just checked it in KDE Frameworks 5.48.0 (Fedora 28) and it works correctly

• Add tests

The MustacheJS highlight is modified in this diff: D19328

I can add more examples in "autotests/input/highlight.php", for all the cases of languages ​​included

• Add unit test

It's good, I think it's a better solution ;D

Some highlighters use endRegion+lookAhead to determine the end of a region when a new one starts, that is, they don't consider the text with endRegion+lookAhead as part of the fold region. This behavior was present before the implementation of KSyntaxHighlighting and, apparently, is no longer from the commit: c004f3f787b2

If you are only going to use the "admonition" keywords list for autocompletion, you could add them to the end of the context "section" or "start", keeping the attribute (Normal). I have done this in some highlight files

Hi!!
Please, also add a test file in: "autotests/input/". To generate the files in "folding", "html" and "reference" use make test and autotests/update-reference-data.sh.

The bug is identical to D17891 !
Please, also put #pop!error in fallthroughContext="error", on lines 238 and 363.
And increase the file version

• Small correction in comment

• Small modification in comments

• Update test file

I asked in the thread of the Wesnoth forum, that appears in the wml.xml file (http://www.wesnoth.org/forum/viewtopic.php?f=21&t=13781), if the changes are OK and someone has suggested to me that the array indices (array[0]) aren't highlighted as tags, as well that I included it

• Fix RegExp of tag name

• typescript.xml & typescript-react.xml: add some comments and the operator "!" after objects

https://github.com/Microsoft/TypeScript/wiki/What's-new-in-TypeScript#non-null-assertion-operator

• rust.xml: fix indentation.

The file uses tabs, but in one part I used spaces as indentation

• Add tests

• Update comment

I attach two files. The "usr.bin.firefox" file causes the error on line 31 and "usr.bin.apparmor-profile-test" on line 184.

I did debug with gdb and valgrind, but the information is not relevant, since Kate freezes and I have to kill the process (I think I used the term "crash" incorrectly :S).
I have done some tests and the problem is in the use of #pop!some_context on the main context ("_profile").
For example, formerly, when doing #pop!some_context on the main context, "some_context" was stacked on top of the main context, it did not replace it. Now, in KF5.50.0, the main context is removed from de "stack" and replaced by "some_context". In the AppArmor XML file I use #pop#pop!some_context in general to finish a rule and, in some cases, #pop!some_context is done in the main context, which produces the error in large files, since it is not a behavior that I envisioned.