jpoelen (jonathan poelen)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Jun 4 2017, 12:22 AM (115 w, 3 d)
Availability
Available

Recent Activity

Today

jpoelen requested review of D23312: JSP: support of <script> and <style> ; use IncludeRule ##Java.
Wed, Aug 21, 12:54 AM · Frameworks, Kate
jpoelen committed R216:63719f49867b: LESS: import CSS keywords, new highlighting and some improvements (authored by jpoelen).
LESS: import CSS keywords, new highlighting and some improvements
Wed, Aug 21, 12:10 AM
jpoelen closed D23278: LESS: import CSS keywords, new highlighting and some improvements.
Wed, Aug 21, 12:10 AM · Frameworks, Kate
jpoelen added a comment to D23278: LESS: import CSS keywords, new highlighting and some improvements.

The other files that use the include statement are also in version 5.53.

Wed, Aug 21, 12:09 AM · Frameworks, Kate

Mon, Aug 19

jpoelen added reviewers for D23278: LESS: import CSS keywords, new highlighting and some improvements: Framework: Syntax Highlighting, dhaumann, cullmann.
Mon, Aug 19, 9:54 PM · Frameworks, Kate
jpoelen requested review of D23278: LESS: import CSS keywords, new highlighting and some improvements.
Mon, Aug 19, 9:52 PM · Frameworks, Kate
jpoelen committed R216:0edc0cb01ab7: New syntax: SASS. Some fixes for CSS and SCSS (authored by jpoelen).
New syntax: SASS. Some fixes for CSS and SCSS
Mon, Aug 19, 9:23 PM
jpoelen closed D23245: New syntax: SASS. Some fixes for CSS and SCSS.
Mon, Aug 19, 9:23 PM · Frameworks, Kate

Sun, Aug 18

jpoelen requested review of D23245: New syntax: SASS. Some fixes for CSS and SCSS.
Sun, Aug 18, 7:32 PM · Frameworks, Kate

Fri, Aug 16

jpoelen requested review of D23195: SCSS: fix interpolation (#{...}) and add the Interpolation color.
Fri, Aug 16, 12:48 AM · Frameworks, Kate

Thu, Aug 15

jpoelen added a comment to D23135: Gettext: fix "previous untranslated string" and other improvements/fixes.

If it is better not to have a hard-coded color, wouldn't it be better to remove them once and for all? Without necessarily incrementing the version.

Thu, Aug 15, 6:39 PM · Frameworks, Kate
jpoelen added a comment to D14632: keyword rule: Spport for keywords inclusion from another language/file.

I don't think using the original word delimiters is a good thing. Let's imagine that c.xml lists the functions of the libc and a language that allows them to be used as ffi.C.printf (luajit for the curious). The separators of the 2 languages are not the same and puts'plop' works for one, but not for the other. If we rely on the C delimiters, it will not work anymore. I think we can find other examples and perhaps counter-examples.

Thu, Aug 15, 6:27 PM · Frameworks, Kate

Wed, Aug 14

jpoelen updated the diff for D23134: fix additionalDeliminator attribute.
  • add unit test
Wed, Aug 14, 11:14 PM · Frameworks, Kate
jpoelen updated the diff for D23137: C++: contracts are not in C++20.
  • increase version
Wed, Aug 14, 12:48 AM · Frameworks, Kate

Tue, Aug 13

jpoelen requested review of D23137: C++: contracts are not in C++20.
Tue, Aug 13, 11:41 PM · Frameworks, Kate
jpoelen requested review of D23136: Jam: Fix local with variable without initilisation and highlight SubRule.
Tue, Aug 13, 11:33 PM · Frameworks, Kate
jpoelen requested review of D23135: Gettext: fix "previous untranslated string" and other improvements/fixes.
Tue, Aug 13, 11:19 PM · Frameworks, Kate
jpoelen added a comment to D23134: fix additionalDeliminator attribute.

I don't understand why there's so much difference in what's displayed :/

Tue, Aug 13, 10:56 PM · Frameworks, Kate
jpoelen requested review of D23134: fix additionalDeliminator attribute.
Tue, Aug 13, 10:52 PM · Frameworks, Kate

Sat, Aug 10

jpoelen updated the diff for D23034: implicit fallthough if there is fallthoughContext.
  • don't modify the *.xml files to maintain the compatibility in older versions of KF5
  • langauge.xsd: accept only 1 or true for fallthrough attribute
Sat, Aug 10, 1:01 AM · Frameworks, Kate
jpoelen added a comment to D23034: implicit fallthough if there is fallthoughContext.

I will hand over the original xml files, that seems preferable to me too.

Sat, Aug 10, 12:18 AM · Frameworks, Kate

Fri, Aug 9

jpoelen requested review of D23034: implicit fallthough if there is fallthoughContext.
Fri, Aug 9, 12:31 AM · Frameworks, Kate
jpoelen committed R216:75e233dc5792: Latex: several fixes (math mode, nested verbatim, ...) (authored by jpoelen).
Latex: several fixes (math mode, nested verbatim, ...)
Fri, Aug 9, 12:07 AM
jpoelen closed D23013: Latex: several fixes (math mode, nested verbatim, ...).
Fri, Aug 9, 12:07 AM · Frameworks, Kate
jpoelen updated the summary of D23013: Latex: several fixes (math mode, nested verbatim, ...).
Fri, Aug 9, 12:05 AM · Frameworks, Kate
jpoelen added a comment to D23013: Latex: several fixes (math mode, nested verbatim, ...).

The 410477 did not exist when I started my modifications, I add it in the list.

Fri, Aug 9, 12:03 AM · Frameworks, Kate

Thu, Aug 8

jpoelen updated the diff for D23013: Latex: several fixes (math mode, nested verbatim, ...).

At first, I didn't have much change. But as I broke my teeth on one of the bugs and there were some problems here and there, I armed myself with a bulldozer :D

Thu, Aug 8, 11:54 PM · Frameworks, Kate
jpoelen committed R216:2b06bf42be04: Lua: fix color of end with several levels of condition and function nesting (authored by jpoelen).
Lua: fix color of end with several levels of condition and function nesting
Thu, Aug 8, 11:31 PM
jpoelen closed D23014: Lua: fix color of end with several levels of condition and function nesting.
Thu, Aug 8, 11:31 PM · Frameworks, Kate
jpoelen updated the diff for D23014: Lua: fix color of end with several levels of condition and function nesting.

increase the version number

Thu, Aug 8, 11:27 PM · Frameworks, Kate

Wed, Aug 7

jpoelen requested review of D23015: Highlighting indexer: all warnings are fatal.
Wed, Aug 7, 10:09 PM · Frameworks, Kate
jpoelen requested review of D23014: Lua: fix color of end with several levels of condition and function nesting.
Wed, Aug 7, 10:07 PM · Frameworks, Kate
jpoelen requested review of D23013: Latex: several fixes (math mode, nested verbatim, ...).
Wed, Aug 7, 9:56 PM · Frameworks, Kate

Jun 30 2019

jpoelen added a comment to D21586: Add syntax definition for ninja build.

After reflection (:D), I think the constraint is weak, the creation of new syntax is rare compared to the rest.

Jun 30 2019, 1:17 AM · Frameworks, Kate, Framework: Syntax Highlighting

Jun 8 2019

jpoelen committed R216:a72b6b5e53ec: Add syntax definition for ninja build (authored by jpoelen).
Add syntax definition for ninja build
Jun 8 2019, 9:41 PM
jpoelen closed D21586: Add syntax definition for ninja build.
Jun 8 2019, 9:40 PM · Frameworks, Kate, Framework: Syntax Highlighting

Jun 6 2019

jpoelen updated the diff for D21586: Add syntax definition for ninja build.

I am confused, the generation of index.katesyntax fails because the list "variables" does not exist (there is no variable predefined in this context). We may be in a situation where a change of branch does not recompile the index file :/.

Jun 6 2019, 2:29 AM · Frameworks, Kate, Framework: Syntax Highlighting

Jun 4 2019

jpoelen committed R216:6864c25f1d54: Jam: various improvements and fixes (authored by jpoelen).
Jam: various improvements and fixes
Jun 4 2019, 11:50 PM
jpoelen closed D21508: Jam: various improvements and fixes.
Jun 4 2019, 11:50 PM · Frameworks, Kate
jpoelen committed R216:602bbc7b7397: Lua: update for Lua54 and end of function as Keyword rather than Control (authored by jpoelen).
Lua: update for Lua54 and end of function as Keyword rather than Control
Jun 4 2019, 11:49 PM
jpoelen closed D21587: Lua: update for Lua54 and end of function as Keyword rather than Control.
Jun 4 2019, 11:49 PM · Frameworks, Kate, Framework: Syntax Highlighting
jpoelen committed R216:9ba02971123d: C++: update for C++20 (authored by jpoelen).
C++: update for C++20
Jun 4 2019, 11:46 PM
jpoelen closed D21585: C++: update for C++20.
Jun 4 2019, 11:46 PM · Frameworks, Kate, Framework: Syntax Highlighting
jpoelen updated the diff for D21585: C++: update for C++20.

oops, missing version increase

Jun 4 2019, 8:27 PM · Frameworks, Kate, Framework: Syntax Highlighting
jpoelen updated the summary of D21587: Lua: update for Lua54 and end of function as Keyword rather than Control.
Jun 4 2019, 7:42 PM · Frameworks, Kate, Framework: Syntax Highlighting
jpoelen requested review of D21587: Lua: update for Lua54 and end of function as Keyword rather than Control.
Jun 4 2019, 7:41 PM · Frameworks, Kate, Framework: Syntax Highlighting
jpoelen requested review of D21586: Add syntax definition for ninja build.
Jun 4 2019, 7:32 PM · Frameworks, Kate, Framework: Syntax Highlighting
jpoelen requested review of D21585: C++: update for C++20.
Jun 4 2019, 7:30 PM · Frameworks, Kate, Framework: Syntax Highlighting
jpoelen updated the diff for D21508: Jam: various improvements and fixes.
  • fix module
  • remove hard coded color
Jun 4 2019, 6:46 PM · Frameworks, Kate

Jun 1 2019

jpoelen added a comment to D21508: Jam: various improvements and fixes.

I left it because it goes well with dark or light themes, but I removed it. Is the policy the same for bold, underlined and italic as for color? Because a basic applied distinction between Comment and CommentTitle seems to me preferable. I imagine not, but I would like to be sure.

Jun 1 2019, 1:40 PM · Frameworks, Kate

May 30 2019

jpoelen requested review of D21508: Jam: various improvements and fixes.
May 30 2019, 10:14 PM · Frameworks, Kate
jpoelen added a comment to D21421: Tcsh: fix operators and keywords.

OK I understand. Initially I had not changed the version number of txsh.xml and it is based on the reference in /usr/share/org.kde.syntax-highlighting/syntax/index.katesyntax rather than in the repository.
And the fact that the versions in the index file were newer than my xml files... I had errors with highlight.fish.

May 30 2019, 3:26 PM · Frameworks, Kate, Framework: Syntax Highlighting

May 27 2019

jpoelen committed R216:4d2329e3f63e: Tcsh: fix operators and keywords (authored by jpoelen).
Tcsh: fix operators and keywords
May 27 2019, 9:03 PM
jpoelen closed D21421: Tcsh: fix operators and keywords.
May 27 2019, 9:03 PM · Frameworks, Kate, Framework: Syntax Highlighting
jpoelen added a comment to D21421: Tcsh: fix operators and keywords.

I forgot to ask about running the tests. Is it normal that system syntax files take precedence if we have an index.katesyntax? Currently I have to run the tests by setting the environment variable XDG_DATA_DIRS.

May 27 2019, 8:34 PM · Frameworks, Kate, Framework: Syntax Highlighting

May 26 2019

jpoelen requested review of D21421: Tcsh: fix operators and keywords.
May 26 2019, 9:39 PM · Frameworks, Kate, Framework: Syntax Highlighting

Jan 10 2019

jpoelen added a comment to D10621: Highlighting Indexer: list of suggestions.

I agree that some rules are excessive or even false, but the last time I watched (it was several months ago now), some regexes suggested to be DetectString seemed to have writing errors (mainly \\ count as 2 characters in xml) and some more or less useful propositions. If there has been no change at this level, it should still be checked.

Jan 10 2019, 2:03 AM · Kate, Framework: Syntax Highlighting, Frameworks

Sep 30 2018

jpoelen updated the diff for D14632: keyword rule: Spport for keywords inclusion from another language/file.
  • fix the recursion detection and handling of nested included keyword lists
Sep 30 2018, 10:02 PM · Frameworks, Kate

Sep 17 2018

jpoelen added a comment to D14632: keyword rule: Spport for keywords inclusion from another language/file.

(I inadvertently edit the operators list in the previous commit)

Sep 17 2018, 11:35 PM · Frameworks, Kate
jpoelen updated the diff for D14632: keyword rule: Spport for keywords inclusion from another language/file.
  • restore operators list
  • lazy load keyword lists
Sep 17 2018, 11:31 PM · Frameworks, Kate

Sep 16 2018

jpoelen added a comment to D14632: keyword rule: Spport for keywords inclusion from another language/file.

resolveIncludeKeywords() would then use loadKeywords() instead of load() ? This should be enough.

Sep 16 2018, 9:22 PM · Frameworks, Kate

Sep 15 2018

jpoelen added a comment to D14632: keyword rule: Spport for keywords inclusion from another language/file.

Sorry to answer so late, I had trouble logging in.

Sep 15 2018, 11:56 PM · Frameworks, Kate

Sep 9 2018

jpoelen updated the diff for D14632: keyword rule: Spport for keywords inclusion from another language/file.

include rule in keyword list to import those from another file

Sep 9 2018, 9:23 PM · Frameworks, Kate

Aug 19 2018

jpoelen committed R216:3ebb3c09e512: SQL: various improvements and fix if/case/loop/end detection with SQL (Oracle) (authored by jpoelen).
SQL: various improvements and fix if/case/loop/end detection with SQL (Oracle)
Aug 19 2018, 6:53 PM
jpoelen closed D11470: SQL: various improvements and fix if/case/loop/end detection with SQL (Oracle).
Aug 19 2018, 6:53 PM · Kate, Frameworks
jpoelen added a comment to D14603: SCSS: update syntax. CSS: fix Operator and Selector Tag highlighting.

Yes, my compilation folder was pointing to my fork on github from which I make the patches (as I do not have the right version for ECM, I have a script that does among other things a new CMakeLists.txt in another folder and adds symbolic links for project files). If there was no more error it was because I saw them in the conflicts.

Aug 19 2018, 6:37 PM · Frameworks, Kate
jpoelen committed R216:113ebe28645a: SCSS: update syntax. CSS: fix Operator and Selector Tag highlighting (authored by jpoelen).
SCSS: update syntax. CSS: fix Operator and Selector Tag highlighting
Aug 19 2018, 3:50 PM
jpoelen closed D14603: SCSS: update syntax. CSS: fix Operator and Selector Tag highlighting.
Aug 19 2018, 3:50 PM · Frameworks, Kate

Aug 13 2018

jpoelen added a comment to D14603: SCSS: update syntax. CSS: fix Operator and Selector Tag highlighting.

Ok, i'm doing this in the week.

Aug 13 2018, 11:58 PM · Frameworks, Kate
jpoelen added a comment to D11470: SQL: various improvements and fix if/case/loop/end detection with SQL (Oracle).

There have been changes in the xml files that will cause conflicts. I would look in the next few days.

Aug 13 2018, 11:56 PM · Kate, Frameworks

Aug 6 2018

jpoelen added a comment to D14632: keyword rule: Spport for keywords inclusion from another language/file.

I just thought of Definition::keywordLists() which does not list the keywords used by this new syntax.

Aug 6 2018, 10:26 PM · Frameworks, Kate
jpoelen updated the summary of D14632: keyword rule: Spport for keywords inclusion from another language/file.
Aug 6 2018, 10:12 PM · Frameworks, Kate

Aug 5 2018

jpoelen updated the test plan for D14632: keyword rule: Spport for keywords inclusion from another language/file.
Aug 5 2018, 5:13 PM · Frameworks, Kate
jpoelen requested review of D14632: keyword rule: Spport for keywords inclusion from another language/file.
Aug 5 2018, 5:10 PM · Frameworks, Kate

Aug 4 2018

jpoelen added a comment to D14603: SCSS: update syntax. CSS: fix Operator and Selector Tag highlighting.

Yes, I can start tomorrow.

Aug 4 2018, 10:22 PM · Frameworks, Kate
jpoelen added a comment to D14603: SCSS: update syntax. CSS: fix Operator and Selector Tag highlighting.

I copied all the keywords in the css.xml file and it's a shame. I think that Keyword could refer to those of other files with ## as for IncludeRules.

Aug 4 2018, 2:47 PM · Frameworks, Kate
jpoelen requested review of D14603: SCSS: update syntax. CSS: fix Operator and Selector Tag highlighting.
Aug 4 2018, 2:39 PM · Frameworks, Kate

Aug 1 2018

jpoelen committed R230:d5bf67511ca3: Add myself (jpoelen) to relicensecheck.pl (authored by jpoelen).
Add myself (jpoelen) to relicensecheck.pl
Aug 1 2018, 10:15 PM

Jul 27 2018

jpoelen added a comment to D14434: add functions to access keywords.

This follows https://mail.kde.org/pipermail/kde-frameworks-devel/2018-July/066564.html

Jul 27 2018, 11:55 PM · Frameworks, Kate
jpoelen requested review of D14434: add functions to access keywords.
Jul 27 2018, 11:52 PM · Frameworks, Kate

Jul 23 2018

jpoelen committed R216:a82af177bc2f: CSS: fix test reference of the previous commit (authored by jpoelen).
CSS: fix test reference of the previous commit
Jul 23 2018, 9:22 PM
jpoelen closed D14282: CSS: fix test reference of the previous commit.
Jul 23 2018, 9:22 PM · Frameworks, Kate
jpoelen committed R216:7a2ae6be229b: C++: fix standard floating-point literals (authored by jpoelen).
C++: fix standard floating-point literals
Jul 23 2018, 9:21 PM
jpoelen closed D14283: C++: fix standard floating-point literals.
Jul 23 2018, 9:21 PM · Frameworks, Kate

Jul 22 2018

jpoelen requested review of D14283: C++: fix standard floating-point literals.
Jul 22 2018, 11:24 PM · Frameworks, Kate
jpoelen requested review of D14282: CSS: fix test reference of the previous commit.
Jul 22 2018, 11:06 PM · Frameworks, Kate

Jul 16 2018

jpoelen added a comment to D14137: CSS: update syntax and fix some errors.

It is done. So much emotion :')

Jul 16 2018, 9:33 PM · Framework: Syntax Highlighting, Kate, Frameworks
jpoelen committed R216:423239c45ec5: CSS: update syntax and fix some errors (authored by jpoelen).
CSS: update syntax and fix some errors
Jul 16 2018, 9:30 PM
jpoelen closed D14137: CSS: update syntax and fix some errors.
Jul 16 2018, 9:30 PM · Framework: Syntax Highlighting, Kate, Frameworks

Jul 15 2018

jpoelen requested review of D14137: CSS: update syntax and fix some errors.
Jul 15 2018, 3:54 PM · Framework: Syntax Highlighting, Kate, Frameworks

Jul 14 2018

jpoelen added a comment to D13394: C++: update for c++20 and fix some syntax errors.

Thank you, but I already made the request and it was accepted last night. I will do the next push :)

Jul 14 2018, 8:59 PM · Kate, Frameworks

Jul 1 2018

jpoelen requested review of D13829: Lua: fix multi-line string.
Jul 1 2018, 2:32 PM · Kate, Frameworks

Jun 23 2018

jpoelen added a comment to D13394: C++: update for c++20 and fix some syntax errors.

I do not have a developer account, but I can do it. This is not a problem because I will contribute again.

Jun 23 2018, 6:38 PM · Kate, Frameworks

Jun 18 2018

jpoelen added inline comments to D13394: C++: update for c++20 and fix some syntax errors.
Jun 18 2018, 10:13 PM · Kate, Frameworks

Jun 16 2018

jpoelen updated the diff for D13394: C++: update for c++20 and fix some syntax errors.
  • C++: test with clang:: in an attribute
Jun 16 2018, 3:05 PM · Kate, Frameworks

Jun 7 2018

jpoelen requested review of D13395: Pony: fix single quote escape and a possible infinite loop with #.
Jun 7 2018, 12:33 AM · Frameworks
jpoelen added a reviewer for D13394: C++: update for c++20 and fix some syntax errors: dhaumann.
Jun 7 2018, 12:17 AM · Kate, Frameworks
jpoelen requested review of D13394: C++: update for c++20 and fix some syntax errors.
Jun 7 2018, 12:05 AM · Kate, Frameworks

May 21 2018

jpoelen added a comment to D12689: Lua: updated for Lua5.3.

@dhaumann The difference is in the dynamic attribute of a context. Kate propagates the captures only if the value is true whereas SyntaxHighlighting never looks at that value and only uses the dynamic attribute of the rules.

May 21 2018, 5:46 PM · Frameworks, Framework: Syntax Highlighting

May 14 2018

jpoelen updated the diff for D12854: Awk: fix regex in a function and update syntax for gawk.
  • Awk: add collating symbols and equivalence classes
May 14 2018, 2:41 AM · Framework: Syntax Highlighting, Frameworks