jpoelen (jonathan poelen)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Jun 4 2017, 12:22 AM (106 w, 31 m)
Availability
Available

Recent Activity

Sat, Jun 8

jpoelen committed R216:a72b6b5e53ec: Add syntax definition for ninja build (authored by jpoelen).
Add syntax definition for ninja build
Sat, Jun 8, 9:41 PM
jpoelen closed D21586: Add syntax definition for ninja build.
Sat, Jun 8, 9:40 PM · Frameworks, Kate, Framework: Syntax Highlighting

Thu, Jun 6

jpoelen updated the diff for D21586: Add syntax definition for ninja build.

I am confused, the generation of index.katesyntax fails because the list "variables" does not exist (there is no variable predefined in this context). We may be in a situation where a change of branch does not recompile the index file :/.

Thu, Jun 6, 2:29 AM · Frameworks, Kate, Framework: Syntax Highlighting

Tue, Jun 4

jpoelen committed R216:6864c25f1d54: Jam: various improvements and fixes (authored by jpoelen).
Jam: various improvements and fixes
Tue, Jun 4, 11:50 PM
jpoelen closed D21508: Jam: various improvements and fixes.
Tue, Jun 4, 11:50 PM · Frameworks, Kate
jpoelen committed R216:602bbc7b7397: Lua: update for Lua54 and end of function as Keyword rather than Control (authored by jpoelen).
Lua: update for Lua54 and end of function as Keyword rather than Control
Tue, Jun 4, 11:49 PM
jpoelen closed D21587: Lua: update for Lua54 and end of function as Keyword rather than Control.
Tue, Jun 4, 11:49 PM · Frameworks, Kate, Framework: Syntax Highlighting
jpoelen committed R216:9ba02971123d: C++: update for C++20 (authored by jpoelen).
C++: update for C++20
Tue, Jun 4, 11:46 PM
jpoelen closed D21585: C++: update for C++20.
Tue, Jun 4, 11:46 PM · Frameworks, Kate, Framework: Syntax Highlighting
jpoelen updated the diff for D21585: C++: update for C++20.

oops, missing version increase

Tue, Jun 4, 8:27 PM · Frameworks, Kate, Framework: Syntax Highlighting
jpoelen updated the summary of D21587: Lua: update for Lua54 and end of function as Keyword rather than Control.
Tue, Jun 4, 7:42 PM · Frameworks, Kate, Framework: Syntax Highlighting
jpoelen requested review of D21587: Lua: update for Lua54 and end of function as Keyword rather than Control.
Tue, Jun 4, 7:41 PM · Frameworks, Kate, Framework: Syntax Highlighting
jpoelen requested review of D21586: Add syntax definition for ninja build.
Tue, Jun 4, 7:32 PM · Frameworks, Kate, Framework: Syntax Highlighting
jpoelen requested review of D21585: C++: update for C++20.
Tue, Jun 4, 7:30 PM · Frameworks, Kate, Framework: Syntax Highlighting
jpoelen updated the diff for D21508: Jam: various improvements and fixes.
  • fix module
  • remove hard coded color
Tue, Jun 4, 6:46 PM · Frameworks, Kate

Sat, Jun 1

jpoelen added a comment to D21508: Jam: various improvements and fixes.

I left it because it goes well with dark or light themes, but I removed it. Is the policy the same for bold, underlined and italic as for color? Because a basic applied distinction between Comment and CommentTitle seems to me preferable. I imagine not, but I would like to be sure.

Sat, Jun 1, 1:40 PM · Frameworks, Kate

Thu, May 30

jpoelen requested review of D21508: Jam: various improvements and fixes.
Thu, May 30, 10:14 PM · Frameworks, Kate
jpoelen added a comment to D21421: Tcsh: fix operators and keywords.

OK I understand. Initially I had not changed the version number of txsh.xml and it is based on the reference in /usr/share/org.kde.syntax-highlighting/syntax/index.katesyntax rather than in the repository.
And the fact that the versions in the index file were newer than my xml files... I had errors with highlight.fish.

Thu, May 30, 3:26 PM · Frameworks, Kate, Framework: Syntax Highlighting

Mon, May 27

jpoelen committed R216:4d2329e3f63e: Tcsh: fix operators and keywords (authored by jpoelen).
Tcsh: fix operators and keywords
Mon, May 27, 9:03 PM
jpoelen closed D21421: Tcsh: fix operators and keywords.
Mon, May 27, 9:03 PM · Frameworks, Kate, Framework: Syntax Highlighting
jpoelen added a comment to D21421: Tcsh: fix operators and keywords.

I forgot to ask about running the tests. Is it normal that system syntax files take precedence if we have an index.katesyntax? Currently I have to run the tests by setting the environment variable XDG_DATA_DIRS.

Mon, May 27, 8:34 PM · Frameworks, Kate, Framework: Syntax Highlighting

Sun, May 26

jpoelen requested review of D21421: Tcsh: fix operators and keywords.
Sun, May 26, 9:39 PM · Frameworks, Kate, Framework: Syntax Highlighting

Jan 10 2019

jpoelen added a comment to D10621: Highlighting Indexer: list of suggestions.

I agree that some rules are excessive or even false, but the last time I watched (it was several months ago now), some regexes suggested to be DetectString seemed to have writing errors (mainly \\ count as 2 characters in xml) and some more or less useful propositions. If there has been no change at this level, it should still be checked.

Jan 10 2019, 2:03 AM · Kate, Framework: Syntax Highlighting, Frameworks

Sep 30 2018

jpoelen updated the diff for D14632: keyword rule: Spport for keywords inclusion from another language/file.
  • fix the recursion detection and handling of nested included keyword lists
Sep 30 2018, 10:02 PM · Frameworks, Kate

Sep 17 2018

jpoelen added a comment to D14632: keyword rule: Spport for keywords inclusion from another language/file.

(I inadvertently edit the operators list in the previous commit)

Sep 17 2018, 11:35 PM · Frameworks, Kate
jpoelen updated the diff for D14632: keyword rule: Spport for keywords inclusion from another language/file.
  • restore operators list
  • lazy load keyword lists
Sep 17 2018, 11:31 PM · Frameworks, Kate

Sep 16 2018

jpoelen added a comment to D14632: keyword rule: Spport for keywords inclusion from another language/file.

resolveIncludeKeywords() would then use loadKeywords() instead of load() ? This should be enough.

Sep 16 2018, 9:22 PM · Frameworks, Kate

Sep 15 2018

jpoelen added a comment to D14632: keyword rule: Spport for keywords inclusion from another language/file.

Sorry to answer so late, I had trouble logging in.

Sep 15 2018, 11:56 PM · Frameworks, Kate

Sep 9 2018

jpoelen updated the diff for D14632: keyword rule: Spport for keywords inclusion from another language/file.

include rule in keyword list to import those from another file

Sep 9 2018, 9:23 PM · Frameworks, Kate

Aug 19 2018

jpoelen committed R216:3ebb3c09e512: SQL: various improvements and fix if/case/loop/end detection with SQL (Oracle) (authored by jpoelen).
SQL: various improvements and fix if/case/loop/end detection with SQL (Oracle)
Aug 19 2018, 6:53 PM
jpoelen closed D11470: SQL: various improvements and fix if/case/loop/end detection with SQL (Oracle).
Aug 19 2018, 6:53 PM · Kate, Frameworks
jpoelen added a comment to D14603: SCSS: update syntax. CSS: fix Operator and Selector Tag highlighting.

Yes, my compilation folder was pointing to my fork on github from which I make the patches (as I do not have the right version for ECM, I have a script that does among other things a new CMakeLists.txt in another folder and adds symbolic links for project files). If there was no more error it was because I saw them in the conflicts.

Aug 19 2018, 6:37 PM · Frameworks, Kate
jpoelen committed R216:113ebe28645a: SCSS: update syntax. CSS: fix Operator and Selector Tag highlighting (authored by jpoelen).
SCSS: update syntax. CSS: fix Operator and Selector Tag highlighting
Aug 19 2018, 3:50 PM
jpoelen closed D14603: SCSS: update syntax. CSS: fix Operator and Selector Tag highlighting.
Aug 19 2018, 3:50 PM · Frameworks, Kate

Aug 13 2018

jpoelen added a comment to D14603: SCSS: update syntax. CSS: fix Operator and Selector Tag highlighting.

Ok, i'm doing this in the week.

Aug 13 2018, 11:58 PM · Frameworks, Kate
jpoelen added a comment to D11470: SQL: various improvements and fix if/case/loop/end detection with SQL (Oracle).

There have been changes in the xml files that will cause conflicts. I would look in the next few days.

Aug 13 2018, 11:56 PM · Kate, Frameworks

Aug 6 2018

jpoelen added a comment to D14632: keyword rule: Spport for keywords inclusion from another language/file.

I just thought of Definition::keywordLists() which does not list the keywords used by this new syntax.

Aug 6 2018, 10:26 PM · Frameworks, Kate
jpoelen updated the summary of D14632: keyword rule: Spport for keywords inclusion from another language/file.
Aug 6 2018, 10:12 PM · Frameworks, Kate

Aug 5 2018

jpoelen updated the test plan for D14632: keyword rule: Spport for keywords inclusion from another language/file.
Aug 5 2018, 5:13 PM · Frameworks, Kate
jpoelen requested review of D14632: keyword rule: Spport for keywords inclusion from another language/file.
Aug 5 2018, 5:10 PM · Frameworks, Kate

Aug 4 2018

jpoelen added a comment to D14603: SCSS: update syntax. CSS: fix Operator and Selector Tag highlighting.

Yes, I can start tomorrow.

Aug 4 2018, 10:22 PM · Frameworks, Kate
jpoelen added a comment to D14603: SCSS: update syntax. CSS: fix Operator and Selector Tag highlighting.

I copied all the keywords in the css.xml file and it's a shame. I think that Keyword could refer to those of other files with ## as for IncludeRules.

Aug 4 2018, 2:47 PM · Frameworks, Kate
jpoelen requested review of D14603: SCSS: update syntax. CSS: fix Operator and Selector Tag highlighting.
Aug 4 2018, 2:39 PM · Frameworks, Kate

Aug 1 2018

jpoelen committed R230:d5bf67511ca3: Add myself (jpoelen) to relicensecheck.pl (authored by jpoelen).
Add myself (jpoelen) to relicensecheck.pl
Aug 1 2018, 10:15 PM

Jul 27 2018

jpoelen added a comment to D14434: add functions to access keywords.

This follows https://mail.kde.org/pipermail/kde-frameworks-devel/2018-July/066564.html

Jul 27 2018, 11:55 PM · Frameworks, Kate
jpoelen requested review of D14434: add functions to access keywords.
Jul 27 2018, 11:52 PM · Frameworks, Kate

Jul 23 2018

jpoelen committed R216:a82af177bc2f: CSS: fix test reference of the previous commit (authored by jpoelen).
CSS: fix test reference of the previous commit
Jul 23 2018, 9:22 PM
jpoelen closed D14282: CSS: fix test reference of the previous commit.
Jul 23 2018, 9:22 PM · Frameworks, Kate
jpoelen committed R216:7a2ae6be229b: C++: fix standard floating-point literals (authored by jpoelen).
C++: fix standard floating-point literals
Jul 23 2018, 9:21 PM
jpoelen closed D14283: C++: fix standard floating-point literals.
Jul 23 2018, 9:21 PM · Frameworks, Kate

Jul 22 2018

jpoelen requested review of D14283: C++: fix standard floating-point literals.
Jul 22 2018, 11:24 PM · Frameworks, Kate
jpoelen requested review of D14282: CSS: fix test reference of the previous commit.
Jul 22 2018, 11:06 PM · Frameworks, Kate

Jul 16 2018

jpoelen added a comment to D14137: CSS: update syntax and fix some errors.

It is done. So much emotion :')

Jul 16 2018, 9:33 PM · Framework: Syntax Highlighting, Kate, Frameworks
jpoelen committed R216:423239c45ec5: CSS: update syntax and fix some errors (authored by jpoelen).
CSS: update syntax and fix some errors
Jul 16 2018, 9:30 PM
jpoelen closed D14137: CSS: update syntax and fix some errors.
Jul 16 2018, 9:30 PM · Framework: Syntax Highlighting, Kate, Frameworks

Jul 15 2018

jpoelen requested review of D14137: CSS: update syntax and fix some errors.
Jul 15 2018, 3:54 PM · Framework: Syntax Highlighting, Kate, Frameworks

Jul 14 2018

jpoelen added a comment to D13394: C++: update for c++20 and fix some syntax errors.

Thank you, but I already made the request and it was accepted last night. I will do the next push :)

Jul 14 2018, 8:59 PM · Kate, Frameworks

Jul 1 2018

jpoelen requested review of D13829: Lua: fix multi-line string.
Jul 1 2018, 2:32 PM · Kate, Frameworks

Jun 23 2018

jpoelen added a comment to D13394: C++: update for c++20 and fix some syntax errors.

I do not have a developer account, but I can do it. This is not a problem because I will contribute again.

Jun 23 2018, 6:38 PM · Kate, Frameworks

Jun 18 2018

jpoelen added inline comments to D13394: C++: update for c++20 and fix some syntax errors.
Jun 18 2018, 10:13 PM · Kate, Frameworks

Jun 16 2018

jpoelen updated the diff for D13394: C++: update for c++20 and fix some syntax errors.
  • C++: test with clang:: in an attribute
Jun 16 2018, 3:05 PM · Kate, Frameworks

Jun 7 2018

jpoelen requested review of D13395: Pony: fix single quote escape and a possible infinite loop with #.
Jun 7 2018, 12:33 AM · Frameworks
jpoelen added a reviewer for D13394: C++: update for c++20 and fix some syntax errors: dhaumann.
Jun 7 2018, 12:17 AM · Kate, Frameworks
jpoelen requested review of D13394: C++: update for c++20 and fix some syntax errors.
Jun 7 2018, 12:05 AM · Kate, Frameworks

May 21 2018

jpoelen added a comment to D12689: Lua: updated for Lua5.3.

@dhaumann The difference is in the dynamic attribute of a context. Kate propagates the captures only if the value is true whereas SyntaxHighlighting never looks at that value and only uses the dynamic attribute of the rules.

May 21 2018, 5:46 PM · Frameworks, Framework: Syntax Highlighting

May 14 2018

jpoelen updated the diff for D12854: Awk: fix regex in a function and update syntax for gawk.
  • Awk: add collating symbols and equivalence classes
May 14 2018, 2:41 AM · Frameworks, Framework: Syntax Highlighting
jpoelen updated the test plan for D12860: DoxygenLua: fix closing comment blocks.
May 14 2018, 1:55 AM · Frameworks
jpoelen added reviewers for D12860: DoxygenLua: fix closing comment blocks: Framework: Syntax Highlighting, dhaumann.
May 14 2018, 1:54 AM · Frameworks
jpoelen requested review of D12860: DoxygenLua: fix closing comment blocks.
May 14 2018, 1:53 AM · Frameworks

May 13 2018

jpoelen added a comment to D12689: Lua: updated for Lua5.3.

There is indeed a problem with Kate, but it works with KSyntaxHighlighting. I will look in what part of doxygenlua.xml the problem is.

May 13 2018, 11:18 PM · Frameworks, Framework: Syntax Highlighting
jpoelen added reviewers for D12854: Awk: fix regex in a function and update syntax for gawk: Framework: Syntax Highlighting, dhaumann.
May 13 2018, 10:32 PM · Frameworks, Framework: Syntax Highlighting
jpoelen requested review of D12854: Awk: fix regex in a function and update syntax for gawk.
May 13 2018, 10:31 PM · Frameworks, Framework: Syntax Highlighting

May 4 2018

jpoelen requested review of D12689: Lua: updated for Lua5.3.
May 4 2018, 12:06 AM · Frameworks, Framework: Syntax Highlighting

Apr 28 2018

jpoelen requested review of D12569: Pony: fix identifier and keyword.
Apr 28 2018, 1:11 AM · Frameworks, Framework: Syntax Highlighting

Apr 25 2018

jpoelen added a comment to D11470: SQL: various improvements and fix if/case/loop/end detection with SQL (Oracle).

The page on Phabricator is much better than before. My problem was about creating a branch without the -t option which requires me to specify a commit/branch to do the diff.

Apr 25 2018, 10:18 PM · Kate, Frameworks

Apr 23 2018

jpoelen updated the diff for D11470: SQL: various improvements and fix if/case/loop/end detection with SQL (Oracle).

I am completely lost with arc diff. The command adds files that I did not normally modify in this branch and specifiying a reference commit does not seem to work.

Apr 23 2018, 1:35 AM · Kate, Frameworks
jpoelen updated the diff for D11470: SQL: various improvements and fix if/case/loop/end detection with SQL (Oracle).
  • SQL: various improvements and fix if/case/loop/end detection with SQL (Oracle)
  • add sql tests
  • update kateversion to 5.0 and allows multiple spaces for "end if", "end case" and "end loop"
  • autotests/input/highlight.sh.syntax and autotests/input/highlight.sh are restored
Apr 23 2018, 1:11 AM · Kate, Frameworks
jpoelen updated the diff for D11470: SQL: various improvements and fix if/case/loop/end detection with SQL (Oracle).
  • diff with the proper branch
Apr 23 2018, 12:57 AM · Kate, Frameworks
jpoelen updated the diff for D11470: SQL: various improvements and fix if/case/loop/end detection with SQL (Oracle).
  • autotests/input/highlight.sh.syntax and autotests/input/highlight.sh are restored
Apr 23 2018, 12:37 AM · Kate, Frameworks
jpoelen updated the diff for D11470: SQL: various improvements and fix if/case/loop/end detection with SQL (Oracle).
  • SQL: various improvements and fix if/case/loop/end detection with SQL (Oracle)
  • add sql tests
  • update kateversion to 5.0 and allows multiple spaces for "end if", "end case" and "end loop"
Apr 23 2018, 12:28 AM · Kate, Frameworks

Mar 24 2018

jpoelen updated the diff for D10621: Highlighting Indexer: list of suggestions.

New suggestions:

  • Regex "^xyz\b" -> WordDetect with column=0
  • Regex "^xyz" with xyz a string of more than 2 characters -> StringDetext with column=0
Mar 24 2018, 10:54 PM · Kate, Framework: Syntax Highlighting, Frameworks

Mar 18 2018

jpoelen updated the diff for D10621: Highlighting Indexer: list of suggestions.

More suggestions and fixes some false positives.

Mar 18 2018, 11:20 PM · Kate, Framework: Syntax Highlighting, Frameworks
jpoelen added a comment to D11470: SQL: various improvements and fix if/case/loop/end detection with SQL (Oracle).

There is a bug on which I fell while completing the tests: the output is not stable.

Mar 18 2018, 10:52 PM · Kate, Frameworks
jpoelen updated the diff for D11470: SQL: various improvements and fix if/case/loop/end detection with SQL (Oracle).
Mar 18 2018, 10:33 PM · Kate, Frameworks
jpoelen requested review of D11470: SQL: various improvements and fix if/case/loop/end detection with SQL (Oracle).
Mar 18 2018, 10:27 PM · Kate, Frameworks

Mar 17 2018

jpoelen added a comment to D10621: Highlighting Indexer: list of suggestions.

I just tried with a format containing 5000 <RegExpr attribute="Keyword" context="\#stay" String="\baa\b"/> rules. This gives 2000 to 6000 more allocation than with WordDetect. Same for StringDetect vs Detect2Chars.

Mar 17 2018, 9:53 PM · Kate, Framework: Syntax Highlighting, Frameworks

Mar 13 2018

jpoelen added a comment to D10621: Highlighting Indexer: list of suggestions.

I've already planned to fix all the suggestions, but I lost a lot of time updating the sql*.xml files and came across a very strange bug related to QRegularExpression by adding some tests. At the moment, I do not know if it's my tool to test, my version of Qt that is old or a real bug. Like last week my hard drive is dead, I took the opportunity to have a more recent configuration. I will make a few patches this weekend when I finished setting my new environment.

Mar 13 2018, 2:20 AM · Kate, Framework: Syntax Highlighting, Frameworks

Feb 19 2018

jpoelen added a comment to D10646: Support case-insensitive WordDetect.

It seems that KTextEditor does not have the problem because KateHlWordDetect is based on KateHlStringDetect which uses the inSensitive parameter.

Feb 19 2018, 11:53 PM · Frameworks

Feb 18 2018

jpoelen requested review of D10646: Support case-insensitive WordDetect.
Feb 18 2018, 9:20 PM · Frameworks
jpoelen added a project to D10621: Highlighting Indexer: list of suggestions: Framework: Syntax Highlighting.
Feb 18 2018, 5:04 AM · Kate, Framework: Syntax Highlighting, Frameworks
jpoelen requested review of D10621: Highlighting Indexer: list of suggestions.
Feb 18 2018, 5:00 AM · Kate, Framework: Syntax Highlighting, Frameworks

Aug 15 2017

jpoelen updated the diff for D7297: Add Pony highlighting.

Pony: Support for attributes and best behavior for function definitions. Add license and removed autotests/foldingtest.pony

Aug 15 2017, 3:27 PM · Frameworks, Framework: Syntax Highlighting
jpoelen updated the diff for D7297: Add Pony highlighting.
Aug 15 2017, 3:23 PM · Frameworks, Framework: Syntax Highlighting

Aug 14 2017

jpoelen added a reviewer for D7297: Add Pony highlighting: Framework: Syntax Highlighting.
Aug 14 2017, 12:03 AM · Frameworks, Framework: Syntax Highlighting
jpoelen abandoned D6288: isocpp.xml: replace P printf-like format with p.

This commit is already merged.

Aug 14 2017, 12:01 AM · Frameworks

Aug 13 2017

jpoelen created D7297: Add Pony highlighting.
Aug 13 2017, 10:18 PM · Frameworks, Framework: Syntax Highlighting

Jun 21 2017

jpoelen added reviewers for D6328: add unit test for isocpp: dhaumann, Framework: Syntax Highlighting.
Jun 21 2017, 11:05 PM · Framework: Syntax Highlighting
jpoelen created D6328: add unit test for isocpp.
Jun 21 2017, 10:50 PM · Framework: Syntax Highlighting

Jun 19 2017

jpoelen created D6288: isocpp.xml: replace P printf-like format with p.
Jun 19 2017, 10:39 PM · Frameworks

Jun 12 2017

jpoelen updated the diff for D6128: Bug 360656 - CMake: OR/AND not highlighted after expr in ().
  • cmake.xml: fallthroughContext instead of using a Regexp that matches any char and increase version
Jun 12 2017, 11:13 PM · Frameworks