Feed Advanced Search

Sat, Jul 20

nibags committed R216:1766185fe580: TypeScript: fix keywords in conditional expressions (authored by nibags).
TypeScript: fix keywords in conditional expressions
Sat, Jul 20, 8:15 PM
nibags closed D22567: TypeScript: fix keywords in conditional expressions.
Sat, Jul 20, 8:15 PM · Frameworks, Kate
nibags closed D22568: Fix generator and test paths of CMake.
Sat, Jul 20, 8:14 PM · Frameworks, Kate
nibags committed R216:0b7e23a81a94: Fix generator and test paths of CMake (authored by nibags).
Fix generator and test paths of CMake
Sat, Jul 20, 8:14 PM

Fri, Jul 19

nibags requested review of D22568: Fix generator and test paths of CMake.
Fri, Jul 19, 7:41 PM · Frameworks, Kate
nibags requested review of D22567: TypeScript: fix keywords in conditional expressions.
Fri, Jul 19, 7:37 PM · Frameworks, Kate

Sat, Jul 6

nibags moved T9775: Integrate Fortran Free/Fixed from Backlog to Done on the Framework: Syntax Highlighting board.

Done in: c579929d8667 and 9c5875af2713

Sat, Jul 6, 7:36 AM · Framework: Syntax Highlighting
nibags added a comment to D21713: Fortran: implement free & fixed formats.

The files are re-licensed to MIT at: 9c5875af2713

Sat, Jul 6, 7:27 AM · Frameworks, Kate
nibags added a comment to R216:9c5875af2713: Fortran: relicense to MIT.

See:
https://mail.kde.org/pipermail/kwrite-devel/2019-July/004714.html
https://mail.kde.org/pipermail/kwrite-devel/2019-July/004715.html

Sat, Jul 6, 7:26 AM
nibags committed R216:9c5875af2713: Fortran: relicense to MIT (authored by nibags).
Fortran: relicense to MIT
Sat, Jul 6, 7:22 AM
nibags committed R216:fdd4d8defb11: Improve the Fortran fixed format syntax highlighting (authored by nononux).
Improve the Fortran fixed format syntax highlighting
Sat, Jul 6, 6:48 AM
nibags closed D22253: Improve the Fortran fixed format syntax highlighting.
Sat, Jul 6, 6:44 AM · Frameworks, Kate
nibags accepted D22253: Improve the Fortran fixed format syntax highlighting.

That is complicated to do, we would have to make rules for all the columns before 72 and for all the possible matchings, which is a lot of work and would make the code difficult to maintain.
I think a better solution is to add the functionality to the highlighting engine, for example, allowing a rule to be forced in a column, so that it can be applied above of any context. It can be something like this:

<RegExpr attribute="Comment" context="comment" String="." column="72" forceColumn="true" />

Another option is to allow having a set of rules that are applied above of the rest of the syntax highlighting; something like "injecting" rules. Such a feature could also be used in the PHP highlighter, instead of the generator script. For example:

<InjectRules>
    <RegExpr attribute="Comment" context="comment" String="." column="72" />
</InjectRules>
Sat, Jul 6, 6:30 AM · Frameworks, Kate

Thu, Jul 4

nibags added a comment to D22253: Improve the Fortran fixed format syntax highlighting.

Now I checked the patch well and I want to add some final recommendations before merging.
I think it's okay.

Thu, Jul 4, 8:16 AM · Frameworks, Kate
nibags added inline comments to D21713: Fortran: implement free & fixed formats.
Thu, Jul 4, 5:30 AM · Frameworks, Kate

Wed, Jul 3

nibags added a comment to D21713: Fortran: implement free & fixed formats.

Franchin Matteo & Janus Weil responded and agree to the MIT license.

Wed, Jul 3, 9:33 PM · Frameworks, Kate
nibags added a comment to D22253: Improve the Fortran fixed format syntax highlighting.

Only a small detail needs to be added. You also have to increase the version of the file.

Wed, Jul 3, 9:18 PM · Frameworks, Kate
nibags added a comment to D21713: Fortran: implement free & fixed formats.

Is there any progress with the licensing?
Otherwise I assume LGPL would be good enough, if a change isn't possible.

Wed, Jul 3, 3:30 AM · Frameworks, Kate

Jun 23 2019

nibags committed R216:6924eab39840: AppArmor: update syntax (authored by nibags).
AppArmor: update syntax
Jun 23 2019, 10:59 AM
nibags closed D21960: AppArmor: update syntax.
Jun 23 2019, 10:58 AM · Frameworks, Kate

Jun 21 2019

nibags requested review of D21960: AppArmor: update syntax.
Jun 21 2019, 12:06 PM · Frameworks, Kate

Jun 15 2019

nibags committed R39:0c5279a661ce: KateModeMenuList: move to QListView (authored by nibags).
KateModeMenuList: move to QListView
Jun 15 2019, 9:39 AM
nibags closed D21712: KateModeMenuList: move to QListView.
Jun 15 2019, 9:20 AM · Frameworks, Kate
nibags committed R216:c91c2554215d: Julia: update syntax and add constants keywords (authored by nibags).
Julia: update syntax and add constants keywords
Jun 15 2019, 9:14 AM
nibags closed D21711: Julia: update syntax and add constants keywords.
Jun 15 2019, 9:14 AM · Frameworks, Kate

Jun 12 2019

nibags updated the diff for D21712: KateModeMenuList: move to QListView.
  • Update tooltip of search bar
Jun 12 2019, 7:03 AM · Frameworks, Kate

Jun 11 2019

nibags updated the diff for D21712: KateModeMenuList: move to QListView.
  • Correct code style

Remove this-> and return at the end of void functions.

Jun 11 2019, 6:40 AM · Frameworks, Kate

Jun 10 2019

nibags updated the summary of D21713: Fortran: implement free & fixed formats.
Jun 10 2019, 9:00 AM · Frameworks, Kate
nibags requested review of D21713: Fortran: implement free & fixed formats.
Jun 10 2019, 8:58 AM · Frameworks, Kate
nibags added a comment to D20958: New menu of syntax highlighting in the status bar.

I changed QListWidget by QListView in D21712

Jun 10 2019, 8:08 AM · Frameworks, Kate
nibags updated the summary of D21712: KateModeMenuList: move to QListView.
Jun 10 2019, 8:04 AM · Frameworks, Kate
nibags requested review of D21712: KateModeMenuList: move to QListView.
Jun 10 2019, 8:03 AM · Frameworks, Kate
nibags requested review of D21711: Julia: update syntax and add constants keywords.
Jun 10 2019, 7:51 AM · Frameworks, Kate

May 31 2019

nibags committed R216:28b11e39fba0: YAML: only comments after spaces and other improvements/fixes (authored by nibags).
YAML: only comments after spaces and other improvements/fixes
May 31 2019, 6:58 PM
nibags closed D21411: YAML: only comments after spaces and other improvements/fixes.
May 31 2019, 6:58 PM · Frameworks, Kate
nibags added a comment to D21411: YAML: only comments after spaces and other improvements/fixes.

Could one adapt the theme and remove the color later?

May 31 2019, 11:37 AM · Frameworks, Kate
nibags added a comment to D21411: YAML: only comments after spaces and other improvements/fixes.

Btw., would it be possible to remove the hardcoded color here: <itemData name="Alert" defStyleNum="dsAlert" backgroundColor="#EF9A9A" />

May 31 2019, 11:24 AM · Frameworks, Kate
nibags updated the summary of D21411: YAML: only comments after spaces and other improvements/fixes.
May 31 2019, 11:08 AM · Frameworks, Kate
nibags updated the diff for D21411: YAML: only comments after spaces and other improvements/fixes.
  • Some fixes in attributes and update test file
May 31 2019, 11:07 AM · Frameworks, Kate

May 30 2019

nibags committed R216:4ec759613433: Markdown: use includeAttrib in code blocks (authored by nibags).
Markdown: use includeAttrib in code blocks
May 30 2019, 10:12 AM
nibags closed D21410: Markdown: use includeAttrib in code blocks.
May 30 2019, 10:12 AM · Frameworks, Kate

May 25 2019

nibags added reviewers for D21411: YAML: only comments after spaces and other improvements/fixes: dhaumann, cullmann, Framework: Syntax Highlighting.
May 25 2019, 8:20 PM · Frameworks, Kate
nibags requested review of D21411: YAML: only comments after spaces and other improvements/fixes.
May 25 2019, 8:17 PM · Frameworks, Kate
nibags added reviewers for D21410: Markdown: use includeAttrib in code blocks: dhaumann, cullmann, Framework: Syntax Highlighting.
May 25 2019, 8:13 PM · Frameworks, Kate
nibags requested review of D21410: Markdown: use includeAttrib in code blocks.
May 25 2019, 8:10 PM · Frameworks, Kate

May 22 2019

nibags committed R39:b2064042daa1: Fix: don't reset Highlight when saving some files (authored by nibags).
Fix: don't reset Highlight when saving some files
May 22 2019, 11:32 AM
nibags closed D21331: Fix: don't reset Highlight when saving some files.
May 22 2019, 11:25 AM · Frameworks, Kate
nibags requested review of D21331: Fix: don't reset Highlight when saving some files.
May 22 2019, 9:02 AM · Frameworks, Kate

May 21 2019

nibags added a comment to D20959: Allow to change the Mode, after changing the Highlighting.

errata: the setDontChangeHlOnSave() function has nothing to do here.
more time I upload a patch.

May 21 2019, 10:50 PM · Frameworks, Kate
nibags added a comment to D20959: Allow to change the Mode, after changing the Highlighting.

The function setDontChangeHlOnSave() uses the m_hlSetByUser variable to avoid resetting the syntax highlighting, which I removed in updateFileType().
I could use another binary for this.

May 21 2019, 9:07 PM · Frameworks, Kate

May 19 2019

nibags committed R216:71446d3e9e5e: Remove .conf extension from "INI Files" hl, to determine the highlighter using… (authored by nibags).
Remove .conf extension from "INI Files" hl, to determine the highlighter using…
May 19 2019, 11:48 AM
nibags closed D21288: Remove .conf extension from "INI Files" hl, to determine the highlighter using MIME type.
May 19 2019, 11:48 AM · Frameworks, Kate
nibags committed R216:4cf3a7e9825d: Perl: fix the // operator (authored by nibags).
Perl: fix the // operator
May 19 2019, 11:43 AM
nibags closed D21286: Perl: fix the // operator.
May 19 2019, 11:41 AM · Frameworks, Kate
nibags requested review of D21288: Remove .conf extension from "INI Files" hl, to determine the highlighter using MIME type.
May 19 2019, 11:35 AM · Frameworks, Kate
nibags requested review of D21286: Perl: fix the // operator.
May 19 2019, 9:48 AM · Frameworks, Kate

May 11 2019

nibags committed R39:1d9fc111fc78: New menu of syntax highlighting in the status bar (authored by nibags).
New menu of syntax highlighting in the status bar
May 11 2019, 8:33 PM
nibags closed D20958: New menu of syntax highlighting in the status bar.
May 11 2019, 8:15 PM · Frameworks, Kate
nibags added a comment to D20958: New menu of syntax highlighting in the status bar.

Now it's OK

May 11 2019, 8:14 PM · Frameworks, Kate
nibags updated the diff for D20958: New menu of syntax highlighting in the status bar.
  • Add delimiters « »
May 11 2019, 1:21 PM · Frameworks, Kate

May 10 2019

nibags updated the diff for D20958: New menu of syntax highlighting in the status bar.
  • Fixes the menu alignment of the previous update
May 10 2019, 8:36 AM · Frameworks, Kate

May 9 2019

nibags updated the diff for D20958: New menu of syntax highlighting in the status bar.

Some fixes for locations:

  • Before, the word wrap was only applied in spaces and, in languages such as German, there are large words that pass under the scroll bar. This is corrected.
  • Improves the alignment of the menu with respect to the trigger button in languages with Right-to-left layouts, such as Arabic or Hebrew. In those cases the menu is aligned to the left of the button (the idea is that the menu is aligned towards the center of the window, since it's shown on the edge of the window).
May 9 2019, 8:06 PM · Frameworks, Kate

May 7 2019

nibags added a comment to D20958: New menu of syntax highlighting in the status bar.

I'm going to move it to QListView (or QTreeView) in a future diff, I have checked and it isn't complicated to do.

May 7 2019, 11:31 PM · Frameworks, Kate

May 5 2019

nibags updated the diff for D20958: New menu of syntax highlighting in the status bar.
  • Allow to select an item with a single click, regardless of the configuration of the system.
May 5 2019, 9:10 PM · Frameworks, Kate

May 4 2019

nibags added a comment to D20958: New menu of syntax highlighting in the status bar.

Can you make this a QListView? I once heard the QListWidget will be deprecated in Qt6, rule of thumb is: always use Q*View instead of Q*Widget, since this then will also work in QML.

May 4 2019, 5:16 PM · Frameworks, Kate
nibags updated the diff for D20958: New menu of syntax highlighting in the status bar.
    • Update:
  • Select the search text when showing the menu.
  • Also use Shift, Alt or Meta + Return to select an item without hiding the menu.
  • Fix style in signals/slots.
  • Use constant variable for icon size.
  • Use static_cast instead of dynamic_cast.
  • Always use brackets in if/else conditions.
  • Decrease unnecessary multiline comments.
  • Update base.
May 4 2019, 5:07 PM · Frameworks, Kate

May 3 2019

nibags committed R39:0a6ea0624228: Allow to change the Mode, after changing the Highlighting (authored by nibags).
Allow to change the Mode, after changing the Highlighting
May 3 2019, 12:04 PM
nibags closed D20959: Allow to change the Mode, after changing the Highlighting.
May 3 2019, 12:04 PM · Frameworks, Kate
nibags added a comment to D20958: New menu of syntax highlighting in the status bar.

Thanks for the comments, in a while I will update the diff with the suggestions/corrections.

May 3 2019, 11:46 AM · Frameworks, Kate

May 2 2019

nibags requested review of D20959: Allow to change the Mode, after changing the Highlighting.
May 2 2019, 11:19 AM · Frameworks, Kate
nibags added reviewers for D20958: New menu of syntax highlighting in the status bar: KTextEditor, Kate.
May 2 2019, 11:13 AM · Frameworks, Kate
nibags requested review of D20958: New menu of syntax highlighting in the status bar.
May 2 2019, 11:07 AM · Frameworks, Kate

Apr 6 2019

nibags committed R216:e3a9359decea: Add syntax definition for Elm language to syntax-highlighting (authored by nibags).
Add syntax definition for Elm language to syntax-highlighting
Apr 6 2019, 6:06 PM
nibags closed D19438: Add syntax definition for Elm language to syntax-highlighting.
Apr 6 2019, 5:59 PM · Frameworks, Kate
nibags updated the diff for D19438: Add syntax definition for Elm language to syntax-highlighting.
  • Ok! Adding autotest references
Apr 6 2019, 5:58 PM · Frameworks, Kate

Apr 5 2019

nibags added reviewers for D20233: Add syntax highlighting for fish shell: Framework: Syntax Highlighting, dhaumann, cullmann.
Apr 5 2019, 8:24 PM · Frameworks, Kate, Framework: Syntax Highlighting
nibags added reviewers for D19438: Add syntax definition for Elm language to syntax-highlighting: Framework: Syntax Highlighting, dhaumann, cullmann.
Apr 5 2019, 8:21 PM · Frameworks, Kate
nibags added a comment to D19438: Add syntax definition for Elm language to syntax-highlighting.
  • Running make test, after adding a new file to autotests/input, will throw an error in "testhighlighter_test", "htmlhighlighter_test" and "folding_test", since references haven't been updated. It's normal to show you that error.
  • You have to execute the autotest/update-reference-data.sh script to update the references (new files will be copied to folding, html & reference). When running again make test everything will work fine.
Apr 5 2019, 8:20 PM · Frameworks, Kate
nibags updated the diff for D20221: AppArmor: don't highlight variable assignments and alias rules within profiles.
  • Don't highlight as Error the "alias" keyword within rules

Better not to highlight anything in rules.

Apr 5 2019, 8:19 AM · Frameworks, Kate

Apr 3 2019

nibags updated the diff for D20221: AppArmor: don't highlight variable assignments and alias rules within profiles.
  • Update tests
Apr 3 2019, 9:55 PM · Frameworks, Kate
nibags updated the diff for D20221: AppArmor: don't highlight variable assignments and alias rules within profiles.
  • Apply changes in apparmor.xml, remove selinux-*.xml changes
Apr 3 2019, 9:29 PM · Frameworks, Kate
nibags committed R216:508be5417e67: AppArmor & SELinux: remove one indentation in XML files (authored by nibags).
AppArmor & SELinux: remove one indentation in XML files
Apr 3 2019, 8:57 PM
nibags closed D20220: AppArmor & SELinux: remove one indentation in XML files.
Apr 3 2019, 8:57 PM · Frameworks, Kate
nibags updated the diff for D20221: AppArmor: don't highlight variable assignments and alias rules within profiles.
  • Fix some indentations
  • Remove selinux-*.xml changes
Apr 3 2019, 8:52 PM · Frameworks, Kate
nibags updated the diff for D20221: AppArmor: don't highlight variable assignments and alias rules within profiles.
  • Remove "alias" in the "_end_rule" context and add some comments
Apr 3 2019, 8:42 PM · Frameworks, Kate
nibags updated the diff for D20220: AppArmor & SELinux: remove one indentation in XML files.
  • Fix some indentations
Apr 3 2019, 8:33 PM · Frameworks, Kate
nibags added a comment to D19876: Fix: apply correctly the text colors of the chosen scheme.

Sorry, I committed this diff, but it hasn't been fully accepted. Although I made the changes that mwolff requested. If there is a problem, I can undo the commit or update it....

Apr 3 2019, 7:40 AM · Frameworks, Kate
nibags committed R39:c922bc8352ac: Fix: apply correctly the text colors of the chosen scheme (authored by nibags).
Fix: apply correctly the text colors of the chosen scheme
Apr 3 2019, 7:22 AM
nibags closed D19876: Fix: apply correctly the text colors of the chosen scheme.
Apr 3 2019, 7:22 AM · Frameworks, Kate
nibags added a dependent revision for D20220: AppArmor & SELinux: remove one indentation in XML files: D20221: AppArmor: don't highlight variable assignments and alias rules within profiles.
Apr 3 2019, 6:21 AM · Frameworks, Kate
nibags added a dependency for D20221: AppArmor: don't highlight variable assignments and alias rules within profiles: D20220: AppArmor & SELinux: remove one indentation in XML files.
Apr 3 2019, 6:21 AM · Frameworks, Kate
nibags requested review of D20221: AppArmor: don't highlight variable assignments and alias rules within profiles.
Apr 3 2019, 6:15 AM · Frameworks, Kate
nibags requested review of D20220: AppArmor & SELinux: remove one indentation in XML files.
Apr 3 2019, 6:09 AM · Frameworks, Kate

Apr 2 2019

nibags added a comment to D19876: Fix: apply correctly the text colors of the chosen scheme.

I have tested this a lot and it works well so far. I don't know if you have any disagreement with the last update (for example, using setTheme() with an empty theme, although I haven't seen this cause any problems)...

Apr 2 2019, 6:32 AM · Frameworks, Kate
nibags committed R216:3c5f212c90ef: Doxygen: don't use black color in tags (authored by nibags).
Doxygen: don't use black color in tags
Apr 2 2019, 6:13 AM
nibags closed D20195: Doxygen: don't use black color in tags.
Apr 2 2019, 6:13 AM · Frameworks, Kate
nibags committed R216:b518dcc6486a: Allow line end context switches in empty lines (authored by nibags).
Allow line end context switches in empty lines
Apr 2 2019, 6:13 AM
nibags requested review of D20195: Doxygen: don't use black color in tags.
Apr 2 2019, 6:07 AM · Frameworks, Kate
nibags closed D20148: Allow line end context switches in empty lines.
Apr 2 2019, 5:21 AM · Frameworks, Kate
nibags updated the diff for D20148: Allow line end context switches in empty lines.
  • Loop proposal
Apr 2 2019, 4:21 AM · Frameworks, Kate