Feed Advanced Search

Sat, Apr 6

nibags committed R216:e3a9359decea: Add syntax definition for Elm language to syntax-highlighting (authored by nibags).
Add syntax definition for Elm language to syntax-highlighting
Sat, Apr 6, 6:06 PM
nibags closed D19438: Add syntax definition for Elm language to syntax-highlighting.
Sat, Apr 6, 5:59 PM · Frameworks, Kate
nibags updated the diff for D19438: Add syntax definition for Elm language to syntax-highlighting.
  • Ok! Adding autotest references
Sat, Apr 6, 5:58 PM · Frameworks, Kate

Fri, Apr 5

nibags added reviewers for D20233: Add syntax highlighting for fish shell: Framework: Syntax Highlighting, dhaumann, cullmann.
Fri, Apr 5, 8:24 PM · Frameworks, Kate, Framework: Syntax Highlighting
nibags added reviewers for D19438: Add syntax definition for Elm language to syntax-highlighting: Framework: Syntax Highlighting, dhaumann, cullmann.
Fri, Apr 5, 8:21 PM · Frameworks, Kate
nibags added a comment to D19438: Add syntax definition for Elm language to syntax-highlighting.
  • Running make test, after adding a new file to autotests/input, will throw an error in "testhighlighter_test", "htmlhighlighter_test" and "folding_test", since references haven't been updated. It's normal to show you that error.
  • You have to execute the autotest/update-reference-data.sh script to update the references (new files will be copied to folding, html & reference). When running again make test everything will work fine.
Fri, Apr 5, 8:20 PM · Frameworks, Kate
nibags updated the diff for D20221: AppArmor: don't highlight variable assignments and alias rules within profiles.
  • Don't highlight as Error the "alias" keyword within rules

Better not to highlight anything in rules.

Fri, Apr 5, 8:19 AM · Frameworks, Kate

Wed, Apr 3

nibags updated the diff for D20221: AppArmor: don't highlight variable assignments and alias rules within profiles.
  • Update tests
Wed, Apr 3, 9:55 PM · Frameworks, Kate
nibags updated the diff for D20221: AppArmor: don't highlight variable assignments and alias rules within profiles.
  • Apply changes in apparmor.xml, remove selinux-*.xml changes
Wed, Apr 3, 9:29 PM · Frameworks, Kate
nibags committed R216:508be5417e67: AppArmor & SELinux: remove one indentation in XML files (authored by nibags).
AppArmor & SELinux: remove one indentation in XML files
Wed, Apr 3, 8:57 PM
nibags closed D20220: AppArmor & SELinux: remove one indentation in XML files.
Wed, Apr 3, 8:57 PM · Frameworks, Kate
nibags updated the diff for D20221: AppArmor: don't highlight variable assignments and alias rules within profiles.
  • Fix some indentations
  • Remove selinux-*.xml changes
Wed, Apr 3, 8:52 PM · Frameworks, Kate
nibags updated the diff for D20221: AppArmor: don't highlight variable assignments and alias rules within profiles.
  • Remove "alias" in the "_end_rule" context and add some comments
Wed, Apr 3, 8:42 PM · Frameworks, Kate
nibags updated the diff for D20220: AppArmor & SELinux: remove one indentation in XML files.
  • Fix some indentations
Wed, Apr 3, 8:33 PM · Frameworks, Kate
nibags added a comment to D19876: Fix: apply correctly the text colors of the chosen scheme.

Sorry, I committed this diff, but it hasn't been fully accepted. Although I made the changes that mwolff requested. If there is a problem, I can undo the commit or update it....

Wed, Apr 3, 7:40 AM · Frameworks, Kate
nibags committed R39:c922bc8352ac: Fix: apply correctly the text colors of the chosen scheme (authored by nibags).
Fix: apply correctly the text colors of the chosen scheme
Wed, Apr 3, 7:22 AM
nibags closed D19876: Fix: apply correctly the text colors of the chosen scheme.
Wed, Apr 3, 7:22 AM · Frameworks, Kate
nibags added a dependent revision for D20220: AppArmor & SELinux: remove one indentation in XML files: D20221: AppArmor: don't highlight variable assignments and alias rules within profiles.
Wed, Apr 3, 6:21 AM · Frameworks, Kate
nibags added a dependency for D20221: AppArmor: don't highlight variable assignments and alias rules within profiles: D20220: AppArmor & SELinux: remove one indentation in XML files.
Wed, Apr 3, 6:21 AM · Frameworks, Kate
nibags requested review of D20221: AppArmor: don't highlight variable assignments and alias rules within profiles.
Wed, Apr 3, 6:15 AM · Frameworks, Kate
nibags requested review of D20220: AppArmor & SELinux: remove one indentation in XML files.
Wed, Apr 3, 6:09 AM · Frameworks, Kate

Tue, Apr 2

nibags added a comment to D19876: Fix: apply correctly the text colors of the chosen scheme.

I have tested this a lot and it works well so far. I don't know if you have any disagreement with the last update (for example, using setTheme() with an empty theme, although I haven't seen this cause any problems)...

Tue, Apr 2, 6:32 AM · Frameworks, Kate
nibags committed R216:3c5f212c90ef: Doxygen: don't use black color in tags (authored by nibags).
Doxygen: don't use black color in tags
Tue, Apr 2, 6:13 AM
nibags closed D20195: Doxygen: don't use black color in tags.
Tue, Apr 2, 6:13 AM · Frameworks, Kate
nibags committed R216:b518dcc6486a: Allow line end context switches in empty lines (authored by nibags).
Allow line end context switches in empty lines
Tue, Apr 2, 6:13 AM
nibags requested review of D20195: Doxygen: don't use black color in tags.
Tue, Apr 2, 6:07 AM · Frameworks, Kate
nibags closed D20148: Allow line end context switches in empty lines.
Tue, Apr 2, 5:21 AM · Frameworks, Kate
nibags updated the diff for D20148: Allow line end context switches in empty lines.
  • Loop proposal
Tue, Apr 2, 4:21 AM · Frameworks, Kate

Mon, Apr 1

nibags updated the summary of D20148: Allow line end context switches in empty lines.
Mon, Apr 1, 4:15 AM · Frameworks, Kate
nibags updated the diff for D20148: Allow line end context switches in empty lines.
  • Don't store bool in StateData
Mon, Apr 1, 4:11 AM · Frameworks, Kate

Sun, Mar 31

nibags added reviewers for D20148: Allow line end context switches in empty lines: Framework: Syntax Highlighting, cullmann, dhaumann, vkrause.
Sun, Mar 31, 7:46 PM · Frameworks, Kate
nibags requested review of D20148: Allow line end context switches in empty lines.
Sun, Mar 31, 7:42 PM · Frameworks, Kate

Thu, Mar 28

nibags updated the diff for D19876: Fix: apply correctly the text colors of the chosen scheme.
  • Fix attributes in "KDE" and "Vim (dark)" themes
Thu, Mar 28, 10:15 PM · Frameworks, Kate

Mar 25 2019

nibags updated the diff for D19876: Fix: apply correctly the text colors of the chosen scheme.
  • Use QStringLiteral
Mar 25 2019, 2:26 PM · Frameworks, Kate

Mar 24 2019

nibags updated the summary of D19876: Fix: apply correctly the text colors of the chosen scheme.
Mar 24 2019, 6:09 PM · Frameworks, Kate
nibags updated the diff for D19876: Fix: apply correctly the text colors of the chosen scheme.
  • Pass schema name as parameter
Mar 24 2019, 6:06 PM · Frameworks, Kate

Mar 23 2019

nibags updated the summary of D19999: Fix endRegion folding in rules with beginRegion+endRegion (use length=0).
Mar 23 2019, 2:39 PM · Frameworks, Kate
nibags added reviewers for D19999: Fix endRegion folding in rules with beginRegion+endRegion (use length=0): Framework: Syntax Highlighting, cullmann, dhaumann, vkrause.
Mar 23 2019, 2:24 PM · Frameworks, Kate
nibags requested review of D19999: Fix endRegion folding in rules with beginRegion+endRegion (use length=0).
Mar 23 2019, 2:22 PM · Frameworks, Kate
nibags updated the diff for D19876: Fix: apply correctly the text colors of the chosen scheme.
  • Add some comments
Mar 23 2019, 1:54 PM · Frameworks, Kate

Mar 20 2019

nibags updated the diff for D19876: Fix: apply correctly the text colors of the chosen scheme.
  • Fix theme names

Convert theme names from KTextEditor => KSyntaxHighlighting and avoid using invalid KSyntaxHighlighting::Theme objects.

Mar 20 2019, 10:53 AM · Frameworks, Kate

Mar 19 2019

nibags added reviewers for D19876: Fix: apply correctly the text colors of the chosen scheme: KTextEditor, Kate.
Mar 19 2019, 7:11 AM · Frameworks, Kate
nibags requested review of D19876: Fix: apply correctly the text colors of the chosen scheme.
Mar 19 2019, 7:04 AM · Frameworks, Kate

Mar 12 2019

nibags added a comment to D19438: Add syntax definition for Elm language to syntax-highlighting.

It isn't possible to compile, because the elm.xml file has multiple issues :(
The script "data/schema/validatehl.sh" serves to verify the XML files:

cd syntax-highlighting/data/schema/
./validatehl.sh ../syntax/elm.xml

Output:

../syntax/elm.xml:3: element language: Schemas validity error : Element 'language', attribute 'version': '1.0' is not a valid value of the atomic type 'xs:integer'.
../syntax/elm.xml:43: element WordDetect: Schemas validity error : Element 'WordDetect', attribute 'string': The attribute 'string' is not allowed.
../syntax/elm.xml:43: element WordDetect: Schemas validity error : Element 'WordDetect': The attribute 'String' is required but missing.
../syntax/elm.xml:84: element StringDetect: Schemas validity error : Element 'StringDetect', attribute 'char': The attribute 'char' is not allowed.
../syntax/elm.xml:84: element StringDetect: Schemas validity error : Element 'StringDetect': The attribute 'String' is required but missing.
../syntax/elm.xml:86: element context: Schemas validity error : Element 'context': The attribute 'lineEndContext' is required but missing.
../syntax/elm.xml:93: element context: Schemas validity error : Element 'context': The attribute 'lineEndContext' is required but missing.
../syntax/elm.xml:102: element context: Schemas validity error : Element 'context': The attribute 'lineEndContext' is required but missing.
../syntax/elm.xml:114: element itemDatas: Schemas validity error : Element 'itemDatas': This element is not expected. Expected is ( context ).
../syntax/elm.xml:4: element highlighting: Schemas validity error : Element 'highlighting': Missing child element(s). Expected is ( itemDatas ).
../syntax/elm.xml fails to validate

For example: </contexts> (line 133) must be placed before <itemDatas> and dsHexVal isn't a valid default style (use dsBaseN, look here). By solving it, maybe compile everything well.

Mar 12 2019, 9:58 AM · Frameworks, Kate

Mar 10 2019

nibags committed R216:1296052d48b3: Logcat: fix dsError color with underline="0" (authored by nibags).
Logcat: fix dsError color with underline="0"
Mar 10 2019, 9:13 AM
nibags closed D19461: Logcat: fix dsError color with underline="0".
Mar 10 2019, 9:13 AM · Frameworks, Kate
nibags added a comment to D19461: Logcat: fix dsError color with underline="0".

Yes, this corresponds to the bug you mention.
In the "Vim (dark)" scheme, bold="0" doesn't work either, since all the text is bold.

Mar 10 2019, 9:13 AM · Frameworks, Kate

Mar 8 2019

nibags updated the diff for D19461: Logcat: fix dsError color with underline="0".
  • Update styles
Mar 8 2019, 11:01 AM · Frameworks, Kate
nibags added a comment to D18673: Add symlinks for flatpak.

In D19324 the icons for code and code-oss were added, which also need symbolic links for Flatpak (com.visualstudio.code & com.visualstudio.code.oss)

Mar 8 2019, 8:03 AM · Frameworks

Mar 6 2019

nibags added a comment to D18673: Add symlinks for flatpak.

+1
Also missing the symlink for JDownloader (org.jdownloader.JDownloader.svg): https://flathub.org/apps/details/org.jdownloader.JDownloader

Mar 6 2019, 10:01 PM · Frameworks

Mar 5 2019

nibags added a comment to D19461: Logcat: fix dsError color with underline="0".

I want to check the colors of this highlighter before doing the commit

Mar 5 2019, 10:34 PM · Frameworks, Kate
nibags added a comment to D19438: Add syntax definition for Elm language to syntax-highlighting.

Use: cmake ./ && make to compile

Mar 5 2019, 7:12 AM · Frameworks, Kate
nibags added a comment to D19461: Logcat: fix dsError color with underline="0".

I still have problems with dsError + underline="0" :(
In "autotest/html" these aren't underlined, but when I open the file "test.logcat" with Kate, it's underlined.
I even tried creating a new Unix user, but the problem persists (I'm using KDE Frameworks 5.55.0).
Even removing the underlines in "Configure Kate -> Fonts & Colors", the problem persists.
Also clarify that the file "$HOME/.config/katesyntaxhighlightingrc" doesn't exist.

Mar 5 2019, 6:37 AM · Frameworks, Kate

Mar 4 2019

nibags added a comment to D19461: Logcat: fix dsError color with underline="0".

Not seem, from what I see it is a recent bug. I just checked it in KDE Frameworks 5.48.0 (Fedora 28) and it works correctly

Mar 4 2019, 7:36 AM · Frameworks, Kate
nibags updated the diff for D19461: Logcat: fix dsError color with underline="0".
  • Add tests
Mar 4 2019, 7:25 AM · Frameworks, Kate

Mar 2 2019

nibags requested review of D19461: Logcat: fix dsError color with underline="0".
Mar 2 2019, 6:42 AM · Frameworks, Kate

Feb 27 2019

nibags added a comment to D18951: HTML: highlight JSX, TypeScript & MustacheJS code in the <script> tag.

The MustacheJS highlight is modified in this diff: D19328

Feb 27 2019, 6:40 AM · Frameworks, Kate
nibags committed R216:de1ba2b6705c: MustacheJS: also highlight template files, fix syntax and improve support for… (authored by nibags).
MustacheJS: also highlight template files, fix syntax and improve support for…
Feb 27 2019, 6:38 AM
nibags closed D19328: MustacheJS: also highlight template files, fix syntax and improve support for Handlebars.
Feb 27 2019, 6:35 AM · Frameworks, Kate

Feb 26 2019

nibags requested review of D19328: MustacheJS: also highlight template files, fix syntax and improve support for Handlebars.
Feb 26 2019, 8:08 AM · Frameworks, Kate

Feb 23 2019

nibags requested review of D19249: Improve highlighting of TypeScript (and React) and add more tests for PHP.
Feb 23 2019, 11:15 AM · Frameworks, Kate

Feb 13 2019

nibags added a comment to D18951: HTML: highlight JSX, TypeScript & MustacheJS code in the <script> tag.

I can add more examples in "autotests/input/highlight.php", for all the cases of languages ​​included

Feb 13 2019, 9:38 PM · Frameworks, Kate

Feb 12 2019

nibags committed R216:81a415fa3d6e: CubeScript: fixes line continuation escape in strings (authored by nibags).
CubeScript: fixes line continuation escape in strings
Feb 12 2019, 9:47 PM
nibags closed D18948: CubeScript: fixes line continuation escape in strings.
Feb 12 2019, 9:47 PM · Frameworks, Kate
nibags updated the diff for D18948: CubeScript: fixes line continuation escape in strings.
  • Add unit test
Feb 12 2019, 9:18 PM · Frameworks, Kate
nibags accepted D18746: Avoid duplicate *-php.xml files in "data/CMakeLists.txt".

It's good, I think it's a better solution ;D

Feb 12 2019, 9:05 PM · Frameworks, Kate
nibags updated the summary of D18951: HTML: highlight JSX, TypeScript & MustacheJS code in the <script> tag.
Feb 12 2019, 11:48 AM · Frameworks, Kate
nibags requested review of D18951: HTML: highlight JSX, TypeScript & MustacheJS code in the <script> tag.
Feb 12 2019, 11:38 AM · Frameworks, Kate
nibags requested review of D18949: R Markdown: improve folding of blocks.
Feb 12 2019, 11:27 AM · Frameworks, Kate
nibags requested review of D18948: CubeScript: fixes line continuation escape in strings.
Feb 12 2019, 11:23 AM · Frameworks, Kate

Feb 5 2019

nibags requested review of D18746: Avoid duplicate *-php.xml files in "data/CMakeLists.txt".
Feb 5 2019, 9:08 AM · Frameworks, Kate

Jan 28 2019

nibags added a comment to D18516: Fix end of folding region in rules with lookAhead=true.

Some highlighters use endRegion+lookAhead to determine the end of a region when a new one starts, that is, they don't consider the text with endRegion+lookAhead as part of the fold region. This behavior was present before the implementation of KSyntaxHighlighting and, apparently, is no longer from the commit: c004f3f787b2

Jan 28 2019, 7:52 AM · Frameworks, Kate
nibags removed a reviewer for D18516: Fix end of folding region in rules with lookAhead=true: KTextEditor.
Jan 28 2019, 7:30 AM · Frameworks, Kate

Jan 27 2019

nibags added a comment to D18475: Add AsciiDoc support.

If you are only going to use the "admonition" keywords list for autocompletion, you could add them to the end of the context "section" or "start", keeping the attribute (Normal). I have done this in some highlight files

Jan 27 2019, 7:29 PM · Frameworks, Kate, Framework: Syntax Highlighting

Jan 26 2019

nibags added a comment to D18475: Add AsciiDoc support.

Hi!!
Please, also add a test file in: "autotests/input/". To generate the files in "folding", "html" and "reference" use make test and autotests/update-reference-data.sh.

Jan 26 2019, 3:44 AM · Frameworks, Kate, Framework: Syntax Highlighting

Jan 25 2019

nibags added reviewers for D18516: Fix end of folding region in rules with lookAhead=true: Framework: Syntax Highlighting, cullmann, dhaumann, KTextEditor.
Jan 25 2019, 10:07 AM · Frameworks, Kate
nibags requested review of D18516: Fix end of folding region in rules with lookAhead=true.
Jan 25 2019, 10:00 AM · Frameworks, Kate
nibags added reviewers for D18509: Fixed Bug Which Caused Infinite Loop While Highlighting Kconfig Files: Framework: Syntax Highlighting, cullmann, dhaumann.
Jan 25 2019, 7:46 AM · Frameworks, Kate
nibags added a comment to D18509: Fixed Bug Which Caused Infinite Loop While Highlighting Kconfig Files.

The bug is identical to D17891 !
Please, also put #pop!error in fallthroughContext="error", on lines 238 and 363.
And increase the file version

Jan 25 2019, 7:45 AM · Frameworks, Kate

Jan 16 2019

nibags committed R216:4c577562628e: Ruby: fix RegExp after ": " and fix/improve detection of HEREDOC (authored by nibags).
Ruby: fix RegExp after ": " and fix/improve detection of HEREDOC
Jan 16 2019, 9:46 AM
nibags closed D18174: Ruby: fix RegExp after ": " and fix/improve detection of HEREDOC.
Jan 16 2019, 9:07 AM · Frameworks, Kate
nibags updated the summary of D18174: Ruby: fix RegExp after ": " and fix/improve detection of HEREDOC.
Jan 16 2019, 9:04 AM · Frameworks, Kate
nibags updated the diff for D18174: Ruby: fix RegExp after ": " and fix/improve detection of HEREDOC.
  • Small correction in comment
Jan 16 2019, 8:59 AM · Frameworks, Kate

Jan 11 2019

nibags added reviewers for D18174: Ruby: fix RegExp after ": " and fix/improve detection of HEREDOC: Framework: Syntax Highlighting, dhaumann, cullmann.
Jan 11 2019, 7:42 AM · Frameworks, Kate
nibags requested review of D18174: Ruby: fix RegExp after ": " and fix/improve detection of HEREDOC.
Jan 11 2019, 7:33 AM · Frameworks, Kate

Jan 4 2019

nibags added reviewers for D17951: Haskell: Make = a special symbol: Framework: Syntax Highlighting, dhaumann, cullmann.
Jan 4 2019, 8:40 AM · Frameworks, Kate
nibags committed R216:e342c2ef8d15: WML: fix embedded Lua code & use new default styles (authored by nibags).
WML: fix embedded Lua code & use new default styles
Jan 4 2019, 8:31 AM
nibags closed D17957: WML: fix embedded Lua code & use new default styles.
Jan 4 2019, 8:31 AM · Frameworks, Kate
nibags requested review of D17957: WML: fix embedded Lua code & use new default styles.
Jan 4 2019, 5:28 AM · Frameworks, Kate

Jan 3 2019

nibags updated the summary of D17883: TypeScript & TS/JS React: improve types detection, fix float-points & other improvements/fixes.
Jan 3 2019, 7:53 PM · Frameworks, Kate
nibags updated the diff for D17883: TypeScript & TS/JS React: improve types detection, fix float-points & other improvements/fixes.
  • Small modification in comments
Jan 3 2019, 7:48 PM · Frameworks, Kate
nibags updated the diff for D17891: WML: fix infinite loop in contexts switch & only highlight tags with valid names.
  • Update test file
Jan 3 2019, 6:31 PM · Frameworks, Kate

Jan 2 2019

nibags updated the diff for D17891: WML: fix infinite loop in contexts switch & only highlight tags with valid names.

I asked in the thread of the Wesnoth forum, that appears in the wml.xml file (http://www.wesnoth.org/forum/viewtopic.php?f=21&t=13781), if the changes are OK and someone has suggested to me that the array indices (array[0]) aren't highlighted as tags, as well that I included it

Jan 2 2019, 7:47 AM · Frameworks, Kate

Dec 31 2018

nibags updated the diff for D17891: WML: fix infinite loop in contexts switch & only highlight tags with valid names.
  • Fix RegExp of tag name
Dec 31 2018, 9:20 PM · Frameworks, Kate
nibags requested review of D17891: WML: fix infinite loop in contexts switch & only highlight tags with valid names.
Dec 31 2018, 8:03 PM · Frameworks, Kate
nibags updated the summary of D17883: TypeScript & TS/JS React: improve types detection, fix float-points & other improvements/fixes.
Dec 31 2018, 8:04 AM · Frameworks, Kate
nibags requested review of D17883: TypeScript & TS/JS React: improve types detection, fix float-points & other improvements/fixes.
Dec 31 2018, 7:42 AM · Frameworks, Kate

Nov 24 2018

nibags committed R216:ec43942c85ac: Fix language load after including keywords from this language in another file (authored by nibags).
Fix language load after including keywords from this language in another file
Nov 24 2018, 7:09 AM
nibags closed D17085: Fix language load after including keywords from this language in another file.
Nov 24 2018, 6:28 AM · Frameworks, Kate
nibags updated the diff for D17092: Add syntax highlighting for TypeScript & TypeScript React.
  • typescript.xml & typescript-react.xml: add some comments and the operator "!" after objects

https://github.com/Microsoft/TypeScript/wiki/What's-new-in-TypeScript#non-null-assertion-operator

Nov 24 2018, 6:25 AM · Frameworks, Kate