Differential D19249

Improve highlighting of TypeScript (and React) and add more tests for PHP
ClosedPublic
Actions

Authored by nibags on Feb 23 2019, 11:15 AM.

Details

Reviewers

dhaumann
cullmann

Group Reviewers

Framework: Syntax Highlighting

Commits

R216:df1afdbedcbf: Improve highlighting of TypeScript (and React) and add more tests for PHP

Summary

Add more examples in the PHP test units, with the highlighting within code of
CSS, JavaScript, JavaScript React, TypeScript and MustacheJS (according to D18951).

The TypeScript highlighting is also updated.

Changes:

TypeScript:

Fixes keywords delimiters (remove: +-).
Add support to bigint (example: 123n).
Add "is" keyword (for type guards).
Don't highlight some keywords when they are objects.
Small improvements in the highlighting of types.
Don't highlight regular expressions after "]" and ")".

TypeScript React:

Don't highlight tags within declarations of types, variables, classes and interfaces.
Fix tags at the beginning of substitutions in templates.
Adapt to modifications of "typescript.xml".
Reorder part of the code.

JavaScript React:

Don't highlight tags within declarations of variables, classes and interfaces.
Fix tags at the beginning of substitutions in templates.
Reorder part of the code.

JavaScript:

Move highlighting of region markers to the "FindComments" context.
Fix: highlight comments after "<".

Also, examples have been added in the test files.

Diff Detail

Repository

R216 Syntax Highlighting

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

nibags created this revision.Feb 23 2019, 11:15 AM

Restricted Application added projects: Kate, Frameworks. · View Herald TranscriptFeb 23 2019, 11:15 AM

Restricted Application added subscribers: kde-frameworks-devel, kwrite-devel. · View Herald Transcript

nibags requested review of this revision.Feb 23 2019, 11:15 AM

Harbormaster completed remote builds in B8730: Diff 52372.Feb 23 2019, 11:15 AM

dhaumann accepted this revision.Feb 23 2019, 1:59 PM

This revision is now accepted and ready to land.Feb 23 2019, 1:59 PM

Closed by commit R216:df1afdbedcbf: Improve highlighting of TypeScript (and React) and add more tests for PHP (authored by nibags, committed by cullmann). · Explain WhyFeb 24 2019, 4:45 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			autotests/folding/highlight.js.fold (22 lines)
M			autotests/folding/highlight.php.fold (43 lines)
M			autotests/folding/test.js.fold (6 lines)
M			autotests/folding/test.jsx.fold (25 lines)
M			autotests/folding/test.ts.fold (70 lines)
M			autotests/folding/test.tsx.fold (29 lines)
M			autotests/html/highlight.php.html (43 lines)
M			autotests/html/test.jsx.html (21 lines)
M			autotests/html/test.ts.html (72 lines)
M			autotests/html/test.tsx.html (29 lines)
M			autotests/input/highlight.php (43 lines)
M			autotests/input/test.jsx (19 lines)
M			autotests/input/test.ts (70 lines)
M			autotests/input/test.tsx (25 lines)
M			autotests/reference/highlight.js.ref (2 lines)
M			autotests/reference/highlight.php.ref (43 lines)
M			autotests/reference/test.htm.ref (8 lines)
M			autotests/reference/test.js.ref (2 lines)
M			autotests/reference/test.jsx.ref (35 lines)
M			autotests/reference/test.qml.ref (2 lines)
M			autotests/reference/test.ts.ref (130 lines)
M			autotests/reference/test.tsx.ref (51 lines)
M			data/syntax/javascript-react.xml (120 lines)
M			data/syntax/javascript.xml (10 lines)
M			data/syntax/typescript-react.xml (148 lines)
M			data/syntax/typescript.xml (118 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	52372	a62af57		Feb 23 2019, 11:15 AM	★	★
Diff 2	52454	35793ff	R216:df1afdbedcbfbd976b58432071ceb2cd3aa7693b	Feb 24 2019, 4:47 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
2571656cdc60	d8eec39327cb	a62af5713549	Nibaldo González	Improve highlighting of TypeScript (and React) and add more tests for PHP (Show More…)	Feb 23 2019, 11:13 AM