Feed Advanced Search

Yesterday

hein accepted D22060: [Task Manager] Prefer PID match even when desktop entry doesn't match.
Mon, Jun 24, 8:57 AM · Plasma

Sun, Jun 23

hein requested review of D22053: [libtaskmanager] Track stacking order and window activation (on X11).
Sun, Jun 23, 4:44 PM · Plasma
hein added a comment to T11094: Improve discoverability of widget configuration.

This sounds good to me, although we'll need to handle some (literal) corner cases like having two panels at a right angle to each other without a sufficient gap to avoid the panel configurator UIs overlapping. And probably some similar space issue with "zll widgets visibly show their widget-specific options (remove, configure, rotate, resize, etc).".

Sun, Jun 23, 3:28 PM · VDG, Plasma

Sat, Jun 22

hein accepted D21983: [Kickoff/Dash] Show Calculator and Unit Converter runners.
Sat, Jun 22, 4:31 PM · Plasma
hein added a comment to D21983: [Kickoff/Dash] Show Calculator and Unit Converter runners.

You can do it for Dash, though -- check that isDash check where it already adds some runners to the Dash it doesn't add to App Menu.

Sat, Jun 22, 4:30 PM · Plasma
hein added a comment to D21983: [Kickoff/Dash] Show Calculator and Unit Converter runners.

Let's only do it for Kickoff and the Dash? The Kicker UI is really not made for arbitrary runners.

Sat, Jun 22, 4:24 PM · Plasma
hein added a comment to D22004: Increment iterator before any potential continue.

I'm not super happy with hardcoding directory separators and schemas, judicious use of QUrl::fromLocalFile or QUrl::fromUserInput would probably be better to norm behavior.

Sat, Jun 22, 4:21 PM · Plasma
hein accepted D22004: Increment iterator before any potential continue.
Sat, Jun 22, 3:48 PM · Plasma
hein accepted D21992: Provide a way for developers to easily set up plasma sessions for their development environment.
Sat, Jun 22, 2:35 PM · Plasma
hein accepted D21990: Don't propagate a title change if it didn't actually change.

Ironically quite similar to a DDoS vector on the Task Manager. Apps suck :)

Sat, Jun 22, 11:10 AM · Plasma
hein committed R119:548621d6c125: Merge branch 'Plasma/5.16' (authored by hein).
Merge branch 'Plasma/5.16'
Sat, Jun 22, 11:05 AM
hein committed R119:0628dab8f42b: Reject duplicate events with identical coordinates (authored by hein).
Reject duplicate events with identical coordinates
Sat, Jun 22, 11:05 AM
hein closed D21988: Reject duplicate events with identical coordinates.
Sat, Jun 22, 11:05 AM · Plasma
hein added a comment to D21978: RFC: Fix search not returning results in Kickoff when cursor is below tabbar.
In D21978#483972, @hein wrote:

That's wrong, sorry - I'm uploading a different patch that fixes the underlying cause.

Sat, Jun 22, 10:54 AM · Plasma
hein requested review of D21988: Reject duplicate events with identical coordinates.
Sat, Jun 22, 10:54 AM · Plasma
hein added a comment to D21978: RFC: Fix search not returning results in Kickoff when cursor is below tabbar.

That's wrong, sorry - I'm uploading a different patch that fixes the underlying cause.

Sat, Jun 22, 10:52 AM · Plasma

Fri, Jun 21

hein added a comment to D21083: [effects/presentwindows] Allow closing windows on middle-click.

As the Task Manager maintainer I agree with @mart's take -- it's strange to have this (and have this be popular) as an option in the Task Manager but not a UI that serves a similar purpose, and also gets invoked from the TM.

Fri, Jun 21, 4:49 PM · KWin
hein updated subscribers of D21829: Improved Touch support for Kickoff.

I'm in principle quite OK with this minus that other patch I need to be written first to move DragHelper out into the lib (see other comment). Pitch: If you do that, it'll make it much easier to make the other menus (and other things) act similarly later, with smaller patches there.

Fri, Jun 21, 4:43 PM · Plasma
hein added a comment to D21954: Handle Gimp 2.10.

Could this go to the stable branch?

Fri, Jun 21, 10:47 AM · Plasma
hein committed R120:7d0b17d15296: Merge branch 'Plasma/5.16' (authored by hein).
Merge branch 'Plasma/5.16'
Fri, Jun 21, 10:47 AM
hein committed R120:69adf0605419: Handle Gimp 2.10 (authored by hein).
Handle Gimp 2.10
Fri, Jun 21, 10:47 AM
hein added a comment to D21954: Handle Gimp 2.10.

Can we also pre-emptively add 2.12 as well? :)

Fri, Jun 21, 9:58 AM · Plasma
hein committed R120:96655354961d: Handle Gimp 2.10 (authored by hein).
Handle Gimp 2.10
Fri, Jun 21, 9:58 AM
hein closed D21954: Handle Gimp 2.10.
Fri, Jun 21, 9:58 AM · Plasma
hein requested review of D21954: Handle Gimp 2.10.
Fri, Jun 21, 9:49 AM · Plasma

Mon, Jun 17

hein accepted D21856: [Task manager] Use consistent menu items for "pin/unpin" actions.
Mon, Jun 17, 10:31 AM · Plasma

Sun, Jun 16

hein added a comment to T11054: Make Input Methods Just Work.

Currently on airports, will do from the Plasma sprint :)

Sun, Jun 16, 12:45 PM · Goal Setting 2019

Fri, Jun 14

hein accepted D21803: PanelView: align setting of masks with how it's done for dialogs/tooltips.

Thanks for restoring my sanity & faith in panels, this annoyed me for weeks :)

Fri, Jun 14, 6:19 PM · Plasma
hein added a comment to T11054: Make Input Methods Just Work.

The work Geon and I did in GSoC had an fcitc5 backend with plans to add a second one.

Fri, Jun 14, 1:07 PM · Goal Setting 2019

Thu, Jun 13

hein added a comment to T11094: Improve discoverability of widget configuration.

In the hybrid approach, we can also get more ambitious than a widget list: System Settings could totally have a minimap version of your entire system that shows the screens with panels and a little config icon on each element that brings up the respective master dialog. The part shown in SysSe can get a little more free form if it doesn't have to show every widget.

Thu, Jun 13, 9:43 PM · VDG, Plasma
hein added a comment to T11094: Improve discoverability of widget configuration.

I understand the motivation here, and it's worth entertaining as a thought experiment, but I think as-is it has problems.

Thu, Jun 13, 7:55 PM · VDG, Plasma

Wed, Jun 12

hein updated the diff for D20237: Port to new KWorkspace API.
  • Fix typo
  • Rebase
Wed, Jun 12, 4:02 PM · Plasma
hein updated the task description for T11054: Make Input Methods Just Work.
Wed, Jun 12, 9:25 AM · Goal Setting 2019

Tue, Jun 11

hein added a comment to T11054: Make Input Methods Just Work.

As the comment on Youtube points out the slides are not readable. Can you upload them somewhere and link here or in the video, so one can follow your talk better. I would also like to get an overview on current state on X11 in particular.

Tue, Jun 11, 2:35 PM · Goal Setting 2019
hein added a comment to T11054: Make Input Methods Just Work.

I submitted the same goal last year:

Tue, Jun 11, 11:03 AM · Goal Setting 2019

Mon, Jun 10

hein committed R857:e60c3fcb41ae: Update GStreamer binaries to 1.16.0 (authored by hein).
Update GStreamer binaries to 1.16.0
Mon, Jun 10, 10:40 AM

Thu, Jun 6

hein accepted D21627: [Task manager] Use Windows-style middle-click behaviors for entries and thumbnails.
Thu, Jun 6, 6:11 PM · Plasma

Wed, Jun 5

hein accepted D21614: [sddm-theme] Fix fontsize of virtual keyboard ToolButton.
Wed, Jun 5, 9:17 PM · Plasma

Mon, Jun 3

hein committed R917:9684413f3040: Remove my employment status. (authored by hein).
Remove my employment status.
Mon, Jun 3, 11:16 PM

Fri, May 31

hein accepted D19829: kicker: add option to make root level icons visible.

I'm still a bit grumpy about this and dragging my feet! My gut still says it's both option clutter and UI noise :-)

Fri, May 31, 5:51 PM · Plasma

Mon, May 27

hein added a comment to D21429: [Fonts KCM] Switch default UI font to Noto Sans Display.

I'm not sold on this. "Display" fonts typically have spacing and metrics optimized for large sizes and use cases like signage. The FAQ entry quoted in the task you linked talks about Noto Sans UI. I'd like some more solid documentation on how Display relates to this "UI" cut or something from upstream.

Mon, May 27, 5:35 PM · Plasma
hein added a comment to D21429: [Fonts KCM] Switch default UI font to Noto Sans Display.

Why?

Mon, May 27, 5:27 PM · Plasma

May 24 2019

hein committed R917:8a85d0e3b7c3: Add newly-elected members (authored by hein).
Add newly-elected members
May 24 2019, 7:48 AM

May 23 2019

hein added a comment to D21336: Get PaginateModel class ready for frameworks.

I wouldn't call this implementation ready for frameworks, though - it just resets all the time, which is very slow as it forces views to destroy and recreate delegates instead of just updating them. A better implementation would just (re)filter source rows corresponding to the current page. This could be done as a subclass of QSortFilterProxyModel or custom; KItemModels' KRearrangeColumnsProxyModel can serve as inspiration to some degree. As it stands I wouldn't actually use this if it was in the framework.

May 23 2019, 6:26 AM · Plasma
hein added a comment to D21358: Prevent the Yakuake Task from Showing up in the Task Bar.

It's not that easy I'm afraid.

May 23 2019, 6:12 AM · Yakuake

May 13 2019

hein added a comment to D21169: Add app icon for the Kirogi Drone control app.

I'd say it's up to the Breeze maintainers. From my end I'm very interested in the app having a Breeze-compatible icon, because I'd like it to integrate well with KDE's workspaces and other apps. Review by the Breeze community is very appreciated to help with that. Application code needs to ship the icon anyway though for systems that don't have the theme and can't be reasonably expected to provide every app icon, so it's not vital to be included with the theme.

May 13 2019, 5:02 PM · Frameworks
hein added a comment to D21169: Add app icon for the Kirogi Drone control app.

@trickyricky26 It's great! What do you think about adding the detailed SVG as 256 version?

May 13 2019, 2:14 PM · Frameworks

May 6 2019

hein added inline comments to D20265: Introduce libnotificationmanager.
May 6 2019, 11:46 AM · Plasma

May 5 2019

hein accepted D20863: Allow folder view elements to be be dropped using other Action than Copy.
May 5 2019, 4:17 PM · Plasma
hein added inline comments to D20265: Introduce libnotificationmanager.
May 5 2019, 9:55 AM · Plasma
hein added inline comments to D20265: Introduce libnotificationmanager.
May 5 2019, 9:54 AM · Plasma
hein added inline comments to D20265: Introduce libnotificationmanager.
May 5 2019, 9:51 AM · Plasma
hein added inline comments to D20265: Introduce libnotificationmanager.
May 5 2019, 9:49 AM · Plasma
hein added inline comments to D20265: Introduce libnotificationmanager.
May 5 2019, 9:18 AM · Plasma
hein added inline comments to D20265: Introduce libnotificationmanager.
May 5 2019, 8:52 AM · Plasma

Apr 30 2019

hein accepted D20851: [Pager] Improve label legibility.
Apr 30 2019, 5:28 AM · Plasma
hein added a comment to D20908: RFC: Redesign QML applet configuration windows.

Looks great to me. Subtle visual refreshs like this are very appreciated, especially when they improve consistency, too.

Apr 30 2019, 5:01 AM · Plasma

Apr 26 2019

hein accepted D20846: [Task Manager] Don't show redundant "Actions" header in context menu with nothing but actions in it.
Apr 26 2019, 11:29 PM · Plasma
hein accepted D20117: Remove forcing the initial dir to QDir::homePath().
Apr 26 2019, 3:19 PM

Apr 24 2019

hein accepted D20773: [Task Manager] Bring to current desktop with middle-click.
Apr 24 2019, 8:18 AM · Plasma

Apr 22 2019

hein accepted D20743: [Kicker] Modernize settings window.
Apr 22 2019, 6:39 PM · Plasma
hein accepted D20612: [Kickoff] Modernize settings window layout.

LGTM.

Apr 22 2019, 3:26 PM · Plasma

Apr 15 2019

hein added a comment to D20569: RFC: Use more compact OSD.

Personally I'm not a big fan. I think the square OSD has more character and visual flair. The change proposed here looks rather cramped and removes some identity from the system.

Apr 15 2019, 9:01 AM · Plasma
hein accepted D20469: Add DesktopEntry to notifyrc.
Apr 15 2019, 7:16 AM

Apr 14 2019

hein accepted D20494: Add DesktopEntry to notifyrc.
Apr 14 2019, 8:12 AM

Apr 10 2019

hein accepted D20428: separe mobile text selection to avoid recursive imports.

Works here now, thx!

Apr 10 2019, 11:29 AM · Frameworks

Apr 9 2019

hein committed R32:5e17ba4cd7a5: Fix build on Qt 5.13 branch (authored by hein).
Fix build on Qt 5.13 branch
Apr 9 2019, 10:43 PM
hein closed D20419: Fix build on Qt 5.13 branch.
Apr 9 2019, 10:43 PM · KDevelop
hein accepted D20420: [Folder View] use Math.floor() instead of Math.round().
Apr 9 2019, 9:56 PM · Plasma
hein committed R242:846741f851c6: Revert "use the right namespace" (authored by hein).
Revert "use the right namespace"
Apr 9 2019, 9:55 PM
hein added a reverting change for R242:067ec2eafcbe: use the right namespace: R242:846741f851c6: Revert "use the right namespace".
Apr 9 2019, 9:55 PM
hein added a reverting change for R242:c72ee78bbbc4: mov the mobile text actions in own import: R242:a280cccfde66: Revert "mov the mobile text actions in own import".
Apr 9 2019, 9:55 PM
hein committed R242:a280cccfde66: Revert "mov the mobile text actions in own import" (authored by hein).
Revert "mov the mobile text actions in own import"
Apr 9 2019, 9:55 PM
hein requested review of D20419: Fix build on Qt 5.13 branch.
Apr 9 2019, 9:38 PM · KDevelop
hein added a comment to D20407: [Folder View] Improve label crispness.

I think it would be safer to Math.floor() rather than Math.round().

Apr 9 2019, 9:15 PM · Plasma

Apr 8 2019

hein accepted D20370: [Folder View] Implement a user-configurable setting for label width.
Apr 8 2019, 3:50 PM · Plasma
hein accepted D20368: [Folder View] Use a more reasonable minimum cell width.
Apr 8 2019, 9:29 AM · Plasma

Apr 6 2019

hein committed R917:45b2366d352a: Update the member roster for the FiWG (authored by hein).
Update the member roster for the FiWG
Apr 6 2019, 2:54 AM

Apr 5 2019

hein updated the diff for D20237: Port to new KWorkspace API.

Fix refcounting

Apr 5 2019, 4:47 PM · Plasma
hein added a comment to D20237: Port to new KWorkspace API.

Personally I tend to prefer just readable, explicit code for simple cases.

Now the timing of my comment becomes awkward :/

Apr 5 2019, 4:44 PM · Plasma
hein accepted D19874: [Kickoff] Reduce the margins of KickoffItem, KickoffHighlight and use smallSpacing.

@hein what's your opinion on reducing the margins?

Apr 5 2019, 3:32 PM · Plasma

Apr 4 2019

hein added inline comments to D20237: Port to new KWorkspace API.
Apr 4 2019, 9:43 PM · Plasma
hein updated the diff for D20237: Port to new KWorkspace API.

Do some cleanups suggested by Kai.

Apr 4 2019, 9:41 PM · Plasma
hein added inline comments to D20237: Port to new KWorkspace API.
Apr 4 2019, 9:35 PM · Plasma
hein added inline comments to D20237: Port to new KWorkspace API.
Apr 4 2019, 9:24 PM · Plasma
hein added inline comments to D20237: Port to new KWorkspace API.
Apr 4 2019, 12:39 PM · Plasma

Apr 3 2019

hein updated the diff for D20237: Port to new KWorkspace API.

Fix up qDeleteAll usage, thanks David

Apr 3 2019, 9:51 PM · Plasma
hein added a dependent revision for D19389: Rewrite kworkspace logout, shutdown and suspend API: D20237: Port to new KWorkspace API.
Apr 3 2019, 9:00 PM · Plasma
hein requested review of D20237: Port to new KWorkspace API.
Apr 3 2019, 9:00 PM · Plasma
hein accepted D19873: [image-wallpaper] Port to Kirigami.FormLayout and use twinFormLayouts.
Apr 3 2019, 5:59 PM · Plasma
hein added a comment to D19926: Add Bookmark Handling.

Suuper good question that I also don't have a really good answer to :( But it's always super good when a project figures out how to answer it (e.g. Krita took off after it made a call to be a painting app).

Apr 3 2019, 5:32 PM · Dolphin
hein added a comment to D19926: Add Bookmark Handling.

I'm not sure the "Konqueror had it and people are asking
for it back" argument is strong. Because Konqueror was also unpopular enough to get replaced by Dolphin and to end up largely unmaintained (although it is still released and available). To me that indicates that becoming more like Konqueror may actually be the wrong direction.

Apr 3 2019, 8:27 AM · Dolphin
hein added a comment to D19926: Add Bookmark Handling.
Apr 3 2019, 8:23 AM · Dolphin

Apr 2 2019

hein added a comment to D19822: [Task Manager] Toggle mute when the audio indicator is clicked.

About the icon issue, IconItem by default uses the icon theme overlay from the Plasma theme, Kirigami.Icon will use the regular Plasma icons. That's kind of tricky - with Breeze we could totally make them match, but other Plasma themes would have issues.

Apr 2 2019, 9:26 PM · Plasma
hein added a comment to T10755: Unifying Applications' release versions.

Sure, why would the release team bump an individual app version if it wants to follow a random scheme?

Apr 2 2019, 8:56 PM
hein added a comment to D20205: initialize the kcolorscheme at the first app start.

Or the QPA could look at the LnF in the first place instead of kdeglobals?

Apr 2 2019, 7:50 PM · Plasma
hein added a comment to T10755: Unifying Applications' release versions.
In T10755#180963, @hein wrote:

That just seems to describe how you can make your app follow the KDE Apps YY.MM version number, not how Release Team can bump an individual app version number.

Looks like we have a subtask: Make sure all apps in "KDE Applications" store version numbers in a unified place, even if the version is not being bumped by script.

Apr 2 2019, 7:42 PM
hein added a comment to T10755: Unifying Applications' release versions.
In T10755#180958, @hein wrote:

But bumping version numbers is a technical problem that can have a technical solution.

It's not a problem. we've been doing that for years https://community.kde.org/Guidelines_and_HOWTOs/Application_Versioning

Apr 2 2019, 7:39 PM
hein added a comment to D19926: Add Bookmark Handling.

The Places panel is really for frequent and immediate access whereas bookmarks are more for long-term organization.

Apr 2 2019, 7:21 PM · Dolphin
hein added a comment to T10755: Unifying Applications' release versions.

On the other hand, having the release team take care of all of this stuff automatically and on a predictable schedule is really nice.

Apr 2 2019, 7:05 PM