[Download Plugin] Register downloaded files as recent documents
ClosedPublic

Authored by broulik on Thu, Jan 2, 10:01 PM.

Details

Summary

Makes them more easily accessible throughout the shell.

Test Plan


Diff Detail

Repository
R856 Plasma Browser Integration
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Thu, Jan 2, 10:01 PM
Restricted Application added a project: Plasma. · View Herald TranscriptThu, Jan 2, 10:01 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Thu, Jan 2, 10:01 PM
broulik updated this revision to Diff 72656.
  • Ignore incognito downloads
broulik added a comment.EditedThu, Jan 2, 10:28 PM

Should it purge the entry from kactivities stats when you manually remove the download from the download list in the browser?

Edit: Looks like the chrome.downloads.onErased signal doesn't fire for me, and even then, I only get the ID of the item that got removed, I probably can't query it for the filename after that.

ngraham accepted this revision.Fri, Jan 3, 12:36 AM
ngraham added a subscriber: ngraham.

Makes sense to me conceptually. Speaking personally, I would benefit from this as I often want to immediately do something with a file I just downloaded. Often the notification pop-up suffices, but if I want to do that thing more than a few seconds afterwards, this is a good thing to have so the file appears in the recent docs list.

This revision is now accepted and ready to land.Fri, Jan 3, 12:36 AM
broulik updated this revision to Diff 72737.Sat, Jan 4, 12:02 PM
broulik edited the test plan for this revision. (Show Details)
  • Make configurable
hein accepted this revision.Sat, Jan 4, 6:15 PM

I love it.

This revision was automatically updated to reflect the committed changes.