Thx, somehow forgot about this review

• Use enum instead bool for Targets::fromUrlList()

don't leak preview toggleAction in MainWindow::setupActions()

This patch is still needed - D7566 was needed for the initial copying of the puzzles from the global to the local storage. This one here is needed for the sync of the preview check state button and the proper recreation of the preview image when opening the same puzzle again after switching back to overview (see test plan).

Yes, all fine from my side

While you're at it - can you please give all create QActions 'this' as parent? KActionCollection::addAction() does not take ownership of the QAction*

• Do not remove user info when creating a svn::Url from a QUrl

• Remove useless includes to KPluginLoader

• Remove unneeded K_EXPORT_PLUGIN macros

• Remove unused dependency to KF5::Completion and KF5::Service

• Use QCollator as member to avoid useless constructions and explicitly set case sensitivity to Qt::CaseSensitive (default value is not documented)

ping?

ping?

commited directly with git, not arc...
https://commits.kde.org/palapeli/ebd26298b400be8c085a7c327804c8cce53b8db1

This one depends on D7416, D7417 and D7418

No, they should be independent from each other. At least they're in separate local branches and compile by their own.

next try ...

included in D7418

Thx for the pointer, I'm still fighting with 'arc'. Now all should be fine.

• KF5 port: replace KFileDialog with QFileDialog
• accidentally commited my local changes to mainwindow.cpp

fighting with arc... sry

• Remove unneeded K_EXPORT_PLUGIN macros

update to fix comments from nhirsl