Differential D7926

Remove pf.path() from container before the reference got screwed up by it.remove()
ClosedPublic
Actions

Authored by chehrlic on Sep 21 2017, 5:13 PM.

Details

Reviewers
broulik
Commits
R293:1b3f9facde45: Remove pf.path() from container before the reference got screwed up by it.
Summary

With a75db7aedfcd356b027774e0dc156c334d4cb869 I introduced a crash when removing a watched
directory. The Problem is that it.remove() invalidates the reference to PendingFile which
leads to a crash... :(
I found no bugreport about this on bugs.kde.org until now.

Test Plan

Remove a directory, baloo should never crash when removing a watched directory

Diff Detail

Repository
R293 Baloo
Branch
fix_crash_pendingfilequeue
Lint
No Linters Available
Unit
No Unit Test Coverage
chehrlic created this revision.Sep 21 2017, 5:13 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptSep 21 2017, 5:13 PM
Restricted Application added a subscriber: Frameworks. · View Herald Transcript
broulik accepted this revision.Sep 21 2017, 8:15 PM
This revision is now accepted and ready to land.Sep 21 2017, 8:15 PM
chehrlic closed this revision.Sep 23 2017, 12:29 PM

Revision Contents
Changeset List

PathPackages
Msrc/file/pendingfilequeue.cpp (4 lines)

Diff 19759

View Options

src/file/pendingfilequeue.cpp

Loading...