Differential D7637

Make sure that no interaction is active before clearing the scene
ClosedPublic
Actions

Authored by chehrlic on Aug 31 2017, 9:03 PM.

Details

Reviewers
None
Group Reviewers
KDE Games
Commits
R423:39cf28839784: Make sure that no interaction is active before clearing the scene
Summary

When the scene/views are cleared and there is still an interaction active, palapeli will crash.
This happens to due the fact that the interactors are holding pointers to pieces which are cleared
by Scene::clearPieces()
BUG 336075

Test Plan

As described in the bug description: Create a shortcut for restarting the puzzle, select a piece
and move it around. In the meantime restart the puzzle -> no more crash

Diff Detail

Repository
R423 Palapeli
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
chehrlic created this revision.Aug 31 2017, 9:03 PM
Restricted Application added a reviewer: KDE Games. · View Herald TranscriptAug 31 2017, 9:03 PM
Restricted Application added a subscriber: KDE Games. · View Herald Transcript
Closed by commit R423:39cf28839784: Make sure that no interaction is active before clearing the scene (authored by chehrlic). · Explain WhySep 9 2017, 1:28 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/engine/gameplay.cpp (2 lines)

Diff 19336

View Options

src/engine/gameplay.cpp

Loading...