Details

Reviewers

ltoscano

Group Reviewers

KDE Games

Commits

R423:f9490f5b415e: KF5 port: remove KF5::KDELibs4Support

Summary

last patch (only 5, not 7 patches needed) to remove kdelibs4support from frameworks branch

Test Plan

this one removes the last pieces from CMakeLists.txt - only works after the other 4. Still compiles, but now kdelibs4support - free :)

Diff Detail

Repository

R423 Palapeli

Branch

d7420

Lint

No Linters Available

Unit

No Unit Test Coverage

chehrlic created this revision.Aug 19 2017, 6:05 PM

Remove unneeded K_EXPORT_PLUGIN macros

Restricted Application added a reviewer: KDE Games. · View Herald TranscriptAug 20 2017, 1:09 PM

Restricted Application added a subscriber: KDE Games. · View Herald Transcript

fighting with arc... sry

This one depends on D7416, D7417 and D7418

ltoscano set the repository for this revision to R423 Palapeli.Aug 22 2017, 8:24 PM

Remove unused dependency to KF5::Completion and KF5::Service

You readded the K_EXPORT_PLUGIN macros, is it expected?

Remove unneeded K_EXPORT_PLUGIN macros

Remove useless includes to KPluginLoader

ltoscano accepted this revision.Aug 24 2017, 7:58 PM

This revision is now accepted and ready to land.Aug 24 2017, 7:58 PM

chehrlic closed this revision.Aug 25 2017, 5:48 PM

			Path	Packages
M			CMakeLists.txt (1 line)
M			libpala/CMakeLists.txt (4 lines)
M			mime/CMakeLists.txt (2 lines)
M			mime/thumbnail-creator.cpp (3 lines)
M			slicers/CMakeLists.txt (2 lines)
M			slicers/goldberg/slicer-goldberg.cpp (3 lines)
M			slicers/slicer-jigsaw.cpp (2 lines)
M			slicers/slicer-rect.cpp (2 lines)
M			src/CMakeLists.txt (7 lines)
M			src/creator/propertywidget_p.h (2 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	18403	30f2c1b		Aug 19 2017, 6:05 PM	★	★
Diff 2	18438	c24b375	- Remove unneeded K_EXPORT_PLUGIN macros	Aug 20 2017, 1:09 PM	★	★
Diff 3	18439	30f2c1b	fighting with arc... sry	Aug 20 2017, 1:46 PM	★	★
Diff 4	18611	7923333	- Remove unused dependency to KF5::Completion and KF5::Service	Aug 23 2017, 5:08 PM	★	★
Diff 5	18641	7923333	- Remove unneeded K_EXPORT_PLUGIN macros	Aug 24 2017, 4:48 AM	★	★
Diff 6	18649	7923333	- Remove useless includes to KPluginLoader	Aug 24 2017, 7:02 AM	★	★

Commit	Tree	Parents	Author	Summary	Date
27d883993faa	5c25364d1d40	ce50fed01319	Christian Ehrlicher	Remove useless includes to KPluginLoader	Aug 24 2017, 5:56 AM
ce50fed01319	a36c7cd3671d	2f1ccc74e94f	Christian Ehrlicher	Remove unneeded K_EXPORT_PLUGIN macros	Aug 20 2017, 1:07 PM
2f1ccc74e94f	a9019203695d	a39cb3a2a2fb	Christian Ehrlicher	Remove unused dependency to KF5::Completion and KF5::Service	Aug 23 2017, 5:07 PM
a39cb3a2a2fb	43db37be050a	792333353c10	Christian Ehrlicher	KF5 port: remove KF5::KDELibs4Support (Show More…)	Aug 19 2017, 3:33 PM

KF5 port: remove KF5::KDELibs4Support
ClosedPublic
Actions

Details

Diff Detail

Revision Contents
Changeset List

Diff 18649

CMakeLists.txt

libpala/CMakeLists.txt

mime/CMakeLists.txt

mime/thumbnail-creator.cpp

slicers/CMakeLists.txt

slicers/goldberg/slicer-goldberg.cpp

slicers/slicer-jigsaw.cpp

slicers/slicer-rect.cpp

src/CMakeLists.txt

src/creator/propertywidget_p.h

KF5 port: remove KF5::KDELibs4SupportClosedPublicActions

Details

Diff Detail

Revision ContentsChangeset List

Diff 18649

CMakeLists.txt

libpala/CMakeLists.txt

mime/CMakeLists.txt

mime/thumbnail-creator.cpp

slicers/CMakeLists.txt

slicers/goldberg/slicer-goldberg.cpp

slicers/slicer-jigsaw.cpp

slicers/slicer-rect.cpp

src/CMakeLists.txt

src/creator/propertywidget_p.h

KF5 port: remove KF5::KDELibs4Support
ClosedPublic
Actions

Revision Contents
Changeset List