Differential D7417

KF5 port: remove deprecated KStringHandler and KTabWidget usage
ClosedPublic
Actions

Authored by chehrlic on Aug 19 2017, 5:52 PM.

Details

Reviewers
ltoscano
Group Reviewers
KDE Games
Commits
R423:792333353c10: KF5 port: remove deprecated KStringHandler and KTabWidget usage
Summary

KStringHandler::naturalCompare() was replaced with QCollator (according to deprecating comment, other commits did it the same way)
KTabWidget was replaced with QTabWidget - there were no special KTabWidget functions at all.

Test Plan

TriggerConfig works as before

Diff Detail

Repository
R423 Palapeli
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
chehrlic created this revision.Aug 19 2017, 5:52 PM
Restricted Application added a reviewer: KDE Games. · View Herald TranscriptAug 19 2017, 5:52 PM
Restricted Application added a subscriber: KDE Games. · View Herald Transcript
ltoscano added a subscriber: ltoscano.Aug 22 2017, 7:35 PM

Could you please reduce the title a bit? It will be the first line in a git commit, and it contains two different descriptions.

Maybe just "KF5 port: port to QCollactor and QTabWidget" and more details in the summary?

chehrlic updated this revision to Diff 18556.Aug 22 2017, 8:05 PM
  • Use QCollator as member to avoid useless constructions and explicitly set case sensitivity to Qt::CaseSensitive (default value is not documented)
chehrlic retitled this revision from KF5 port: replace KStringHandler::naturalCompare() with QCollator KF5 port: replace KTabWidget with QTabWidget to KF5 port: remove deprecated KStringHandler and KTabWidget usage.Aug 22 2017, 8:08 PM
chehrlic edited the summary of this revision. (Show Details)
ltoscano accepted this revision.Aug 22 2017, 11:39 PM
This revision is now accepted and ready to land.Aug 22 2017, 11:39 PM
Closed by commit R423:792333353c10: KF5 port: remove deprecated KStringHandler and KTabWidget usage (authored by chehrlic). · Explain WhyAug 23 2017, 4:08 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 18608

View Options

src/config/triggerconfigwidget.h

Loading...
View Options

src/config/triggerconfigwidget.cpp

Loading...
View Options

src/config/triggerlistview_p.h

Loading...