Sort List by piece count does not work
ClosedPublic

Authored by chehrlic on Aug 27 2017, 6:01 PM.

Details

Summary

The sorting in the overview dialog did not work because the
QSortFilterProxyModel was not set up correctly

BUG: 376607

Test Plan

Test if the sorting works by selecting the appropriate sorting

Diff Detail

Repository
R423 Palapeli
Branch
bug_376607
Lint
No Linters Available
Unit
No Unit Test Coverage
chehrlic created this revision.Aug 27 2017, 6:01 PM
Restricted Application added a reviewer: KDE Games. · View Herald TranscriptAug 27 2017, 6:01 PM
Restricted Application added a subscriber: KDE Games. · View Herald Transcript
ltoscano accepted this revision.Aug 30 2017, 11:21 PM
ltoscano retitled this revision from Sort List by piece count does not work, BUG: 376607 to Sort List by piece count does not work.
ltoscano edited the summary of this revision. (Show Details)
ltoscano edited the test plan for this revision. (Show Details)
ltoscano added a subscriber: ltoscano.

It this works for the current stable, I'd strongly suggest to apply it there.

(note: I moved the bug number in the main body)

This revision is now accepted and ready to land.Aug 30 2017, 11:23 PM
chehrlic closed this revision.Aug 31 2017, 6:17 PM

Only one commit was needed :)
I backported it to Applications/17.08 and forward-merged to master and frameworks.