make Targets::fromUrlList() return an url instead a path if requested
ClosedPublic

Authored by chehrlic on Aug 29 2017, 5:42 PM.

Details

Summary

Targets::fromUrlList() tries to be smart and returns a path if the url is a local file.
This is wrong when kdesvn is working on a local svn repository (via file:///path/to/svn/repo) because subversion needs a url then.
Therefore I added a 'bool bKeepUrl' to make sure to create a url if needed.
This does fix the problem when working with kdesvn but will not help if the request is done via kio_svn.
There we have to do a check if we're working on a wc or repo - don't know if it's worth the trouble ...

Test Plan

Open kdesvn on a local svn repo, try to move/copy a file - works now (before there was a error message)

Diff Detail

Repository
R220 Subversion Client (KDE SVN)
Branch
review_urllist
Lint
No Linters Available
Unit
No Unit Test Coverage
chehrlic created this revision.Aug 29 2017, 5:42 PM
broulik added inline comments.
src/svnqt/targets.cpp
130

Can this instead be turned into an enum to avoid a boolean trap? fromUrlList(foo, false) isn't particularly descriptive at a glance

chehrlic updated this revision to Diff 18971.Aug 30 2017, 6:18 PM
  • Use enum instead bool for Targets::fromUrlList()
dfaure accepted this revision.Sep 3 2017, 8:52 AM
dfaure added inline comments.
src/svnfrontend/svnactions.cpp
2267

that comment should move one line up, like in the above method

This revision is now accepted and ready to land.Sep 3 2017, 8:52 AM
chehrlic closed this revision.Sep 3 2017, 5:19 PM