Differential D7566

Fix KStandardDirs::locateLocal() porting
ClosedPublic
Actions

Authored by chehrlic on Aug 26 2017, 8:02 PM.

Details

Reviewers
ltoscano
Group Reviewers
KDE Games
Commits
R423:c3beee6c2adf: Fix KStandardDirs::locateLocal() porting
Summary

KStandardDirs::locateLocal() created the directory if the requested
file and/or directory did not exist and returned the path. This
was not considered during porting to QStandardPaths

Test Plan
  • remove local palapeli config files (~/.local/share/palapeli/)
  • start palapeli, shipped puzzles should appear and ~/.local/share/palapeli/collection/ should contain a '.puzzle' file for every puzzle.
  • Try to create a new puzzle.

Diff Detail

Repository
R423 Palapeli
Branch
collection
Lint
No Linters Available
Unit
No Unit Test Coverage
chehrlic created this revision.Aug 26 2017, 8:02 PM
Restricted Application added a reviewer: KDE Games. · View Herald TranscriptAug 26 2017, 8:02 PM
Restricted Application added a subscriber: KDE Games. · View Herald Transcript
ltoscano accepted this revision.Aug 26 2017, 8:19 PM
ltoscano mentioned this in D7560: Properly show/hide preview dialog.
ltoscano edited the summary of this revision. (Show Details)
ltoscano edited the test plan for this revision. (Show Details)
ltoscano added a subscriber: ltoscano.

I took the liberty of fixing the commit message.
This change alone enable again the preview.

This revision is now accepted and ready to land.Aug 26 2017, 8:21 PM
chehrlic closed this revision.Aug 27 2017, 7:35 AM

Revision Contents
Changeset List

PathPackages
Msrc/file-io/collection.cpp (43 lines)

Diff 18826

View Options

src/file-io/collection.cpp

Loading...