Feed Advanced Search

Nov 19 2018

kfunk committed R32:6b645175138e: Increase timeout for duchain gcc compatibility test (authored by kfunk).
Increase timeout for duchain gcc compatibility test
Nov 19 2018, 10:39 PM
kfunk closed D16541: Increase timeout for duchain gcc compatibility test.
Nov 19 2018, 10:39 PM · KDevelop
kfunk added a comment to D16541: Increase timeout for duchain gcc compatibility test.

Will change to 60s (looks better) and then push. Thanks!

Nov 19 2018, 10:37 PM · KDevelop
kfunk requested review of D17032: Fix a few memory leaks ASAN: Fix leak in XWindowTasksModel.
Nov 19 2018, 10:35 PM · Plasma
kfunk requested review of D17031: Fix a few memory leaks ASAN: Fix leak in AppletQuickItem.
Nov 19 2018, 10:35 PM · Frameworks
kfunk committed R32:b03b30c2ffb6: patchreview: Restore libkomparediff2 5.0 support (authored by kfunk).
patchreview: Restore libkomparediff2 5.0 support
Nov 19 2018, 9:02 PM
kfunk updated the test plan for D17025: Perf: Do expensive regexp construction earlier.
Nov 19 2018, 8:32 PM · Plasma
kfunk requested review of D17025: Perf: Do expensive regexp construction earlier.
Nov 19 2018, 8:32 PM · Plasma
kfunk committed R52:d5646a6ace0c: Update .gitignore (authored by kfunk).
Update .gitignore
Nov 19 2018, 7:32 PM
kfunk committed R52:0a4bacb7e873: Merge remote-tracking branch 'origin/5.3' (authored by kfunk).
Merge remote-tracking branch 'origin/5.3'
Nov 19 2018, 7:32 PM

Nov 16 2018

kfunk committed R877:a1527e5e3cf1: kdevelop: Fix tarball urls (authored by kfunk).
kdevelop: Fix tarball urls
Nov 16 2018, 11:21 PM
kfunk requested changes to D16499: Bump min ECM/KF5 dep version to 5.18.

As said on IRC:
<kfunk> frinring: wouldn't change that in the stable branch
<kfunk> too late now, with 5.3.0 being released.
<kfunk> deps should stay at their resp. versions

Nov 16 2018, 2:18 PM · KDevelop
kfunk accepted D16461: Fix syntax support for dynamic member access..

LGTM as-is

Nov 16 2018, 2:14 PM · KDevelop
kfunk added a comment to D16461: Fix syntax support for dynamic member access..

I wonder if a couple of auto* element = it->element, auto* staticProperty = it->element->staticProperty sprayed throughout the code base would help making all of this a bit more readable...

Nov 16 2018, 2:14 PM · KDevelop
kfunk requested changes to D16894: [ECM] use a macro to add compiler flags conditionally.

I don't like the hiding of the if-branches as argument to macro. We shouldn't to this as it makes the code harder to understand.

Nov 16 2018, 11:37 AM · Frameworks, Build System
kfunk committed R119:a5fe302ee291: Fix CMake automoc warning (authored by kfunk).
Fix CMake automoc warning
Nov 16 2018, 10:27 AM
kfunk committed R119:e5778f31331a: Fix noisy -Wzero-as-null-pointer-constant warning (authored by kfunk).
Fix noisy -Wzero-as-null-pointer-constant warning
Nov 16 2018, 10:27 AM
kfunk committed R119:b368bd1b04b4: clang-tidy: use-modernize-nullptr run (authored by kfunk).
clang-tidy: use-modernize-nullptr run
Nov 16 2018, 10:26 AM
kfunk committed R119:52bf6becc6a6: clang-tidy: use-modernize-override run (authored by kfunk).
clang-tidy: use-modernize-override run
Nov 16 2018, 9:44 AM
kfunk committed R52:af9482c7a571: helper: Fix memory leak (authored by kfunk).
helper: Fix memory leak
Nov 16 2018, 8:44 AM
kfunk committed R32:11c7f9e950c5: Drop format.config.uncrustify.2_spaces (authored by kfunk).
Drop format.config.uncrustify.2_spaces
Nov 16 2018, 7:16 AM
kfunk committed R32:7b9572d3a797: tests: fix naming of test lines (authored by dakon).
tests: fix naming of test lines
Nov 16 2018, 7:07 AM
kfunk added a comment to D16915: Disable plugin project config if project without a IBuildSystemManager dep.

Nice non-BIC solution, I think!

Nov 16 2018, 7:03 AM · KDevelop
kfunk accepted D16910: Auto-find Clazy documentation also with clazy >= 1.4.

Sounds good to me.

Nov 16 2018, 7:00 AM · KDevelop
kfunk accepted D16495: Bump min dep versions of Qt & KF to 5.7 & 5.28.

@kfunk Would you be able to update your CI to use Debian Stable, so we have at least those minimal deps covered by some automated testing?

Nov 16 2018, 6:58 AM · KDevelop

Nov 15 2018

kfunk committed R32:1c91a9a8bf12: Merge remote-tracking branch 'origin/5.3' (authored by kfunk).
Merge remote-tracking branch 'origin/5.3'
Nov 15 2018, 6:18 PM
kfunk abandoned D4039: Add 'override' keyword only for new standards (BUG 372280).

Superseded by: https://phabricator.kde.org/D16773

Nov 15 2018, 1:51 PM · KDevelop
kfunk commandeered D4039: Add 'override' keyword only for new standards (BUG 372280).
Nov 15 2018, 1:51 PM · KDevelop
kfunk added a comment to D16819: Use 'Copy File Path' instead of 'Copy Filename' consistently.

"Copy file path" or "Copy File Path"?

Nov 15 2018, 12:58 PM · Kate
kfunk committed R32:c33cd259ef14: appimage: Do not bundle libfontconfig (authored by kfunk).
appimage: Do not bundle libfontconfig
Nov 15 2018, 12:33 PM
kfunk closed D16893: appimage: Do not bundle libfontconfig.
Nov 15 2018, 12:33 PM · KDevelop
kfunk added a comment to D16893: appimage: Do not bundle libfontconfig.

Thanks Christoph for jumping in!

Nov 15 2018, 12:31 PM · KDevelop
kfunk added a comment to D16893: appimage: Do not bundle libfontconfig.

The user (Antoine) reporting this issue also confirmed this fixes it:

Nov 15 2018, 12:06 PM · KDevelop
kfunk added a comment to D16495: Bump min dep versions of Qt & KF to 5.7 & 5.28.

Disclaimer: I'm pretty conservative when it comes to bumping version requirements of dependent packages. So far we don't get a lot by bumping the versions, quite the contrary we rather lose (potential, I know, but still) contributors b/c they cannot build KDevelop on their current OS.

Nov 15 2018, 12:01 PM · KDevelop
kfunk updated the diff for D16893: appimage: Do not bundle libfontconfig.

Fix typo in commit message

Nov 15 2018, 11:04 AM · KDevelop
kfunk added reviewers for D16893: appimage: Do not bundle libfontconfig: brauch, kossebau.
Nov 15 2018, 11:03 AM · KDevelop
kfunk requested review of D16893: appimage: Do not bundle libfontconfig.
Nov 15 2018, 11:03 AM · KDevelop

Nov 14 2018

kfunk committed R877:a69bbb6833c4: kdevelop: Use 5.3.0 tarball by default (authored by kfunk).
kdevelop: Use 5.3.0 tarball by default
Nov 14 2018, 1:46 PM
kfunk committed R877:d0f2e699d72a: kdevelop: Add 5.3.0 tarball (authored by kfunk).
kdevelop: Add 5.3.0 tarball
Nov 14 2018, 11:47 AM
kfunk committed R877:bfe8619e61fe: kdevelop: Do not pull in both webkit & webengine (authored by kfunk).
kdevelop: Do not pull in both webkit & webengine
Nov 14 2018, 8:59 AM
kfunk committed R877:4566da68aa51: kdevelop: Remove huge unneeded LTO.dll (authored by kfunk).
kdevelop: Remove huge unneeded LTO.dll
Nov 14 2018, 8:54 AM

Oct 28 2018

kfunk added a comment to D4490: WIP: Some KDevelop specific file templates.

Sorry for 'your loss', but I think it makes sense to just abandon this patch. It's probably easier for someone to start off from an already-existing plugin (which is similar to what the author intends to do with his new plugin).

Oct 28 2018, 6:11 PM
kfunk added inline comments to D16461: Fix syntax support for dynamic member access..
Oct 28 2018, 6:09 PM · KDevelop
kfunk abandoned D4697: Show shortcuts in tooltip texts where possible.

No time to work on that right now.

Oct 28 2018, 5:56 PM
kfunk abandoned D5123: Try to fix call to KXMLGuiWindow::setupGUI.

No time to work on that right now.

Oct 28 2018, 5:56 PM
kfunk closed D8950: Remove source code of unused CVS support plugin..
Oct 28 2018, 5:54 PM
kfunk accepted D8950: Remove source code of unused CVS support plugin..
Oct 28 2018, 5:53 PM
kfunk requested changes to D16461: Fix syntax support for dynamic member access..
Oct 28 2018, 5:39 PM · KDevelop
kfunk accepted D16458: Fix memleaks in duchain unittests.

Feel free to push to 5.3 branch after fixing my remarks.

Oct 28 2018, 5:36 PM · KDevelop

Oct 26 2018

kfunk committed R32:cf0ff290aa9b: Minor: Silence spurious Clang warning (authored by kfunk).
Minor: Silence spurious Clang warning
Oct 26 2018, 8:55 AM
kfunk committed R32:3b624a9c8ceb: More fine-tuning of uncrustify config (authored by kfunk).
More fine-tuning of uncrustify config
Oct 26 2018, 8:53 AM
kfunk committed R32:627361e0caf6: util: Reformat source using uncrustify (authored by kfunk).
util: Reformat source using uncrustify
Oct 26 2018, 8:53 AM
kfunk committed R32:e7021f60cc6a: Fine-tune uncrustify config more (authored by kfunk).
Fine-tune uncrustify config more
Oct 26 2018, 8:17 AM
kfunk committed R32:15dd16c3a0f7: tests: Reformat source with uncrustify (authored by kfunk).
tests: Reformat source with uncrustify
Oct 26 2018, 8:17 AM
kfunk committed R32:99ad13697a1d: Fix typo during code reformat, sorry (authored by kfunk).
Fix typo during code reformat, sorry
Oct 26 2018, 7:32 AM
kfunk committed R32:fefd475c26c2: externalscript: Reformat code with uncrustify (authored by kfunk).
externalscript: Reformat code with uncrustify
Oct 26 2018, 6:53 AM
kfunk committed R32:ae68d9cef0f4: Remove redundant/outdated kate mode lines/files (authored by kossebau).
Remove redundant/outdated kate mode lines/files
Oct 26 2018, 6:46 AM
kfunk closed D16426: Remove redundant/outdated kate mode lines/files.
Oct 26 2018, 6:46 AM · KDevelop
kfunk accepted D16426: Remove redundant/outdated kate mode lines/files.
Oct 26 2018, 6:45 AM · KDevelop
kfunk added a comment to D16426: Remove redundant/outdated kate mode lines/files.

Ah, good point, indeed.

Oct 26 2018, 6:20 AM · KDevelop

Oct 25 2018

kfunk committed R32:814388d5adfd: Minor: Add some more icons to the menu actions (authored by kfunk).
Minor: Add some more icons to the menu actions
Oct 25 2018, 11:13 AM
kfunk committed R32:961e0de14eda: Merge remote-tracking branch 'origin/5.3' (authored by kfunk).
Merge remote-tracking branch 'origin/5.3'
Oct 25 2018, 10:35 AM
kfunk committed R32:c50f4442ccbb: clang-tidy run: use-modernize-auto (authored by kfunk).
clang-tidy run: use-modernize-auto
Oct 25 2018, 10:35 AM
kfunk committed R32:c554b911d8db: serialization: Reformat code using uncrustify (authored by kfunk).
serialization: Reformat code using uncrustify
Oct 25 2018, 10:35 AM
kfunk committed R32:eeaf888dcc5d: kdevsvncpp: Hide more compiler warnings (authored by kfunk).
kdevsvncpp: Hide more compiler warnings
Oct 25 2018, 10:32 AM
kfunk committed R32:f14edc6068bf: debuggercommon: Remove some dead code (authored by kfunk).
debuggercommon: Remove some dead code
Oct 25 2018, 9:03 AM
kfunk committed R32:d1a374f03610: test_ctestfindsuites: Increase timeout (authored by kfunk).
test_ctestfindsuites: Increase timeout
Oct 25 2018, 8:55 AM
kfunk committed R32:946fcfa3178d: test_duchain-clang: Fix parse error (authored by kfunk).
test_duchain-clang: Fix parse error
Oct 25 2018, 8:39 AM
kfunk committed R32:8a6ceacd5e80: test_identifier: Hide some warnings from Clang (authored by kfunk).
test_identifier: Hide some warnings from Clang
Oct 25 2018, 8:27 AM
kfunk committed R32:e6216d1c9994: contextbrowser: Reformat source using uncrustify (authored by kfunk).
contextbrowser: Reformat source using uncrustify
Oct 25 2018, 8:18 AM
kfunk committed R32:c4bceaa3815d: classbrowser: Reformat source using uncrustify (authored by kfunk).
classbrowser: Reformat source using uncrustify
Oct 25 2018, 8:16 AM
kfunk committed R32:0e61a419b58a: language: Reformat source code using uncrustify (authored by kfunk).
language: Reformat source code using uncrustify
Oct 25 2018, 8:14 AM
kfunk committed R32:a5e93e86a4d2: Fine-tune uncrustify config a bit more (authored by kfunk).
Fine-tune uncrustify config a bit more
Oct 25 2018, 8:14 AM
kfunk committed R32:2e694a964cd0: qmljs: Hide -Woverloaded-virtual warnings in qmljs (authored by kfunk).
qmljs: Hide -Woverloaded-virtual warnings in qmljs
Oct 25 2018, 8:14 AM

Oct 24 2018

kfunk committed R32:3ffe7fdd0a78: qmljs: Enable exceptions for qmljs lib (authored by kfunk).
qmljs: Enable exceptions for qmljs lib
Oct 24 2018, 10:08 PM
kfunk committed R32:a5308e870ae4: Merge remote-tracking branch 'origin/5.3' (authored by kfunk).
Merge remote-tracking branch 'origin/5.3'
Oct 24 2018, 9:51 PM
kfunk committed R32:6501b35cb64b: duchain: Make htmlIdentifiedType() crash-safe (authored by kfunk).
duchain: Make htmlIdentifiedType() crash-safe
Oct 24 2018, 9:44 PM
kfunk committed R32:5f1dade194a0: Merge branch 'update-3rdparty-qmljs' (authored by kfunk).
Merge branch 'update-3rdparty-qmljs'
Oct 24 2018, 8:59 PM
kfunk committed R32:e6f41edea53b: qmljs: Integrate updated qmljs library (authored by kfunk).
qmljs: Integrate updated qmljs library
Oct 24 2018, 8:59 PM
kfunk committed R32:82276cb77d6d: qmljs: Patch incompatible code out (authored by kfunk).
qmljs: Patch incompatible code out
Oct 24 2018, 8:59 PM
kfunk committed R32:f420ee1e66fd: qmljs: Update qmljs from QtCreator v4.7.2 (authored by kfunk).
qmljs: Update qmljs from QtCreator v4.7.2
Oct 24 2018, 8:59 PM
kfunk committed R32:ca03781e690e: Merge remote-tracking branch 'origin/5.3' (authored by kfunk).
Merge remote-tracking branch 'origin/5.3'
Oct 24 2018, 7:33 PM
kfunk committed R32:79a8f0f5204b: qmljs: Add description to JSON file (authored by kfunk).
qmljs: Add description to JSON file
Oct 24 2018, 7:32 PM
kfunk committed R32:980f548da1e1: LoadedPluginsDialog: Fix initial size (authored by kfunk).
LoadedPluginsDialog: Fix initial size
Oct 24 2018, 7:32 PM
kfunk committed R32:5343c36f45a8: LoadedPluginsDialog: Fix initial size (authored by kfunk).
LoadedPluginsDialog: Fix initial size
Oct 24 2018, 7:28 PM
kfunk committed R32:31c8db7d876b: Remove only use of qCInfo (authored by kfunk).
Remove only use of qCInfo
Oct 24 2018, 7:05 PM
kfunk committed R52:7bc6f3ec649e: Minor: Remove overly aggressive debug out (authored by kfunk).
Minor: Remove overly aggressive debug out
Oct 24 2018, 7:03 PM
kfunk committed R94:680b4a3dcba2: Minor: Fix compiler warnings in kxface.h (authored by kfunk).
Minor: Fix compiler warnings in kxface.h
Oct 24 2018, 6:55 PM
kfunk committed R52:8143d277f044: Streamline logging category ids (authored by kfunk).
Streamline logging category ids
Oct 24 2018, 6:42 PM
kfunk committed R53:d377641aa0c2: Streamline logging category ids (authored by kfunk).
Streamline logging category ids
Oct 24 2018, 6:40 PM
kfunk committed R32:9b0de4eb143c: Merge remote-tracking branch 'origin/5.3' (authored by kfunk).
Merge remote-tracking branch 'origin/5.3'
Oct 24 2018, 6:21 PM
kfunk committed R32:e681b91ccccd: Merge commit 'origin/5.3~1' (authored by kfunk).
Merge commit 'origin/5.3~1'
Oct 24 2018, 6:21 PM

Oct 23 2018

kfunk added inline comments to D15002: Allow to install syntax files instead of having them in a resource.
Oct 23 2018, 10:27 PM · Frameworks, Kate
kfunk committed R32:8d012ccfca2e: appimage: Fix paths to patch files (authored by kfunk).
appimage: Fix paths to patch files
Oct 23 2018, 10:19 PM
kfunk committed R32:1ab52fb6d35f: appimage: Fix logic in .sh script (authored by kfunk).
appimage: Fix logic in .sh script
Oct 23 2018, 10:15 PM
kfunk committed R32:068e7e929c39: appimage: Patch grantlee to avoid recompilation (authored by kfunk).
appimage: Patch grantlee to avoid recompilation
Oct 23 2018, 10:13 PM
kfunk committed R32:0e1cacb48080: appimage: Generalize patch handling (authored by kfunk).
appimage: Generalize patch handling
Oct 23 2018, 10:11 PM
kfunk committed R32:240040c0ff0a: appimage: Remove Breeze wallpaper from artefact (authored by kfunk).
appimage: Remove Breeze wallpaper from artefact
Oct 23 2018, 10:01 PM
kfunk committed R32:8dac4da3df9a: appimage: Use appimagetool (authored by kfunk).
appimage: Use appimagetool
Oct 23 2018, 9:47 PM
kfunk committed R32:7424e5d4be8e: Merge remote-tracking branch 'origin/5.3' (authored by kfunk).
Merge remote-tracking branch 'origin/5.3'
Oct 23 2018, 9:03 PM