appimage: Do not bundle libfontconfig
ClosedPublic

Authored by kfunk on Nov 15 2018, 11:03 AM.

Details

Summary

The bundled libfontconfig seems to cause problems when the target system uses
a newer font config format. See discussion here:

https://mail.kde.org/pipermail/kdevelop/2018-October/019726.html

It seems to be a common problem (as seen in bug reports of other AppImage
projects).

It's also blacklisted in linuxdeployqt:

https://github.com/AppImage/AppImages/blob/master/excludelist

For me locally, after the change I also have the exact same font appearance
as with native applications. Before the patch the fonts did use my
anti-aliasing settings iiuc. Before the patch, running the AppImage resulted
in lots of warnings:

Fontconfig warning: line 5: unknown element "its:rules"
Fontconfig warning: line 6: unknown element "its:translateRule"
Fontconfig warning: line 9: unknown element "description"
Fontconfig warning: "/etc/fonts/conf.d/10-hinting-slight.conf", line 4: unknown element "its:rules"
Fontconfig warning: "/etc/fonts/conf.d/10-hinting-slight.conf", line 5: unknown element "its:translateRule"
Fontconfig warning: "/etc/fonts/conf.d/10-hinting-slight.conf", line 8: unknown element "description"
...

... these warnings are now gone.

Thanks for the analysis by Friedrich.

Actually easy to test using the new AppImage format. Just do:

./KDevelop-5.3.0-x86_64.AppImage --appimage-extract
cd squashfs-root
./AppRun # to check appearance before
rm rm usr/lib/libfontconfig.so.1
./AppRun # to check appearance after rm'ing the lib

Diff Detail

Repository
R32 KDevelop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kfunk created this revision.Nov 15 2018, 11:03 AM
Restricted Application added a project: KDevelop. · View Herald TranscriptNov 15 2018, 11:03 AM
Restricted Application added a subscriber: kdevelop-devel. · View Herald Transcript
kfunk requested review of this revision.Nov 15 2018, 11:03 AM
kfunk updated this revision to Diff 45507.Nov 15 2018, 11:04 AM

Fix typo in commit message

The user (Antoine) reporting this issue also confirmed this fixes it:

It works ! Thanks you !
Antoine

(...)
> @Antoine, could you try the following:
>
> ./KDevelop-5.3.0-x86_64.AppImage --appimage-extract
> cd squashfs-root
> rm rm usr/lib/libfontconfig.so.1
> ./AppRun
cullmann accepted this revision.Nov 15 2018, 12:20 PM
cullmann added a subscriber: cullmann.

To assume fontconfig is there is reasonable, do the same for our commercial stuff since years. I think the config parts & cache didn't stay 100% compatible.

This revision is now accepted and ready to land.Nov 15 2018, 12:20 PM

Thanks Christoph for jumping in!

This revision was automatically updated to reflect the committed changes.