Differential D4697

Show shortcuts in tooltip texts where possible
AbandonedPublic
Actions

Authored by kfunk on Feb 20 2017, 11:25 PM.

Details

Reviewers

mwolff

Group Reviewers

KDevelop

Summary

Provide a helper class for this: ActionToolTipModifier, which operates
on a KActionCollection instance.

Diff Detail

Repository

R33 KDevPlatform

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

kfunk created this revision.Feb 20 2017, 11:25 PM

Restricted Application added a subscriber: kdevelop-devel. · View Herald TranscriptFeb 20 2017, 11:25 PM

Remove unneeded include

Why export it put it in util? We won't be using this elsewhere, right?

In D4697#88129, @apol wrote:

Why export it put it in util? We won't be using this elsewhere, right?

True. I've used this class outside of shell/ before, then refactored. Doesn't make sense anymore to export it now.

Thanks!

Way better than my approach. I'm closing my diff.

Address Aleix' concerns

kfunk added a reviewer: KDevelop.Feb 21 2017, 8:50 AM

lgtm

This revision is now accepted and ready to land.Feb 21 2017, 8:51 AM

There are some problems with plugin shortcut tool tips not updating properly. Investigating... Sigh.

This seems generally useful. Would it make sense to put it in KF5?

@nalvarez Once it works, maybe.

@kfunk: Any plans with this one? I would propose to mark it abandoned otherwise, so our list of patches to review is clean from (currently) dead things.

No time to work on that right now.

Revision Contents
Changeset List

		Path
M		shell/CMakeLists.txt (1 line)
A	M	shell/actiontooltipmodifier.h (56 lines)
A	M	shell/actiontooltipmodifier.cpp (87 lines)
M		shell/mainwindow_p.cpp (5 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	11571	2fcaccd		Feb 20 2017, 11:25 PM	★	★
Diff 2	11572	2fcaccd	Remove unneeded include	Feb 20 2017, 11:32 PM	★	★
Diff 3	11577	b302adb	Address Aleix' concerns	Feb 21 2017, 8:47 AM	★	★