Feed Advanced Search

Aug 20 2019

brute4s99 added a comment to D23282: add `-pid` parameter to Snore backend calls.

landing it!

a duckling

Aug 20 2019, 12:41 PMFrameworks

Aug 19 2019

brute4s99 added a comment to T11398: Publish KDE Connect to the Windows Store.

the builds are successfully being built on the CI now. We just need to iron out the kinks so it actually works like it should, on all systems.

Aug 19 2019, 11:13 PMKDE Connect
brute4s99 added a comment to T11398: Publish KDE Connect to the Windows Store.

reference patch : https://phabricator.kde.org/D23209 (merged already)

Aug 19 2019, 11:11 PMKDE Connect
brute4s99 updated the task description for T11398: Publish KDE Connect to the Windows Store.
Aug 19 2019, 11:10 PMKDE Connect
brute4s99 added a comment to D23133: avoid duplicate notifications from showing up on Windows and remove whitespaces.

can I merge this one? 馃憖

Aug 19 2019, 10:52 PMFrameworks
brute4s99 added a dependency for D23282: add `-pid` parameter to Snore backend calls: D23273: Allow to pass pid in addition to appID try to deduce appID from pid.
Aug 19 2019, 10:42 PMFrameworks
brute4s99 added a dependent revision for D23273: Allow to pass pid in addition to appID try to deduce appID from pid: D23282: add `-pid` parameter to Snore backend calls.
Aug 19 2019, 10:42 PM
brute4s99 requested review of D23282: add `-pid` parameter to Snore backend calls.
Aug 19 2019, 10:41 PMFrameworks
brute4s99 added a comment to D23196: have 1024x1024 app icon as fallback icon in Snore.

may I land this now? 馃憖

Aug 19 2019, 8:50 PMFrameworks
brute4s99 committed R877:477cbe230ff1: add images to KDE Connect .Appx build (authored by brute4s99).
add images to KDE Connect .Appx build
Aug 19 2019, 8:28 PM
brute4s99 closed D23209: add images to KDE Connect .Appx build.
Aug 19 2019, 8:28 PMCraft, KDE Connect
brute4s99 added a comment to D23209: add images to KDE Connect .Appx build.

landing it!

a duckling

Aug 19 2019, 8:28 PMCraft, KDE Connect
brute4s99 updated the diff for D23209: add images to KDE Connect .Appx build.
Aug 19 2019, 8:09 PMCraft, KDE Connect
brute4s99 committed R224:607d643d8c1e: add `windowIcon` to daemon for better support on Windows (authored by brute4s99).
add `windowIcon` to daemon for better support on Windows
Aug 19 2019, 6:59 PM

Aug 18 2019

brute4s99 committed R224:5b13f28912a9: re-add support for keyboard in Windows build (authored by brute4s99).
re-add support for keyboard in Windows build
Aug 18 2019, 7:58 PM
brute4s99 updated the diff for D23196: have 1024x1024 app icon as fallback icon in Snore.
Aug 18 2019, 7:14 PMFrameworks
brute4s99 updated the diff for D23196: have 1024x1024 app icon as fallback icon in Snore.
Aug 18 2019, 7:06 PMFrameworks

Aug 17 2019

brute4s99 committed R224:80608893656a: Fix presenter plugin for Win32 (authored by brute4s99).
Fix presenter plugin for Win32
Aug 17 2019, 11:42 PM
brute4s99 committed R224:d35b845c0fa1: use Qt in place of Unix-only symbols in kio/kdeconnect (authored by brute4s99).
use Qt in place of Unix-only symbols in kio/kdeconnect
Aug 17 2019, 10:12 PM

Aug 16 2019

brute4s99 updated subscribers of T11398: Publish KDE Connect to the Windows Store.
Aug 16 2019, 10:47 PMKDE Connect
brute4s99 updated the task description for T11398: Publish KDE Connect to the Windows Store.
Aug 16 2019, 10:47 PMKDE Connect
brute4s99 updated subscribers of T11398: Publish KDE Connect to the Windows Store.

so we have Jenkins ready to build .Appx packages for us now, thanks to @bcooksley : https://invent.kde.org/sysadmin/binary-factory-tooling/commit/aeddc47b0ca4dcdef64044226b99d9b78a0156a7

Aug 16 2019, 10:46 PMKDE Connect
brute4s99 added a reviewer for D23196: have 1024x1024 app icon as fallback icon in Snore: broulik.
Aug 16 2019, 10:05 PMFrameworks
brute4s99 updated the diff for D23196: have 1024x1024 app icon as fallback icon in Snore.

updated

Aug 16 2019, 10:04 PMFrameworks
brute4s99 added inline comments to D23196: have 1024x1024 app icon as fallback icon in Snore.
Aug 16 2019, 10:03 PMFrameworks
brute4s99 requested review of D23209: add images to KDE Connect .Appx build.
Aug 16 2019, 9:42 PMCraft, KDE Connect
brute4s99 requested review of D23196: have 1024x1024 app icon as fallback icon in Snore.
Aug 16 2019, 2:43 AMFrameworks
brute4s99 updated the diff for D23133: avoid duplicate notifications from showing up on Windows and remove whitespaces.

took inspiration from NotifyByAndroid. Now I can see all types of notifications perfectly well!

Aug 16 2019, 2:35 AMFrameworks

Aug 14 2019

brute4s99 added a comment to D23133: avoid duplicate notifications from showing up on Windows and remove whitespaces.

the duplicate notification always has id= -1, so I think it's more an issue of KNotifications, I think

Aug 14 2019, 8:09 AMFrameworks

Aug 13 2019

brute4s99 requested review of D23133: avoid duplicate notifications from showing up on Windows and remove whitespaces.
Aug 13 2019, 6:47 PMFrameworks
brute4s99 triaged T11398: Publish KDE Connect to the Windows Store as Normal priority.
Aug 13 2019, 5:25 PMKDE Connect
brute4s99 added a comment to D21661: add snoretoast backend for KNotifications on Windows.

It looks like this made D-Bus and Phonon hard required dependencies on Android again!?

Aug 13 2019, 10:18 AMFrameworks
brute4s99 committed R289:a56a379097d5: really fix Android build (authored by brute4s99).
really fix Android build
Aug 13 2019, 10:07 AM

Aug 12 2019

brute4s99 added a comment to D22727: allow kio-extras to build with mingw on win32 and remove unnecessary includes.

The Qt documentation says "Warning: Because of differences in the platforms supported by Qt, the semantics of ReadUser, WriteUser and ExeUser are platform-dependent: On Unix, the rights of the owner of the file are returned and on Windows the rights of the current user are returned. "

Aug 12 2019, 9:35 AMFrameworks, Dolphin

Aug 11 2019

brute4s99 committed R289:c38411bd8fc7: fix android build (authored by brute4s99).
fix android build
Aug 11 2019, 8:37 PM
brute4s99 committed R289:a5e79e704763: fix build (authored by brute4s99).
fix build
Aug 11 2019, 8:27 PM
brute4s99 closed D21661: add snoretoast backend for KNotifications on Windows.
Aug 11 2019, 7:30 PMFrameworks
brute4s99 committed R289:d00612351778: add snoretoast backend for KNotifications on Windows (authored by brute4s99).
add snoretoast backend for KNotifications on Windows
Aug 11 2019, 7:30 PM
brute4s99 updated the diff for D21661: add snoretoast backend for KNotifications on Windows.

removed duplication

Aug 11 2019, 5:56 PMFrameworks
brute4s99 updated the diff for D21661: add snoretoast backend for KNotifications on Windows.

rebased.

Aug 11 2019, 3:28 PMFrameworks
brute4s99 updated the diff for D21661: add snoretoast backend for KNotifications on Windows.

landing this one. 馃帀

Aug 11 2019, 3:14 PMFrameworks
brute4s99 added a comment to D21661: add snoretoast backend for KNotifications on Windows.

done.

Aug 11 2019, 3:14 PMFrameworks
brute4s99 added a comment to D21661: add snoretoast backend for KNotifications on Windows.

waiting for some green light(s) for now...

Aug 11 2019, 1:26 PMFrameworks
brute4s99 updated the diff for D21661: add snoretoast backend for KNotifications on Windows.
  • removed the duplicate remover.
Aug 11 2019, 1:23 PMFrameworks
brute4s99 added a comment to D21661: add snoretoast backend for KNotifications on Windows.

landing it...

Aug 11 2019, 1:20 PMFrameworks

Aug 1 2019

brute4s99 committed R224:ccc8bb8a0e60: Split config issue fix for Win32 build (authored by brute4s99).
Split config issue fix for Win32 build
Aug 1 2019, 2:02 PM

Jul 27 2019

brute4s99 committed R224:ccb9c1fd48f3: put win check within sfos (authored by brute4s99).
put win check within sfos
Jul 27 2019, 9:06 PM
brute4s99 added inline comments to D22727: allow kio-extras to build with mingw on win32 and remove unnecessary includes.
Jul 27 2019, 8:03 PMFrameworks, Dolphin
brute4s99 added inline comments to D21661: add snoretoast backend for KNotifications on Windows.
Jul 27 2019, 9:41 AMFrameworks

Jul 26 2019

brute4s99 added a comment to D21661: add snoretoast backend for KNotifications on Windows.

Please do a last minute review, I believe this patch is ready to merge now. 馃帀

Jul 26 2019, 6:16 PMFrameworks

Jul 24 2019

brute4s99 added a comment to D22727: allow kio-extras to build with mingw on win32 and remove unnecessary includes.

Looks good.
Why not the first time 馃槉

Jul 24 2019, 9:50 PMFrameworks, Dolphin
brute4s99 requested review of D22727: allow kio-extras to build with mingw on win32 and remove unnecessary includes.
Jul 24 2019, 9:27 PMFrameworks, Dolphin

Jul 23 2019

brute4s99 closed D22686: add kpeoplevcard to kdeconnect-kde.
Jul 23 2019, 4:15 PM
brute4s99 committed R877:367549ebbda1: add kpeoplevcard to kdeconnect-kde (authored by brute4s99).
add kpeoplevcard to kdeconnect-kde
Jul 23 2019, 4:15 PM
brute4s99 requested review of D22686: add kpeoplevcard to kdeconnect-kde.
Jul 23 2019, 2:36 PM
brute4s99 updated the diff for D22554: Finer No-Dbus on Windows.

let's put a pin in this for a while until I get a better solution for DBus on Windows

Jul 23 2019, 9:49 AMFrameworks
brute4s99 added a comment to R289:be466180db21: remove dbus for windows build and change audio dep logic.

got it 馃槬馃敨

Jul 23 2019, 9:43 AM
brute4s99 added a comment to T11275: Compilation errors on Windows CI related to KStatusNotifierItem.

nvm, I'll try to find a better solution instead.

Jul 23 2019, 9:42 AMSysadmin
brute4s99 added a comment to D21660: remove dbus for windows build and change audio dep logic.

sorry about that. I'll find a better solution that doesn't break builds 馃檲

Jul 23 2019, 9:41 AMFrameworks
brute4s99 added a comment to T11275: Compilation errors on Windows CI related to KStatusNotifierItem.

For KStatusNotifierItem, KDE Connect uses QSystemTrayIcon on windows. See https://github.com/KDE/kdeconnect-kde/blob/master/indicator/main.cpp#L169

Jul 23 2019, 9:34 AMSysadmin
brute4s99 added a comment to R289:be466180db21: remove dbus for windows build and change audio dep logic.

?

Jul 23 2019, 9:29 AM
brute4s99 committed R289:c3fabfaef786: move find_package calls to root and add win32_defaults.notifyrc (authored by brute4s99).
move find_package calls to root and add win32_defaults.notifyrc
Jul 23 2019, 9:12 AM
brute4s99 committed R289:cf927d5fccf4: fix pull (authored by brute4s99).
fix pull
Jul 23 2019, 9:12 AM
brute4s99 committed R289:f4a2df5b09e0: remove stray stuff (authored by brute4s99).
remove stray stuff
Jul 23 2019, 9:12 AM
brute4s99 committed R289:914c7c395d4f: workaround for msvc19 (authored by brute4s99).
workaround for msvc19
Jul 23 2019, 9:12 AM
brute4s99 committed R289:79598a083bdd: more suggestion fixes and fix broken patch (authored by brute4s99).
more suggestion fixes and fix broken patch
Jul 23 2019, 9:12 AM
brute4s99 committed R289:92f53bc81034: rename vars (authored by brute4s99).
rename vars
Jul 23 2019, 9:12 AM
brute4s99 committed R289:3cb32be5f8d2: fix duplicate-ness (authored by brute4s99).
fix duplicate-ness
Jul 23 2019, 9:12 AM
brute4s99 committed R289:60f9fd988bf6: fixed crash and added icon removal (authored by brute4s99).
fixed crash and added icon removal
Jul 23 2019, 9:12 AM
brute4s99 committed R289:6af20c717823: updated acc to new reviews by Hannah and Pino (authored by brute4s99).
updated acc to new reviews by Hannah and Pino
Jul 23 2019, 9:12 AM
brute4s99 committed R289:5e39fbf239ea: updated at 100 comments (authored by brute4s99).
updated at 100 comments
Jul 23 2019, 9:12 AM
brute4s99 committed R289:f19ca493f4b5: updated acc to review by Hannah (authored by brute4s99).
updated acc to review by Hannah
Jul 23 2019, 9:12 AM
brute4s99 committed R289:4b17f47483f4: add notification filter for ID = -1, but this breaks Pairing notification :/ (authored by brute4s99).
add notification filter for ID = -1, but this breaks Pairing notification :/
Jul 23 2019, 9:12 AM
brute4s99 committed R289:2dce69d225c6: updated acc to reviews by Simon and Pino (authored by brute4s99).
updated acc to reviews by Simon and Pino
Jul 23 2019, 9:12 AM
brute4s99 committed R289:bb190b64712b: use enum instead for button (authored by brute4s99).
use enum instead for button
Jul 23 2019, 9:12 AM
brute4s99 committed R289:74d07625454d: enum handling for notif interactions (authored by brute4s99).
enum handling for notif interactions
Jul 23 2019, 9:12 AM
brute4s99 committed R289:ab536190db27: add a word in comment (authored by brute4s99).
add a word in comment
Jul 23 2019, 9:12 AM
brute4s99 committed R289:400306568079: fix button condition and remove ID from notif text (authored by brute4s99).
fix button condition and remove ID from notif text
Jul 23 2019, 9:12 AM
brute4s99 committed R289:a277ebf26434: IT WORKS \o/ (authored by brute4s99).
IT WORKS \o/
Jul 23 2019, 9:12 AM
brute4s99 committed R289:d995759456fd: remove whitespaces (authored by brute4s99).
remove whitespaces
Jul 23 2019, 9:12 AM
brute4s99 committed R289:5541732e69f2: shifting to ctor (authored by brute4s99).
shifting to ctor
Jul 23 2019, 9:12 AM
brute4s99 committed R289:027a953ea490: attempt 1, still unstable (authored by brute4s99).
attempt 1, still unstable
Jul 23 2019, 9:12 AM
brute4s99 committed R289:3afb784b751b: from brute4s99/snore-ftw (authored by brute4s99).
from brute4s99/snore-ftw
Jul 23 2019, 9:12 AM
brute4s99 committed R289:55dca13fe650: up to speed with fixes and ready for testing suggestions (authored by brute4s99).
up to speed with fixes and ready for testing suggestions
Jul 23 2019, 9:12 AM
brute4s99 committed R289:43439babb6c8: finer no-dbus on windows (authored by brute4s99).
finer no-dbus on windows
Jul 23 2019, 9:12 AM
brute4s99 updated the diff for D21661: add snoretoast backend for KNotifications on Windows.

updated and rebased.

Jul 23 2019, 9:03 AMFrameworks

Jul 22 2019

brute4s99 accepted D22659: Fix bracket.
Jul 22 2019, 6:10 PMFrameworks, Dolphin
brute4s99 added a comment to D22659: Fix bracket.

thanks Hannah!

Jul 22 2019, 6:10 PMFrameworks, Dolphin
brute4s99 abandoned D22635: add new dependencies for KDE Connect.
Jul 22 2019, 3:26 PM
brute4s99 added a comment to D22635: add new dependencies for KDE Connect.

ah, I did not see that patch. No use of this one now. 馃樅

Jul 22 2019, 3:26 PM
brute4s99 requested review of D22635: add new dependencies for KDE Connect.
Jul 22 2019, 7:48 AM

Jul 21 2019

brute4s99 added a comment to D22105: Fix SFTP Plugin of KIO for Windows.

:p

Jul 21 2019, 11:56 PMFrameworks, Dolphin
brute4s99 retitled D22105: Fix SFTP Plugin of KIO for Windows from WIP : Fix SFTP Plugin of KIO for Windows to Fix SFTP Plugin of KIO for Windows.
Jul 21 2019, 11:56 PMFrameworks, Dolphin
brute4s99 added a comment to D22105: Fix SFTP Plugin of KIO for Windows.

I'll not leave it like this from next time, that's for sure. :p

Jul 21 2019, 11:56 PMFrameworks, Dolphin
brute4s99 added a comment to D22105: Fix SFTP Plugin of KIO for Windows.

should've removed WIP before landing 馃槵

Jul 21 2019, 10:48 PMFrameworks, Dolphin
brute4s99 committed R320:d6d724b9d4b9: WIP : Fix SFTP Plugin of KIO for Windows (authored by brute4s99).
WIP : Fix SFTP Plugin of KIO for Windows
Jul 21 2019, 10:48 PM
brute4s99 closed D22105: Fix SFTP Plugin of KIO for Windows.
Jul 21 2019, 10:48 PMFrameworks, Dolphin
brute4s99 added a comment to D22105: Fix SFTP Plugin of KIO for Windows.

yeah I can push! I'm a GSoCer lol

Jul 21 2019, 10:48 PMFrameworks, Dolphin
brute4s99 updated the diff for D22105: Fix SFTP Plugin of KIO for Windows.

updated!

Jul 21 2019, 10:44 PMFrameworks, Dolphin
brute4s99 updated the summary of D22105: Fix SFTP Plugin of KIO for Windows.
Jul 21 2019, 8:52 PMFrameworks, Dolphin