• Rebase on master

• Show "Empty Trash" button inside trash directory

Rebase on master

Rebase on master

Fix comment

Cleanup

Fix docbook

Rebase on master

• Truncate long filenames, replace "/" with "_"

• React to comments
• Better way to remove '%T' with separators around it

In D10985#218230, @markg wrote:

-1 this is totally unrelated. For future reference, i see new functions being added (setFocus and hasFocus and the addition of an action.

Sort #include

Revert wrong commits

• Show "Empty Trash" button inside trash directory

• Show "Empty Trash" button inside trash directory

Rebase on master

Blocked by D11012

Fixes

Split commit

@elvisangelaccio, please review it

Add comments

Rebase on master

Remove the removal of unused #include

Remove the removal of unused #include

Remove #include removal

Rebase on master

• Add fall through clarification

• Fix some other compile warnings

• Symlink "Show Original" in new window

! In D10990#217483, @ngraham wrote:

Also, can you conditionally add this to the file menu, too? Let's try not to have any functionality that you can only access via a context menu.

In D10804#217489, @elvisangelaccio wrote:

I like the UI now, but it's kinda hard to review the code. Can you please split this patch into more commits? At least one for the bugfix and one for the new feature.

Split commit

In D10985#217572, @markg wrote:

In D10985#217567, @rominf wrote:

Can somebody land it for me? I have some problems:

$ arc land
Landing current branch 'remove-unused-includes'.
 TARGET  Landing onto "master", the default target under git.
 REMOTE  Using remote "origin", the default remote under git.
 FETCH  Fetching origin/master...
Usage Exception: There are no commits on "remove-unused-includes" which are not already present on the target.

In D10985#217571, @elvisangelaccio wrote:

In D10985#217567, @rominf wrote:

Can somebody land it for me? I have some problems:

$ arc land
Landing current branch 'remove-unused-includes'.
 TARGET  Landing onto "master", the default target under git.
 REMOTE  Using remote "origin", the default remote under git.
 FETCH  Fetching origin/master...
Usage Exception: There are no commits on "remove-unused-includes" which are not already present on the target.

It looks like you already pushed it? https://cgit.kde.org/dolphin.git/commit/?id=848abc5922167a467bb73107ee6b72e9af3c8317

Exactly what i was going to type :)

Can somebody land it for me? I have some problems:

$ arc land
Landing current branch 'remove-unused-includes'.
 TARGET  Landing onto "master", the default target under git.
 REMOTE  Using remote "origin", the default remote under git.
 FETCH  Fetching origin/master...
Usage Exception: There are no commits on "remove-unused-includes" which are not already present on the target.

In D10990#217450, @ngraham wrote:

@rominf how about "Show Original" instead of "Open symlink destination folder". Let's try to use more natural, less nerdy terminology here.

Fixed.

In D10990#217438, @markg wrote:

I'm not so sure if this is a feature worth having.
Dolphin also works under windows, it doesn't know symlinks (something like it, yes, but it's not a symlink as it is under linux).

Also, is it worth exposing that technical detail (symlink is quite technical) to the user?
Is a good solid reason for having this? Or would this just satisfy a edge case used by very few people (if ever)?

Suppose I have file A and symlink B -> A. I want to copy file A to the FAT formatted flash drive using symlink B. I get an error because FAT doesn't support symlinks. Ooops... Leaked abstraction.

Add braces

Fixed comments

• Fix indentation

Rebase on master

Remove unused #include

Remove unused #include

• Fix crash on Dolphin closing

• Grammar

In D10961#217070, @ngraham wrote:

Works as advertised, and doesn't conflict with any default shortcuts. The whole "type / to quick search/filter" is pretty well established in web browsers nowadays. Makes sense to have it in Dolphin, too.

Konsole still eats it when its panel is open, but it also eats the other ctrl+I shortcut even without this patch, so that seems like another bug (and down the rabbit hole we go...)

It might be nice to take the opportunity to modernize the syntax for the existing shortcut here, replacing the | with a + for readability, since you're touching that code anyway.

Done

• Modernize the syntax of shortcut

In D10960#217036, @ngraham wrote:

Specifically:

• Close the Terminal pane and quit Dolphin [it won't crash]
• Open Dolphin
• Don't open the terminal pane
• Close Dolphin
  
  Boom, crash. You'll only see it if you never use the terminal pane (i.e. it would affect probably 90%+ of Dolphin's users :) )

In D10960#217033, @rkflx wrote:

In D10960#217029, @rominf wrote:

In D10960#217022, @rkflx wrote:

Sorry I comment mostly on what does not work yet ;), but for me Dolphin crashes on closing:

[KCrash Handler]
#6  0x00007fbb2a4c08f6 in TerminalPanel::isAnyProgramRunning() const ()

I assume you are not simply submitting totally untested patches, but I'm not sure what I'm doing wrong…

Cannot reproduce. Can you please provide me the steps?

Open Dolphin, close Dolphin.

In D10960#217022, @rkflx wrote:

Sorry I comment mostly on what does not work yet ;), but for me Dolphin crashes on closing:

[KCrash Handler]
#6  0x00007fbb2a4c08f6 in TerminalPanel::isAnyProgramRunning() const ()

I assume you are not simply submitting totally untested patches, but I'm not sure what I'm doing wrong…

• Swap MoveToTrash and EmptyTrash in code

• Fix i18n

• Fix grammar

In D10959#216901, @ngraham wrote:

The de-focus doesn't quite work for me; the terminal does correctly lose focus, but it isn't clearly moved anywhere else.

• Make Focus Terminal correctly de-focus

In D10959#216883, @rkflx wrote:

In D10959#216881, @rominf wrote:

It moves focus to the previously activated widget.

Correct, but as URL bar and main viewport are a single widget, in most cases it will not do what I believe users will expect it should do. Normally you navigate in the main view, then open the terminal, then navigate some more. Focussing the URL bar in that case is not helpful. Perhaps when this widget gets focus, it should default to the main view and not the URL bar? You might want to look into that.

actually this variant was implemented in the previous commit

Unless I missed something, your previous iteration had no unfocussing at all.

• Make action Focus Terminal unfocus terminal

In D10959#216880, @rkflx wrote:

Much better than before, but I think when moving the focus back from the Terminal, it should be in the main viewport and not in the URL bar (there are separate shortcuts for focussing that already).

It moves focus to the previously activated widget. It's not hard to focus on the main viewport (actually this variant was implemented in the previous commit), but I think this behavior is better.

• Move Confirm emptying trash checkbox below

@rkflx Ping. What do you think?

In D10959#216856, @rkflx wrote:

Another idea would be to make F4 open the Terminal if it was closed, and focus the Terminal if it was already open. This would be in line with standard behaviour for text-input widgets toggled by a keyboard shortcut (see also D10246#200226). Kate already has this behaviour: Set F4 for Focus Terminal, and you'll even have de-focus right there.

The only caveat would be that closing the Terminal would have to be done differently (Kate also has this problem), but I guess Terminal users know about Ctrl+D? Or we could always show the Close button? Or the menu entry is enough?

Nope. I'm against changing the behaviour of F4. There could be some running application opened in the panel (watch ls for example). That means that Ctrl+D is not longer an option. Showing the Close button is not an option too because it's inconsistent with other panels (I mean when the panels are locked).

• Unfocus on Focus Terminal action if terminal panel is already focused

• Show terminal panel on Focus Terminal action

In D10960#216698, @broulik wrote:

Good idea! When I just close the Terminal panel (press F4) the console keeps running, right?