src/dolphinmainwindow.cpp
1052	I'd actually prefer to get rid of harcoded shortcuts where possible. For example here we should use whatever default shortcut the user set in systemsettings for the New action, rather than manually hardcoding CTRL+N.

Ha, funny. I didn't even know there was an old syntax for this. I've always used the + syntax.
I ran it and it seems to be working just fine (just tested a few shortcuts, not all).

src/dolphinmainwindow.cpp
1052	I agree, but this commit seems focused on refactoring to this + format style. Lets keep the global system defined shortcuts for another commit.

This revision is now accepted and ready to land.Mar 3 2018, 12:18 PM

rominf marked 2 inline comments as done.Mar 3 2018, 1:43 PM

Closed by commit R318:32bd8efc7f08: Modernize the syntax of shortcuts (authored by rominf). · Explain WhyMar 3 2018, 1:44 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			src/dolphinmainwindow.cpp (22 lines)
M			src/dolphinpart.cpp (6 lines)
M			src/panels/information/filemetadataconfigurationdialog.cpp (2 lines)
M			src/settings/additionalinfodialog.cpp (2 lines)
M			src/settings/general/configurepreviewplugindialog.cpp (2 lines)
M			src/settings/viewpropertiesdialog.cpp (2 lines)
M			src/views/dolphinviewactionhandler.cpp (6 lines)
M			src/views/renamedialog.cpp (2 lines)