In that case, accepting :-). I totally forgot subject of this patch, sorry about that.

I've found one problem corner case with bookmark folders:

1. say we have these bookmarks:
   1. work (bookmark folder)
   2. downloads (bookmark)
   3. documents (bookmark)
2. open bookmarks (ctrl+d)
3. type "w" to activate a bookmark folder "work"
4. press esc to close the folder submenu
5. press "d"

Thanks! Krusader is still working just fine:).

If you have write access, you can push it to git directly. Otherwise let me know, I can push it for you with your name as the original author :).

Thanks you all for testing :). Davide, thanks for testing zip:/ protocol, I've total forgot about that.

Thanks for working in the code comments and the docs about setDefaultWidget - I wasn't aware of that. Accepting :). Sorry for my late response.

Hi! After this commit I don't see a completion dropdown anymore. And after it should be opened and one presses backspace, kate or kwrite crashes. Simple example:

1. open empty Kate
2. write "aaaa", enter, "aaaa", backspace

Perfect, thanks!

Nicely done, Nikita!

Nikita, Toni, Yuri, big thanks for testing! :)

Nikita, Toni, thanks a lot for checking and testing! :)

Good idea, thanks!

Thanks for taking the time to think about this.

Firstly, thanks for your effort!

Nikita, thanks for code review! I've adjusted the code to respect your proposed changes.

Oh, I didn't know about KF5 coding style, thanks! It looks indeed similar to the "kdelibs" one.

Thanks Rade for the great progress and Nikita for proper review!

Thanks, Nikita, for fixing the crash! Nice work :).

Thanks, Rade, for submitting your patch here! I'm really looking forward to this feature.

Thanks for code review, Nikita :). I'm updating the diff - worked in your suggestions and rebased to master.

In this case I meant thanks mainly to Toni :). I'm probably i bit tired...

Good idea, Yuri, thanks!

Thanks, Davide, for taking care of older setups!

Thanks, Nikita, for your remarks! I have worked them in and I will push the changes right away.

Thanks!

One more small update - fix include order.

Thanks, Toni, for testing the patch and the pretty good idea to change colon to space!

Thanks, Nikita, for making this work!

Works nicely on Arch Linux. Thanks Davide! :)

In my opinion, the ideal solution would be something like per-icon fallback logic.

I spent some time to investigate this idea but it looks like a quite difficult task so far. One can set QIcon or QPixmap to buttons, tabs and other widgets. In case of QPixmap one you paint whatever you want. So you can query if icon exists and if it doesn't, set a different theme and create the icon from that. But you need to know its size and it is fixed since the creation. You sometimes probably want the application to decide the size dynamically, but I'm not sure about that. Also when system wide setting of icon theme changes, your pixmaps are not repainted. QIcon on the other hand is dynamic - widgets will paint them how they want and they will change when system-wide icon theme is changed.

Updating diff. This is the one attached previously as exclude-folder-names-02.diff.

I'll update the diff here so the flow here can be properly finished.

Thank you both for informative answers!

Add Tab Pinning Feature - fix tab duplication. I have also removed a few commented lines of code from panelmanager. The diff update is rebased to current master.

Sorry, arcanist error from my side. Please don't read this one :).

Please go with 3 or at most 2b.

Works nicely. Thanks! :)

thanks!

Thanks for fixing my code! :)

Thanks a lot for your feedback. @andreask, thanks for the icon addition and maintenance of oxygen and breeze!

-Thanks, Toni, for trying it out! :-) I believe that cmake is installing into /user/local by default no matter KDE_INSTALL_USE_QT_SYS_PATHS is set or not. At least on Arch Linux it works out like that. Only after setting -DCMAKE_INSTALL_PREFIX=... the install prefix get changed. And that is persisted even if next cmake call is performed without this switch. Best practice for me is cleaning up build folder before calling cmake to have a predictable results. Again, it works like that in Arch Linux with cmake version 3.10.2, I'm not sure if other distributions behave the same.

It looks OK to me. I haven't found any issues when testing your change. Thanks a lot for your code! :)

Hi Nikita, first of all: thanks for your code! :-)

It should work. I've tested it in Arch Linux and also on git Plasma. Although there is no stable release of this widget in kde repos, yet. Did you try git version? What distro you are on?

This is a first proposal for forcing Breeze theme like we discussed here:
https://bugs.kde.org/show_bug.cgi?id=372964

During today I've found an issue: duplicating pinned tab (when its address is already temporarily changed) will result in a new tab with pinned address of the source tab instead of the current address. On top of that source tab gets changed title to its current address - this should never happen. I'll fix that and update the diff. Please wait :).

Diff updated to show a waring if CMAKE_INSTALL_PREFIX is not standard with a hint how to force installing plugins to standard location.

If I understand correctly, the last diff (exclude-folder-names-02.diff) can be committed and pushed.

Hi, Alex. Thanks for giving it a go!

Thanks for the lot of good info!

Hello! Have you, Martin, or anybody else tried the last diff? Is this the right approach to the problem? I've been using it since and technically there were no crashes with my use-cases.