Allow opening MountMan from Tools menu. Also the MountMan code was cleaned up in some places,
removed some unnecessary hacks and fix an issue with multiple
sorry message-boxes when a drive is (un)mounted unsuccessfully multiple times.
FIXED: [ 308351 ] Cannot run MountMan from menu
BUG: 308351
| No Linters Available |
| No Unit Test Coverage |
Martin, thanks for taking on the bug and the hacks in MountMan!
I just did the code review. Will test later.
| krusader/MountMan/kmountman.cpp | ||
|---|---|---|
| 443–448 | How about moving actData[0].toInt() out of lambda? Then "Unpacking" will be done in a single place after line 435. | |
| 448 | Why disconnect is within the lambda? I propose to move it to the body of delayedPerformAction. | |
| 463 | Thanks for removing the ugly hacks. | |
Nikita, thanks for code review! I've adjusted the code to respect your proposed changes.
Thank you, Martin! (and Nikita :-)! For my part, my performed tests (using Kubuntu 17.04) went alright. Other people can do their checks.
All works as expected (KF 5.32, Qt 5.6.2). Of course, needs some documentation tweaking which will be done when this patch is landed. :)
Nikita, Toni, Yuri, big thanks for testing! :)
I'm closing this manually since it was not triggered automatically by pushing.