Panel: searchbar improvements
ClosedPublic

Authored by nmel on Feb 11 2018, 1:29 AM.

Details

Summary

Three commits:

  1. Panel: quick navigation with right arrow when search bar is used

FIXED: [ 386217 ] Pressing Arrow keys behaves incorrectly in quicksearch
BUG: 386217

Fixes a usability regression introduced in 210ca94.

Checking if cursor is in the end of the line
is needed for the case a mouse is used to position the cursor.

  1. Konfigurator: added checkbox for Directory navigation with Right Arrow
  1. fixed the bug with no-match indication when only the current item matches in Quick Search

If you type search text in the search bar that matches exactly one item
and then press up or down, the search bar was turning red before this fix.

Test Plan

Follow discussion in the bug 386217.

Diff Detail

Repository
R167 Krusader
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
nmel requested review of this revision.Feb 11 2018, 1:29 AM
nmel created this revision.
martinkostolny accepted this revision.Feb 13 2018, 7:45 AM
martinkostolny added a subscriber: martinkostolny.

Hi Nikita, first of all: thanks for your code! :-)

I don't see any issues with this change. And from my testing it is working as it should. I also agree that the option should be on by default.

This revision is now accepted and ready to land.Feb 13 2018, 7:45 AM
nmel added a comment.Feb 14 2018, 5:43 AM

Thanks for reviewing and testing this code, Martin! I will land this commits shortly.

This revision was automatically updated to reflect the committed changes.