Pinned tab is a locked tab with temporarily changeable address. It resets to pinned address on tab reactivation.
This feature is inspired by Total Commander's Lock tab with changeable address.
Requested by several users. See krusader-users mailing list: https://groups.google.com/forum/#!topic/krusader-devel/wp05sopv1SU
I've simplified occasional parts of code and also added "lock" and "pin" icons to the tab context menu actions.
| No Linters Available |
| No Unit Test Coverage |
During today I've found an issue: duplicating pinned tab (when its address is already temporarily changed) will result in a new tab with pinned address of the source tab instead of the current address. On top of that source tab gets changed title to its current address - this should never happen. I'll fix that and update the diff. Please wait :).
Add Tab Pinning Feature - fix tab duplication. I have also removed a few commented lines of code from panelmanager. The diff update is rebased to current master.
Very solid code, Martin - thanks for your work!
I only reviewed the code. Planning to test the feature this week. IMO, it should be definitely included into the upcoming release.
| krusader/Panel/listpanel.h | ||
|---|---|---|
| 263 | Please move value initialization to constructor. | |
| krusader/actionsbase.cpp | ||
| 49 | It would be nice if you add () around new like on line 47. | |
| krusader/paneltabbar.cpp | ||
| 145 | I think this comment actually belongs to setPanelTextToTab in a modified form. At least, it's not relevant here - no direct logic related to pinned tabs. | |
Thanks for code review, Nikita :). I'm updating the diff - worked in your suggestions and rebased to master.
Thanks Martin! I just tested the feature - it works without a glitch. I'm happy that it will be a part of v2.7! Keep up a good work.
Thank you, Martin! (and Nikita :-)! For my part, my performed tests (using Kubuntu 17.10) went alright, including those already mentioned tests:
Other people can do their checks :-)
Nikita, Toni, thanks a lot for checking and testing! :)
I'm closing this manually since it was not triggered automatically by push.