| martinkostolny |
| Plasma |
On my setup the window label was 1px lower than global menu items (with Fill height enabled) which was very annoying.
I guess it was caused by some rounding error. This patch fixes it.
Old:
New:
(Red rectangle was added so the issue is easier to spot.)
Checked that window label is still vertically centered.
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
This disregards any descenders text might have, the previous approach was more technically correct.
Would it be better to move global menu 1px down instead?
--- a/package/contents/ui/AppMenu.qml +++ b/package/contents/ui/AppMenu.qml @@ -113,7 +113,10 @@ Item { PlasmaComponents.Label { id: appmenuButtonTitle - anchors.centerIn: appmenuButtonBackground + anchors.top: appmenuButtonBackground.top + anchors.bottom: appmenuButtonBackground.bottom + verticalAlignment: Text.AlignVCenter + anchors.horizontalCenter: appmenuButtonBackground.horizontalCenter font.pixelSize: fontPixelSize * plasmoid.configuration.appmenuButtonTextSizeScale text: activeMenu.replace('&', '') font.weight: appmenuFontBold ? Font.Bold : theme.defaultFont.weight
It also fixes the issue (although I liked the 1px higher a bit better in this specific case).
Anyway the root of the problem seems to be that each of them was centered in a different way.
Firstly, thanks for your effort!
I prefer the latter variant. The first proposed one proves Kai's warning because it broke multi-line title wrapping (e.g. if you have thicker panel).