LGTM now.
Please, wait for @kfunk's review.
- Queries
- All Stories
- Search
- Advanced Search
Feed Advanced Search
Advanced Search
Advanced Search
Dec 3 2016
Dec 3 2016
ematirov added inline comments to D3580: Investigate warnings and fix where it's possible and needed (kdevplatform) [1].
Hm... Did you test it?
Dec 2 2016
Dec 2 2016
Some nitpicks. :)
Feb 2 2016
Feb 2 2016
ematirov added inline comments to D894: Bug 358779 - dgml is missing an option center the map (lonlat).
Jan 15 2016
Jan 15 2016
Jan 14 2016
Jan 14 2016
ematirov retitled D822: Use ascending order by default in variables list from to Use ascending order by default in variables list.
Jan 11 2016
Jan 11 2016
ematirov committed R33:be735d44a5ad: Setup QCollator into ctor instead of lessThan. Also, remove unneeded includes. (authored by ematirov).
Setup QCollator into ctor instead of lessThan. Also, remove unneeded includes.
Setup QCollator into ctor instead of lessThan.
Jan 10 2016
Jan 10 2016
Fix copyright.
ematirov retitled D777: [GCI] Use natural sorting in variable list. from to [GCI] Use natural sorting in variable list..
Jan 9 2016
Jan 9 2016
ematirov updated the diff for D771: [GCI] Show warning in launch configuration if no execute plugins were enabled..
Remove unneeded newline change.
ematirov retitled D771: [GCI] Show warning in launch configuration if no execute plugins were enabled. from to [GCI] Show warning in launch configuration if no execute plugins were enabled..
Use existing RemoveLaunchConfiguration.
ematirov retitled D769: Remove related actions while removing LaunchConfigurationType. from to Remove related actions while removing LaunchConfigurationType..
Jan 8 2016
Jan 8 2016
Remove unneeded whitespace change
ematirov retitled D763: [GCI] Add "copy filename" action to context menu in tabs. from to [GCI] Add "copy filename" action to context menu in tabs..
ematirov retitled D761: [EnvironmentWidget] Add support for cloning existing environment. from to [EnvironmentWidget] Add support for cloning existing environment..
Jan 6 2016
Jan 6 2016
ematirov committed R33:02d8e5cec23b: Fix test. Due to latest change OutputWidget have 10 actions by default. (authored by ematirov).
Fix test. Due to latest change OutputWidget have 10 actions by default.
ematirov committed R33:f3bbf469f42c: [GCI] Add buttons "jump to first (last) item" to… (authored by ematirov).
[GCI] Add buttons "jump to first (last) item" to…
ematirov updated the diff for D750: [GCI] Add buttons "jump to first (last) item" to standardoutputview/outputwidget..
Fix coding style issues.
ematirov retitled D750: [GCI] Add buttons "jump to first (last) item" to standardoutputview/outputwidget. from to [GCI] Add buttons "jump to first (last) item" to standardoutputview/outputwidget..
Jan 3 2016
Jan 3 2016
Fix typo in astr2lib.cpp.
Jan 1 2016
Jan 1 2016
ematirov committed R114:819dbb8b960a: [WebBrowser plasmoid] Remember last visited url and restore it on startup. (authored by ematirov).
[WebBrowser plasmoid] Remember last visited url and restore it on startup.
Nov 24 2015
Nov 24 2015
ematirov committed R34:0ecfd8df9703: Do not use visual category from ways if ways have different visual categories. (authored by ematirov).
Do not use visual category from ways if ways have different visual categories.
Nov 15 2015
Nov 15 2015
ematirov set the repository for D505: Do not use visual category from ways if ways have different visual categories. to R34 Marble.
ematirov updated the diff for D505: Do not use visual category from ways if ways have different visual categories..
I meant that I don't understand which one color from your link you are suggesting.
Was pushed (probably I need to learn how to close reviews by commit message here...): https://phabricator.kde.org/rMARBLE5c4f0c43b1f6
ematirov committed R34:5c4f0c43b1f6: Do not fill AmenityArchaeologicalSite visual category with a color. (authored by ematirov).
Do not fill AmenityArchaeologicalSite visual category with a color.
Nov 5 2015
Nov 5 2015
In D504#9786, @nienhueser wrote:Color-wise I'd stick to what mapnik uses, see http://www.openstreetmap.org/node/365475871#map=17/41.88833/12.48854
ematirov updated the diff for D505: Do not use visual category from ways if ways have different visual categories..
ematirov retitled D505: Do not use visual category from ways if ways have different visual categories. from to Do not use visual category from ways if ways have different visual categories..
ematirov retitled D504: Change color and z-value of TouristAttraction visual category. from to Change color and z-value of TouristAttraction visual category..
ematirov retitled D503: Do not fill AmenityArchaeologicalSite visual category with a color. from to Do not fill AmenityArchaeologicalSite visual category with a color..