| nienhueser | |
| ematirov | |
| boriss |
Patch by Boris Shtrasman
Some custom map providers will not provide a maps for the entire world , but rather to a small area.
While there is a command line option to start marble to point to a location , it is not a feasible solution when requesting a non technical person to start with command line options (In addition to the need for asking a person to put files a directory)
| Lint Skipped |
| Unit Tests Skipped |
| src/apps/marble-kde/KdeMainWindow.cpp | ||
|---|---|---|
| 111 | Must also check that lonLat.size() is >1 (or ==2) Not needed if using GeoDataCoordinates instead of QVariantList, see below. Instead check lonLat.isValid() then. | |
| src/apps/marble-qt/QtMainWindow.cpp | ||
| 1634 | Can we move this method to ControlView (shared between the Qt and KDE applications) to avoid the code duplication? | |
| src/lib/marble/geodata/handlers/dgml/DgmlCenterTagHandler.cpp | ||
| 4 | Wrong license header, see above | |
| src/lib/marble/geodata/handlers/dgml/DgmlCenterTagHandler.h | ||
| 4 | Wrong license header, please copy and adapt from e.g. MarbleWidget.h | |
| src/lib/marble/geodata/scene/GeoSceneMap.h | ||
| 72 | I'd prefer having two methods:
| |
| 78 | This should be validated already, i.e. not return a QVariantList, but GeoDataCoordinates. GeoDataCoordinates::isValid() can be used to determine if a center has been set. | |