Differential D822

Use ascending order by default in variables list
ClosedPublic
Actions

Authored by ematirov on Jan 14 2016, 7:40 PM.

Details

Reviewers
kfunk
Commits
R32:2136e7927e41: Use ascending order by default in variables list
R33:2136e7927e41: Use ascending order by default in variables list
Summary

Fixes
BUG: 357969

Test Plan

Works as expected

Diff Detail

Repository
R33 KDevPlatform
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ematirov updated this revision to Diff 1963.Jan 14 2016, 7:40 PM
ematirov retitled this revision from to Use ascending order by default in variables list.
ematirov updated this object.
ematirov edited the test plan for this revision. (Show Details)
ematirov added a reviewer: kfunk.
ematirov set the repository for this revision to R33 KDevPlatform.
ematirov added a project: KDevelop.
ematirov added subscribers: KDevelop, kdevelop-devel.
kfunk added inline comments.Jan 14 2016, 8:35 PM
debugger/variable/variablewidget.cpp
173

First parameter to sortByColumn is a column, Qt::DisplayRole is a role though.

You probably want VariableCollection::NameColumn here.

ematirov updated this revision to Diff 1973.Jan 15 2016, 4:05 AM
kfunk accepted this revision.Jan 15 2016, 10:01 AM
kfunk edited edge metadata.
This revision is now accepted and ready to land.Jan 15 2016, 10:01 AM
Closed by commit R33:2136e7927e41: Use ascending order by default in variables list (authored by kfunk). · Explain WhyJan 15 2016, 10:01 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 1979

View Options

debugger/variable/variablewidget.cpp

Loading...