Differential D777

[GCI] Use natural sorting in variable list.
ClosedPublic
Actions

Authored by ematirov on Jan 10 2016, 7:13 PM.

Details

Reviewers
kfunk
Commits
R33:be735d44a5ad: Setup QCollator into ctor instead of lessThan. Also, remove unneeded includes.
R32:be735d44a5ad: Setup QCollator into ctor instead of lessThan. Also, remove unneeded includes.
R33:fa0d28c15edd: [GCI] Use natural sorting in variable list
R32:fa0d28c15edd: [GCI] Use natural sorting in variable list
Summary

Fixes
BUG: 119929

Test Plan

Tests passed and works as expected.

Diff Detail

Repository
R33 KDevPlatform
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ematirov updated this revision to Diff 1844.Jan 10 2016, 7:13 PM
ematirov retitled this revision from to [GCI] Use natural sorting in variable list..
ematirov updated this object.
ematirov edited the test plan for this revision. (Show Details)
ematirov added a reviewer: kfunk.
ematirov set the repository for this revision to R33 KDevPlatform.
ematirov added a project: KDevelop.
ematirov added a subscriber: KDevelop.
Restricted Application added a subscriber: kdevelop-devel. · View Herald TranscriptJan 10 2016, 7:13 PM
ematirov updated this revision to Diff 1845.Jan 10 2016, 7:25 PM

Fix copyright.

kfunk edited edge metadata.Jan 10 2016, 7:51 PM

Looks great, thanks!

debugger/variable/variablesortmodel.cpp
31

Nitpick: Indent this line

39

Also here, and everywhere else: No spaces inside (...)

40

const, same below

debugger/variable/variablesortmodel.h
31

Nitpick: No indent inside namespaces please

36

nullptr

ematirov updated this revision to Diff 1850.Jan 10 2016, 8:00 PM
ematirov edited edge metadata.
kfunk accepted this revision.Jan 10 2016, 8:11 PM
kfunk edited edge metadata.

LGTM. Thanks again, great work!

Will push.

This revision is now accepted and ready to land.Jan 10 2016, 8:11 PM
Closed by commit R33:fa0d28c15edd: [GCI] Use natural sorting in variable list (authored by ematirov, committed by kfunk). · Explain WhyJan 10 2016, 8:35 PM
This revision was automatically updated to reflect the committed changes.
mwolff reopened this revision.Jan 10 2016, 11:08 PM
mwolff added a subscriber: mwolff.
mwolff added inline comments.
debugger/variable/variablesortmodel.cpp
37

this patch must be revised: The QCollator setup is afaik not cheap, and thus must not be done repeatedly inside ::lessThan. Please make it a member variable and put the initialization into the ctor.

This revision is now accepted and ready to land.Jan 10 2016, 11:08 PM
ematirov updated this revision to Diff 1871.Jan 11 2016, 2:26 PM
ematirov edited edge metadata.

Setup QCollator into ctor instead of lessThan.

Thanks, good catch!

kfunk added a comment.Jan 11 2016, 2:48 PM

Store the member as value, not as pointer please.

Can you push to 5.0?

ematirov updated this revision to Diff 1873.Jan 11 2016, 3:06 PM
Closed by commit R33:be735d44a5ad: Setup QCollator into ctor instead of lessThan. Also, remove unneeded includes. (authored by ematirov). · Explain WhyJan 11 2016, 3:48 PM
This revision was automatically updated to reflect the committed changes.
mwolff added a comment.Jan 11 2016, 10:06 PM

Thanks for the fix, looks good now!

Revision Contents
Changeset List

Diff 1874

View Options

debugger/variable/variablesortmodel.h

Loading...
View Options

debugger/variable/variablesortmodel.cpp

Loading...