Thank you!

In D6316#121700, @brauch wrote:

Doesn't that become a problem when you extend the range during editing?

Oh, got it. Yeah, there is some problems with method declaration context if I don't update range. Syntax highlighting works fine but there is problems with code browsers, looks like it cannot find correct context by range. Updating range by currentContext()->setRange(editorFindRange(node, 0)); helps but I'm not sure that it's correct since there could be some other declarations not related to that type between type declaration and method declaration; although, looks like it works.

In D6316#121700, @brauch wrote:

No, I was thinking that the next block with the openContext(...) should automatically re-use the internalContext() of the declaration if that is indeed the same. In any case, when looking at it like this, don't you need to set the new range on the context? Doesn't that become a problem when you extend the range during editing?

Updated. Based on https://phabricator.kde.org/D6412 work. Now code highlighting works correctly too.

Thank you for your review!

Use review suggestion.

Yeah, looks like there is problem with reusing but not because of 2 runs - visitMethodDeclaration opens new declaration for type :-/
See code and resulting DU-Chain: https://paste.kde.org/pmjuqk7ld (declarations on lines 14 and 15)
I tried to:

If I do that inside

In D6316#119456, @brauch wrote:

I wonder -- is this the right place for that logic? Does it work in highlighting, for example?

In D5188#117158, @apol wrote:

What needs to happen to have this merged?

Add tests for loops.

Remove unneeded comment.

Set tool view for build job.
Add project files filter

In D5188#110166, @arrowdodger wrote:

In D5188#110152, @ematirov wrote:

There is no "project file" in Go, but specifying "*.go" as mimetype works perfect.

Doesn't Go has its own build system? This should serve as "project file", like Makefiles or CMakeLists.txt for C/C++.

In D5188#109400, @mwolff wrote:

Ping? I think other than the mimetype issue, this is OK to get merged. Do you have commit rights?

Fix review suggestions. Make folders of project buildable by right-clicking.
Suggestions about naming are welcome - I renamed folder to buildsystem but classes should have Go prefix I think, for easier debug \ etc. (It looks strange to make break BuildSystem::methodName without prefix IMHO). However, I'm not sure if files should contains that "Go" prefix.

LGTM, thanks.

LGTM!
Thanks, good work.

Thanks! Just some more nitpicks.