Differential D769

Remove related actions while removing LaunchConfigurationType.
ClosedPublic
Actions

Authored by ematirov on Jan 9 2016, 4:15 PM.

Details

Reviewers
kfunk
Commits
R32:f685cc8a92b0: Remove related actions while removing LaunchConfigurationType.
R33:f685cc8a92b0: Remove related actions while removing LaunchConfigurationType.
Summary

This is necessary because without that currentTargetAction will have actions which points to already deleted launch configuration which leads to crash.

Test Plan

Tests passed. Everything works as expected.

Diff Detail

Repository
R33 KDevPlatform
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ematirov updated this revision to Diff 1810.Jan 9 2016, 4:15 PM
ematirov retitled this revision from to Remove related actions while removing LaunchConfigurationType..
ematirov updated this object.
ematirov edited the test plan for this revision. (Show Details)
ematirov added a reviewer: kfunk.
ematirov added a subscriber: kdevelop-devel.
kfunk edited edge metadata.Jan 9 2016, 5:20 PM

There's RunController::removeLaunchConfiguration -- can't we reuse that?

I don't know a lot about that code either, to be fair...

kfunk added a comment.Jan 9 2016, 5:23 PM
In D769#14605, @kfunk wrote:

There's RunController::removeLaunchConfiguration -- can't we reuse that?

I don't know a lot about that code either, to be fair...

Ah, I think I see. RunController::removeLaunchConfiguration also removes things from the config; we probably don't want that when RunController::removeConfigurationType was called.

Please introduce a RunController::removeLaunchConfigurationInternal (which does *not* touch the config) which is called from RunController::removeLaunchConfiguration

ematirov updated this revision to Diff 1811.Jan 9 2016, 5:34 PM
ematirov edited edge metadata.

Use existing RemoveLaunchConfiguration.

ematirov updated this revision to Diff 1812.Jan 9 2016, 6:34 PM
kfunk accepted this revision.Jan 9 2016, 6:48 PM
kfunk edited edge metadata.

Perfect.

Looks fine to me.

This revision is now accepted and ready to land.Jan 9 2016, 6:48 PM
kfunk added a comment.Jan 9 2016, 6:48 PM

To 5.0 branch please; let me push if you cannot.

Closed by commit R33:f685cc8a92b0: Remove related actions while removing LaunchConfigurationType. (authored by ematirov, committed by kfunk). · Explain WhyJan 9 2016, 8:25 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mshell/runcontroller.h (1 line)
Mshell/runcontroller.cpp (17 lines)

Diff 1816

View Options

shell/runcontroller.h

Loading...
View Options

shell/runcontroller.cpp

Loading...