Differential D504

Change color and z-value of TouristAttraction visual category.
Needs ReviewPublic
Actions

Authored by ematirov on Nov 5 2015, 5:57 PM.

Details

Reviewers
None
Group Reviewers
Marble
Summary

Color is from image at http://wiki.openstreetmap.org/wiki/Tag:tourism%3Dattraction (File:Rendering-area-tourism-attraction.png)
Suggestions about correct color\z-value are very welcome.

Before:

and something like

After:

Place is 12° 29' 21.8"E, 41° 53' 21.0"N

Diff Detail

Repository
R34 Marble
Lint
Lint Skipped
Unit
Unit Tests Skipped
ematirov updated this revision to Diff 1180.Nov 5 2015, 5:57 PM
ematirov retitled this revision from to Change color and z-value of TouristAttraction visual category..
ematirov updated this object.
ematirov edited the test plan for this revision. (Show Details)
ematirov added a reviewer: Marble.
ematirov set the repository for this revision to R34 Marble.
ematirov added a project: Marble.
ematirov updated this object.Nov 5 2015, 6:03 PM
nienhueser added a subscriber: nienhueser.Nov 5 2015, 6:30 PM

Color-wise I'd stick to what mapnik uses, see http://www.openstreetmap.org/node/365475871#map=17/41.88833/12.48854

The z-values are a bit tricky right now. We'll have to do some refactoring in that regard: Distinguish between draw order and zValue and find an ordering approach that relies less on magic numbers. For the moment just use whatever seems to give good results.

ematirov added a comment.Nov 5 2015, 7:30 PM
In D504#9786, @nienhueser wrote:

Color-wise I'd stick to what mapnik uses, see http://www.openstreetmap.org/node/365475871#map=17/41.88833/12.48854

Sorry, I'm not sure that I understand exactly which color are you mean.

nienhueser added a comment.Nov 10 2015, 8:34 PM

I mean the color "Color is from image at http://wiki.openstreetmap.org/wiki/Tag:tourism%3Dattraction (File:Rendering-area-tourism-attraction.png)"

ematirov added a comment.Nov 15 2015, 9:32 AM

I meant that I don't understand which one color from your link you are suggesting.

nienhueser added a comment.Nov 22 2015, 1:58 PM

I didn't find it in osm-carto on a quick sight. Is it transparent maybe?

Revision Contents
Changeset List

Diff 1180

View Options

src/lib/marble/geodata/data/GeoDataFeature.cpp

Loading...
View Options

src/lib/marble/layers/GeometryLayer.cpp

Loading...