In D25811#587606, @cullmann wrote:Hi, can you add stuff to the tests or shall we merge this as is?
- Queries
- All Stories
- Search
- Advanced Search
Feed Advanced Search
Advanced Search
Advanced Search
Mar 8 2020
Mar 8 2020
Feb 22 2020
Feb 22 2020
Jan 6 2020
Jan 6 2020
turbov added a comment to D25811: cmake: Fix `CMAKE_POLICY_*_CMP<N>` regex and add special args to `get_cmake_property`.
Dec 8 2019
Dec 8 2019
Dec 2 2019
Dec 2 2019
turbov added a reviewer for D25686: Updates from CMake 3.16 final release: Framework: Syntax Highlighting.
Oct 11 2019
Oct 11 2019
Jul 24 2019
Jul 24 2019
@daandemeyer
Cool stuff! :))
Modern CMake has a recommendation to avoid variables when working w/ targets (google "Variables are fragile").
With a small modification to ki18n_wrap_ui (yeah, another project), it could be possible to replace this:
Jul 9 2019
Jul 9 2019
turbov retitled D22340: Update cmake highlighting from Bring some missed features to cmake: bring some missed features.
turbov committed R216:c8ce3a2b15d9: Improvement: Handle `CMAKE_ARGVn`, hightligh `$CACHE{...}` (authored by turbov).
Improvement: Handle `CMAKE_ARGVn`, hightligh `$CACHE{...}`
Jun 26 2019
Jun 26 2019
I would say all commands w/ COMMAND named parameter need that. Also, add_custrom_target and execute_process...
Jun 11 2019
Jun 11 2019
turbov committed R216:deeace3d6b30: CMake: Highlight the standard CMake environment variables (authored by turbov).
CMake: Highlight the standard CMake environment variables
Jun 5 2019
Jun 5 2019
CMake: Support for 3.15 features
Feb 13 2019
Feb 13 2019
cmake.xml: Updates for version 3.14
Oct 18 2018
Oct 18 2018
turbov committed R216:028e32bdabd9: CMake: Add XCode related variables and properties introduced in 3.13 (authored by turbov).
CMake: Add XCode related variables and properties introduced in 3.13
Oct 15 2018
Oct 15 2018
turbov committed R216:f814858d42d9: CMake: Introduce new features of upcoming 3.13 release (authored by turbov).
CMake: Introduce new features of upcoming 3.13 release
Sep 27 2018
Sep 27 2018
Good job!
Sep 26 2018
Sep 26 2018
I wonder why 3.0 has chosen as the minimum required? %) It was released zillion years ago... unlikely distros of that days would build KF5 stuff %)
Why not to choose smth fresh instead of the out of date version? (why no to start from ECM %)
Aug 14 2018
Aug 14 2018
Up to you... When I'll fix it for the cases I've found (trying to write the hightlighting.rst test file) I come back w/ a new PR :)
You can just close this MR, I'll be back sometime later w/ highlighting example and tests...
I'm using this syntax 'till nowadays from my repo... I know about some not covered cases in it, but have no time these days to improve it even more %)
Most of the time I quite satisfied w/ it... and sorry for the tests :(
I agree w/ relicense
Jun 28 2018
Jun 28 2018
turbov committed R216:50eb62eb0508: CMake: Fix highlighting after strings with a single `@` symbol (authored by turbov).
CMake: Fix highlighting after strings with a single `@` symbol
Jun 12 2018
Jun 12 2018
Improve CMake syntax
Jun 8 2018
Jun 8 2018
turbov committed R216:76db52f87f96: Update CMake syntax for the upcoming release 3.12. (authored by turbov).
Update CMake syntax for the upcoming release 3.12.
May 7 2018
May 7 2018
turbov committed R216:2ee1d5bb35b7: cmake: Fix DetectChar warning about escaped backslash #2 (authored by turbov).
cmake: Fix DetectChar warning about escaped backslash #2
Apr 1 2018
Apr 1 2018
Fix CMake highlighting tests
Mar 28 2018
Mar 28 2018
Redesign CMake syntax generator
Feb 11 2018
Feb 11 2018
Updates for CMake 3.11
Feb 7 2018
Feb 7 2018
In D7175#202300, @vkrause wrote:I'm with Christoph on this. Having the generated code checked in is fine, I'd like to avoid running this on compile time due to the extra dependencies.
turbov committed R40:f17e4c99b64e: Updates `Doxyfile` syntax for Doxygen 1.8.14 (authored by turbov).
Updates `Doxyfile` syntax for Doxygen 1.8.14
Feb 5 2018
Feb 5 2018
if there is no intereset, I'll close this review and will distribute my CMake syntax in other ways...
Nov 28 2017
Nov 28 2017
Nov 14 2017
Nov 14 2017
Yep, this review is the first in series about to clean up the code of FindPythongModuleGeneration and make it generic (not only for Ubuntu) and flexible.
It is why I want to clean up it from "hard-coded" values like 3.8/3.9 and "brute force" of any versions...
Nov 13 2017
Nov 13 2017
Nov 12 2017
Nov 12 2017
Updated for CMake 3.10
Oct 24 2017
Oct 24 2017
Include updates for CMake 3.10
Oct 23 2017
Oct 23 2017
Sep 18 2017
Sep 18 2017
In D7245#146719, @dhaumann wrote:@turbov ping
Aug 22 2017
Aug 22 2017
In D7175#138554, @dhaumann wrote:What is still unclear to me: As I understand we from time to time run the generator script (point 2 in my list). So this is not automatically run when executing "make", right?
Aug 18 2017
Aug 18 2017
Remove spaces around <item>
Aug 11 2017
Aug 11 2017
Make code block :: works as again as expected
Fix attribute name
Aug 7 2017
Aug 7 2017
In D7175#133152, @dhaumann wrote:I see seveal issues that imo should be addressed:
- Please add a test case in autotest/input/ or extend it if one already exists (did you run make test?)
turbov added reviewers for D7175: Redesign CMake syntax: dhaumann, Kate, Framework: Syntax Highlighting.
Apr 12 2017
Apr 12 2017
my 2 cents: