turbov (Alex Turbov)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Apr 12 2017, 2:43 PM (131 w, 3 d)
Availability
Available

Recent Activity

Fri, Oct 11

turbov requested review of D24575: Updates from CMake 3.16.
Fri, Oct 11, 9:01 PM

Jul 24 2019

turbov added inline comments to D22698: Support passing target to ki18n_wrap_ui macro.
Jul 24 2019, 7:00 PM · Frameworks
turbov added a comment to D22698: Support passing target to ki18n_wrap_ui macro.

@daandemeyer
Cool stuff! :))

Jul 24 2019, 6:58 PM · Frameworks
turbov added a comment to D22721: Clean up Kate addons CMake scripts..

Modern CMake has a recommendation to avoid variables when working w/ targets (google "Variables are fragile").
With a small modification to ki18n_wrap_ui (yeah, another project), it could be possible to replace this:

Jul 24 2019, 6:34 PM · Kate
turbov added inline comments to D22721: Clean up Kate addons CMake scripts..
Jul 24 2019, 5:42 PM · Kate

Jul 9 2019

turbov retitled D22340: Update cmake highlighting from Bring some missed features to cmake: bring some missed features.
Jul 9 2019, 1:46 PM · Frameworks, Kate
turbov requested review of D22340: Update cmake highlighting.
Jul 9 2019, 1:44 PM · Frameworks, Kate
turbov committed R216:c8ce3a2b15d9: Improvement: Handle `CMAKE_ARGVn`, hightligh `$CACHE{...}` (authored by turbov).
Improvement: Handle `CMAKE_ARGVn`, hightligh `$CACHE{...}`
Jul 9 2019, 1:42 PM

Jun 26 2019

turbov added a comment to D22095: Fix CMake COMMAND nested paren highlighting.

I would say all commands w/ COMMAND named parameter need that. Also, add_custrom_target and execute_process...

Jun 26 2019, 8:15 AM · Frameworks, Framework: Syntax Highlighting, Kate

Jun 11 2019

turbov committed R216:deeace3d6b30: CMake: Highlight the standard CMake environment variables (authored by turbov).
CMake: Highlight the standard CMake environment variables
Jun 11 2019, 12:56 PM

Jun 5 2019

turbov committed R216:5c5f3e397085: CMake: Support for 3.15 features (authored by turbov).
CMake: Support for 3.15 features
Jun 5 2019, 6:14 PM

Feb 13 2019

turbov committed R216:b8dd12219198: cmake.xml: Updates for version 3.14 (authored by turbov).
cmake.xml: Updates for version 3.14
Feb 13 2019, 7:23 AM

Oct 18 2018

turbov committed R216:028e32bdabd9: CMake: Add XCode related variables and properties introduced in 3.13 (authored by turbov).
CMake: Add XCode related variables and properties introduced in 3.13
Oct 18 2018, 11:31 AM

Oct 15 2018

turbov committed R216:f814858d42d9: CMake: Introduce new features of upcoming 3.13 release (authored by turbov).
CMake: Introduce new features of upcoming 3.13 release
Oct 15 2018, 3:21 PM

Sep 27 2018

turbov accepted D15780: YAML: add literal & folded block styles.

Good job!

Sep 27 2018, 12:31 AM · Frameworks, Kate

Sep 26 2018

turbov added a comment to D15761: ECM requires CMake 3.0.

I wonder why 3.0 has chosen as the minimum required? %) It was released zillion years ago... unlikely distros of that days would build KF5 stuff %)
Why not to choose smth fresh instead of the out of date version? (why no to start from ECM %)

Sep 26 2018, 10:51 AM · Kate

Aug 14 2018

turbov added a comment to D7245: Improve reStructuredText highlighting.

Up to you... When I'll fix it for the cases I've found (trying to write the hightlighting.rst test file) I come back w/ a new PR :)

Aug 14 2018, 9:32 PM · Frameworks
turbov added a comment to D7245: Improve reStructuredText highlighting.

You can just close this MR, I'll be back sometime later w/ highlighting example and tests...

Aug 14 2018, 2:02 PM · Frameworks
turbov added a comment to D7245: Improve reStructuredText highlighting.

I'm using this syntax 'till nowadays from my repo... I know about some not covered cases in it, but have no time these days to improve it even more %)
Most of the time I quite satisfied w/ it... and sorry for the tests :(

Aug 14 2018, 2:00 PM · Frameworks
turbov accepted D14824: Relicense modelines.xml to MIT license.

I agree w/ relicense

Aug 14 2018, 12:07 PM · Frameworks, Kate

Jun 28 2018

turbov committed R216:50eb62eb0508: CMake: Fix highlighting after strings with a single `@` symbol (authored by turbov).
CMake: Fix highlighting after strings with a single `@` symbol
Jun 28 2018, 11:39 AM

Jun 12 2018

turbov committed R216:27f785eae5fa: Improve CMake syntax (authored by turbov).
Improve CMake syntax
Jun 12 2018, 10:08 PM

Jun 8 2018

turbov committed R216:76db52f87f96: Update CMake syntax for the upcoming release 3.12. (authored by turbov).
Update CMake syntax for the upcoming release 3.12.
Jun 8 2018, 7:40 PM

May 7 2018

turbov committed R216:2ee1d5bb35b7: cmake: Fix DetectChar warning about escaped backslash #2 (authored by turbov).
cmake: Fix DetectChar warning about escaped backslash #2
May 7 2018, 11:35 AM

Apr 1 2018

turbov committed R216:1650807f7c6d: Fix CMake highlighting tests (authored by turbov).
Fix CMake highlighting tests
Apr 1 2018, 11:26 PM

Mar 28 2018

turbov committed R216:85a3315e51bb: Redesign CMake syntax generator (authored by turbov).
Redesign CMake syntax generator
Mar 28 2018, 7:43 PM

Feb 11 2018

turbov updated the diff for D7175: Redesign CMake syntax.

Updates for CMake 3.11

Feb 11 2018, 2:39 PM · Frameworks

Feb 7 2018

turbov added a comment to D7175: Redesign CMake syntax.

I'm with Christoph on this. Having the generated code checked in is fine, I'd like to avoid running this on compile time due to the extra dependencies.

Feb 7 2018, 9:37 AM · Frameworks
turbov committed R40:f17e4c99b64e: Updates `Doxyfile` syntax for Doxygen 1.8.14 (authored by turbov).
Updates `Doxyfile` syntax for Doxygen 1.8.14
Feb 7 2018, 4:49 AM

Feb 5 2018

turbov added a comment to D7175: Redesign CMake syntax.

if there is no intereset, I'll close this review and will distribute my CMake syntax in other ways...

Feb 5 2018, 5:40 AM · Frameworks

Nov 28 2017

turbov added a comment to D7175: Redesign CMake syntax.

ping

Nov 28 2017, 8:34 PM · Frameworks
turbov updated the diff for D7175: Redesign CMake syntax.
Nov 28 2017, 8:31 PM · Frameworks

Nov 14 2017

turbov added a comment to D8780: Try `llvm-config` to find `libclang`.

Yep, this review is the first in series about to clean up the code of FindPythongModuleGeneration and make it generic (not only for Ubuntu) and flexible.
It is why I want to clean up it from "hard-coded" values like 3.8/3.9 and "brute force" of any versions...

Nov 14 2017, 11:59 AM · Build System, Frameworks
turbov added inline comments to D8780: Try `llvm-config` to find `libclang`.
Nov 14 2017, 12:22 AM · Build System, Frameworks

Nov 13 2017

turbov created D8780: Try `llvm-config` to find `libclang`.
Nov 13 2017, 12:49 AM · Build System, Frameworks

Nov 12 2017

turbov updated the diff for D7175: Redesign CMake syntax.

Updated for CMake 3.10

Nov 12 2017, 12:39 PM · Frameworks

Oct 24 2017

turbov updated the diff for D7175: Redesign CMake syntax.

Include updates for CMake 3.10

Oct 24 2017, 12:06 AM · Frameworks

Oct 23 2017

turbov updated the diff for D7175: Redesign CMake syntax.
Oct 23 2017, 11:59 PM · Frameworks

Sep 18 2017

turbov added a comment to D7245: Improve reStructuredText highlighting.

@turbov ping

Sep 18 2017, 9:34 PM · Frameworks

Aug 22 2017

turbov added a comment to D7175: Redesign CMake syntax.

What is still unclear to me: As I understand we from time to time run the generator script (point 2 in my list). So this is not automatically run when executing "make", right?

Aug 22 2017, 8:12 PM · Frameworks

Aug 18 2017

turbov updated the diff for D7175: Redesign CMake syntax.

Remove spaces around <item>

Aug 18 2017, 6:48 AM · Frameworks
turbov updated the diff for D7245: Improve reStructuredText highlighting.
Aug 18 2017, 6:41 AM · Frameworks

Aug 11 2017

turbov updated the diff for D7245: Improve reStructuredText highlighting.

Make code block :: works as again as expected

Aug 11 2017, 4:55 AM · Frameworks
turbov updated the diff for D7245: Improve reStructuredText highlighting.

Fix attribute name

Aug 11 2017, 4:49 AM · Frameworks
turbov created D7245: Improve reStructuredText highlighting.
Aug 11 2017, 4:46 AM · Frameworks

Aug 7 2017

turbov added a comment to D7175: Redesign CMake syntax.

I see seveal issues that imo should be addressed:

  1. Please add a test case in autotest/input/ or extend it if one already exists (did you run make test?)
Aug 7 2017, 12:32 PM · Frameworks
turbov added reviewers for D7175: Redesign CMake syntax: dhaumann, Kate, Framework: Syntax Highlighting.
Aug 7 2017, 6:26 AM · Frameworks
turbov created D7175: Redesign CMake syntax.
Aug 7 2017, 6:20 AM · Frameworks

Apr 12 2017

turbov added a comment to D5338: Add syntax highlighting file for Doxyfile.

my 2 cents:

Apr 12 2017, 2:51 PM · Frameworks