In D25811#587606, @cullmann wrote:

Hi, can you add stuff to the tests or shall we merge this as is?

@daandemeyer
Cool stuff! :))

Modern CMake has a recommendation to avoid variables when working w/ targets (google "Variables are fragile").
With a small modification to ki18n_wrap_ui (yeah, another project), it could be possible to replace this:

I would say all commands w/ COMMAND named parameter need that. Also, add_custrom_target and execute_process...

Good job!

I wonder why 3.0 has chosen as the minimum required? %) It was released zillion years ago... unlikely distros of that days would build KF5 stuff %)
Why not to choose smth fresh instead of the out of date version? (why no to start from ECM %)

Up to you... When I'll fix it for the cases I've found (trying to write the hightlighting.rst test file) I come back w/ a new PR :)

You can just close this MR, I'll be back sometime later w/ highlighting example and tests...

I'm using this syntax 'till nowadays from my repo... I know about some not covered cases in it, but have no time these days to improve it even more %)
Most of the time I quite satisfied w/ it... and sorry for the tests :(

I agree w/ relicense

Updates for CMake 3.11

In D7175#202300, @vkrause wrote:

I'm with Christoph on this. Having the generated code checked in is fine, I'd like to avoid running this on compile time due to the extra dependencies.

if there is no intereset, I'll close this review and will distribute my CMake syntax in other ways...

ping

Yep, this review is the first in series about to clean up the code of FindPythongModuleGeneration and make it generic (not only for Ubuntu) and flexible.
It is why I want to clean up it from "hard-coded" values like 3.8/3.9 and "brute force" of any versions...

Updated for CMake 3.10

Include updates for CMake 3.10

In D7245#146719, @dhaumann wrote:

@turbov ping

In D7175#138554, @dhaumann wrote:

What is still unclear to me: As I understand we from time to time run the generator script (point 2 in my list). So this is not automatically run when executing "make", right?

Remove spaces around <item>

Make code block :: works as again as expected

Fix attribute name

In D7175#133152, @dhaumann wrote:

I see seveal issues that imo should be addressed:

1. Please add a test case in autotest/input/ or extend it if one already exists (did you run make test?)

my 2 cents: