cmake: Fix `CMAKE_POLICY_*_CMP<N>` regex and add special args to `get_cmake_property`
ClosedPublic

Authored by turbov on Dec 8 2019, 3:03 PM.

Diff Detail

Repository
R216 Syntax Highlighting
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
turbov created this revision.Dec 8 2019, 3:03 PM
Restricted Application added projects: Kate, Frameworks. · View Herald TranscriptDec 8 2019, 3:03 PM
Restricted Application added subscribers: kde-frameworks-devel, kwrite-devel. · View Herald Transcript
turbov requested review of this revision.Dec 8 2019, 3:03 PM

Nice that you take care of that stuff.
Could you enhance the CMake test file, too, to cover some of the new stuff?

Hi, can you add stuff to the tests or shall we merge this as is?

turbov added a comment.Mon, Jan 6, 1:43 PM

Hi, can you add stuff to the tests or shall we merge this as is?

Sorry, I don't have time for this nowadays %(

Ok, then let's merge as is.
Thanks for the improvement (+ happy new year).

cullmann accepted this revision.Mon, Jan 6, 1:50 PM
This revision is now accepted and ready to land.Mon, Jan 6, 1:50 PM
This revision was automatically updated to reflect the committed changes.