Feed Advanced Search

Apr 21 2018

apol committed R162:082c0f506987: I updated gpgme.json on flatpak-kde-applications, probably applies here too (authored by apol).
I updated gpgme.json on flatpak-kde-applications, probably applies here too
Apr 21 2018, 2:14 PM
apol committed R162:6d671661e47f: I updated gpgme.json on flatpak-kde-applications, probably applies here too (authored by apol).
I updated gpgme.json on flatpak-kde-applications, probably applies here too
Apr 21 2018, 2:14 PM
apol closed D12367: I updated gpgme.json on flatpak-kde-applications, probably applies here too.
Apr 21 2018, 2:14 PM
apol committed R256:d8f5560c4884: Fix weird typo (authored by apol).
Fix weird typo
Apr 21 2018, 2:14 PM
apol updated the diff for D12367: I updated gpgme.json on flatpak-kde-applications, probably applies here too.

oops

Apr 21 2018, 2:14 PM
apol abandoned D12411: I updated gpgme.json on flatpak-kde-applications, probably applies here too.
Apr 21 2018, 2:13 PM
apol requested review of D12411: I updated gpgme.json on flatpak-kde-applications, probably applies here too.
Apr 21 2018, 2:11 PM
apol added a comment to D12367: I updated gpgme.json on flatpak-kde-applications, probably applies here too.

Assuming setting the sha256 to a name is a thing now?

Thanks for the patch!

Apr 21 2018, 2:10 PM

Apr 20 2018

apol added a reverting change for R857:2baa5c2b6e71: Android: Backport verbosity patch to androiddeployqt: R857:d0beb8dd4d83: Revert "Android: Backport verbosity patch to androiddeployqt".
Apr 20 2018, 4:02 PM
apol committed R857:d0beb8dd4d83: Revert "Android: Backport verbosity patch to androiddeployqt" (authored by apol).
Revert "Android: Backport verbosity patch to androiddeployqt"
Apr 20 2018, 4:02 PM
apol committed R899:753b88e4f5ac: Only link against kirigami if we are using the local kirigami clone (authored by apol).
Only link against kirigami if we are using the local kirigami clone
Apr 20 2018, 3:05 PM
apol closed D12382: Only link against kirigami if we are using the local kirigami clone.
Apr 20 2018, 3:04 PM
apol requested review of D12382: Only link against kirigami if we are using the local kirigami clone.
Apr 20 2018, 2:42 PM
apol committed R857:2940359c7f3c: Android: Include build-poppler script in the image (authored by apol).
Android: Include build-poppler script in the image
Apr 20 2018, 2:41 PM
apol committed R857:2baa5c2b6e71: Android: Backport verbosity patch to androiddeployqt (authored by apol).
Android: Backport verbosity patch to androiddeployqt
Apr 20 2018, 2:41 PM
apol requested changes to D12371: Don't redirect smb:/ to smb:// and then to smb:///.

^^' this won't work though. If the object gets deleted you will get a null pointer in the list.

Apr 20 2018, 12:35 PM · Frameworks
apol accepted D12370: Move gnome integration plugins back to runtime repo.
Apr 20 2018, 9:29 AM
apol added inline comments to D12371: Don't redirect smb:/ to smb:// and then to smb:///.
Apr 20 2018, 9:27 AM · Frameworks
apol committed R256:3077451f7cc5: Update eigen, boost and openal (authored by apol).
Update eigen, boost and openal
Apr 20 2018, 12:37 AM
apol committed R256:c3ecb20439d7: Update GPG components versions (authored by apol).
Update GPG components versions
Apr 20 2018, 12:37 AM
apol requested review of D12367: I updated gpgme.json on flatpak-kde-applications, probably applies here too.
Apr 20 2018, 12:29 AM

Apr 19 2018

apol committed R993:a337ef36734a: Android: Specify empty dependency fields so they don't translate to "null" (authored by apol).
Android: Specify empty dependency fields so they don't translate to "null"
Apr 19 2018, 11:56 PM
apol closed D12366: Android: Specify empty dependency fields so they don't translate to "null".
Apr 19 2018, 11:56 PM
apol added a comment to D12331: Always use the clang builtin headers for the libclang version we use.
  • what compiler is used?

I'm using clang for all my projects.

Apr 19 2018, 11:37 PM
apol requested review of D12366: Android: Specify empty dependency fields so they don't translate to "null".
Apr 19 2018, 11:23 PM
apol updated the diff for D12352: Make it possible to disable the build of okularkirigami.

Improve description

Apr 19 2018, 11:00 PM · Okular
apol added a comment to T7205: create call for locations for Akademy 2019.

Here's an etherpad with @valorie's text and @derkits corrections: https://notes.kde.org/p/akademy-2019-callforlocations

Apr 19 2018, 10:47 PM · KDE e.V., Akademy
apol committed R495:8ff96619cab8: Make sure we give some vertical space to configuration plugins (authored by apol).
Make sure we give some vertical space to configuration plugins
Apr 19 2018, 4:46 PM
apol committed R495:f2c776a68813: Readability (authored by apol).
Readability
Apr 19 2018, 4:46 PM
apol committed R495:fd4f5dc800a4: Port KDEConnect plugin config to QQC2 (authored by apol).
Port KDEConnect plugin config to QQC2
Apr 19 2018, 4:46 PM
apol committed R495:87eaf5cc1c54: Port AlternativesView to QQC2 (authored by apol).
Port AlternativesView to QQC2
Apr 19 2018, 4:46 PM
apol committed R114:1d6d94de66b7: Merge branch 'Plasma/5.12' (authored by apol).
Merge branch 'Plasma/5.12'
Apr 19 2018, 3:00 PM
apol committed R114:45a25f05ad3e: Fix run-time warnings on quick-share (authored by apol).
Fix run-time warnings on quick-share
Apr 19 2018, 3:00 PM
apol requested review of D12352: Make it possible to disable the build of okularkirigami.
Apr 19 2018, 2:38 PM · Okular
apol committed R307:e7f6a6c547a4: Fix PersonSortFilterProxyModel filtering (authored by apol).
Fix PersonSortFilterProxyModel filtering
Apr 19 2018, 2:35 PM
apol committed R307:c277548fb9d7: Use QVector for internal data types (authored by apol).
Use QVector for internal data types
Apr 19 2018, 2:35 PM
apol added a comment to D12331: Always use the clang builtin headers for the libclang version we use.

It broke my system... It's looking for all classes in my projects into std::, failing and complaining about it. :'(

Apr 19 2018, 2:13 PM
apol committed R899:3bbe95d31e31: Fix fresh android build (authored by apol).
Fix fresh android build
Apr 19 2018, 12:53 PM
apol committed R899:c74eeceb54bf: Add .arcconfig for easier phabricator integration (authored by apol).
Add .arcconfig for easier phabricator integration
Apr 19 2018, 11:29 AM
apol committed R993:81bebfc12107: Add .arcconfig file to integrate to phabricator (authored by apol).
Add .arcconfig file to integrate to phabricator
Apr 19 2018, 11:09 AM
apol committed R993:1a8500d62836: Make it possible for pipelines to include a dependency (authored by apol).
Make it possible for pipelines to include a dependency
Apr 19 2018, 11:09 AM
apol closed D12304: Make it possible for pipelines to include a dependency.
Apr 19 2018, 11:09 AM
apol added a comment to D12331: Always use the clang builtin headers for the libclang version we use.

+1 from my side, I'm running it locally, didn't really have problems earlier don't seem to have them now. Will get back on the Android work and see how it works there soonish, but it's no reason to stop this patch, especially if it fixes bugs.

Apr 19 2018, 11:03 AM
apol committed R224:dd031d3debaf: Show the KCM with the run commands open when a setup packet is received (authored by apol).
Show the KCM with the run commands open when a setup packet is received
Apr 19 2018, 1:04 AM
apol closed D11684: Show the KCM with the run commands open when a setup packet is received.
Apr 19 2018, 1:04 AM · KDE Connect
apol updated the diff for D11684: Show the KCM with the run commands open when a setup packet is received.

Included Nico's patch

Apr 19 2018, 12:31 AM · KDE Connect
apol added a comment to D12251: Integrate with androiddeployqt dependencies files.

I don't really see why we need a special path for parts.

Apr 19 2018, 12:27 AM · Frameworks

Apr 18 2018

apol requested changes to D11854: (WIP) Upgrade Telephony plugin to read SMS history (KDE side).
Apr 18 2018, 11:20 PM · KDE Connect
apol committed R223:77049d3b80c2: Android: include metadata for okular kirigami (authored by apol).
Android: include metadata for okular kirigami
Apr 18 2018, 11:06 PM
apol closed D12299: Android: include metadata for okular kirigami.
Apr 18 2018, 11:06 PM · Okular
apol accepted D9691: Add contacts-reading plugin (KDE side).
Apr 18 2018, 10:44 PM · KDE Connect
apol added a comment to D9691: Add contacts-reading plugin (KDE side).

Patch looks good to me, I'd say let's merge it so we can start testing.

Apr 18 2018, 10:44 PM · KDE Connect
apol added a comment to D11136: Make sure we use the same compiler settings as the project is by default.

see also: https://bugs.kde.org/show_bug.cgi?id=387005

In that bug report we (presumably) get bitten by clang-5.0 (which is used for parsing) failing to understand clang-3.8 system headers (autodetected compiler).
I second @aaronpuchert - it would be better to remove support for other compilers than the one that is actually used for parsing.

Apr 18 2018, 12:35 PM
apol added a comment to T7994: Extract Qt Pulseaudio bindings into a Framework.

Hey, looking into it, context.h doesn't include pulse/volume.h.

Apr 18 2018, 12:31 PM · Plasma, KDE Connect, Frameworks
apol updated the diff for D12304: Make it possible for pipelines to include a dependency.

Address Ben's comment

Apr 18 2018, 12:18 PM
apol committed R857:38d40dac49a8: Android: Include helper scripts to build common dependencies (authored by apol).
Android: Include helper scripts to build common dependencies
Apr 18 2018, 11:57 AM
apol updated the diff for D12251: Integrate with androiddeployqt dependencies files.

Don't generate the xml file in the sources dir

Apr 18 2018, 11:56 AM · Frameworks
apol committed R169:d9a956de53ed: Fix build on Android (authored by apol).
Fix build on Android
Apr 18 2018, 11:35 AM
apol closed D12305: Fix build on Android.
Apr 18 2018, 11:35 AM · Kirigami
apol requested review of D12305: Fix build on Android.
Apr 18 2018, 11:09 AM · Kirigami
apol requested review of D12304: Make it possible for pipelines to include a dependency.
Apr 18 2018, 11:01 AM
apol committed R993:68ff61d5eba9: Add vvave for android (authored by apol).
Add vvave for android
Apr 18 2018, 10:59 AM
apol requested review of D12299: Android: include metadata for okular kirigami.
Apr 18 2018, 12:18 AM · Okular

Apr 17 2018

apol accepted D12264: Make bluetooth payload upload work & asynchronous.

Looks good to me, definitely a step forward.

Apr 17 2018, 10:56 PM · KDE Connect
apol committed R899:d5d445e72020: Remove unused directory (authored by apol).
Remove unused directory
Apr 17 2018, 4:51 PM
apol committed R899:0e5bf4814b94: Make it possible to build with cmake (authored by apol).
Make it possible to build with cmake
Apr 17 2018, 4:50 PM
apol closed D12286: Make it possible to build with cmake.
Apr 17 2018, 4:50 PM
apol committed R857:ee67cedc5c20: Android: Improve logic when it comes to several targets (authored by apol).
Android: Improve logic when it comes to several targets
Apr 17 2018, 4:45 PM
apol committed R857:aa924efd0ddf: Android: No need to have oxygen icons on every single application (authored by apol).
Android: No need to have oxygen icons on every single application
Apr 17 2018, 4:45 PM
apol committed R857:19e3a4e1b77f: Android: build-standalone shouldn't exit on error (authored by apol).
Android: build-standalone shouldn't exit on error
Apr 17 2018, 4:45 PM
apol committed R240:89fd1b3f39ea: Android: fix dumb mistakes (authored by apol).
Android: fix dumb mistakes
Apr 17 2018, 4:36 PM
apol committed R240:dbe4d2d7f9d6: Don't install plugins within lib on android (authored by apol).
Don't install plugins within lib on android
Apr 17 2018, 4:36 PM
apol closed D12269: Don't install plugins within lib on android.
Apr 17 2018, 4:36 PM · Build System, Frameworks
apol requested review of D12286: Make it possible to build with cmake.
Apr 17 2018, 4:33 PM
apol committed R242:49ef90bcb985: Don't show the background if Button.flat (authored by apol).
Don't show the background if Button.flat
Apr 17 2018, 11:47 AM
apol closed D11652: Don't show the background if Button.flat.
Apr 17 2018, 11:47 AM · Frameworks
apol added inline comments to D11684: Show the KCM with the run commands open when a setup packet is received.
Apr 17 2018, 11:41 AM · KDE Connect
apol requested changes to D12264: Make bluetooth payload upload work & asynchronous.

Small observations, looks really good!

Apr 17 2018, 11:36 AM · KDE Connect
apol requested review of D12269: Don't install plugins within lib on android.
Apr 17 2018, 2:48 AM · Build System, Frameworks
apol committed R240:29cb152b9b1f: Android: Make sure variable is defined before using it (authored by apol).
Android: Make sure variable is defined before using it
Apr 17 2018, 2:47 AM
apol updated the diff for D12250: Install okularpart with the rest of kparts.

The shell needs to know where the plugin is

Apr 17 2018, 2:43 AM · Okular
apol updated the diff for D12250: Install okularpart with the rest of kparts.

And another

Apr 17 2018, 12:15 AM · Okular
apol updated the diff for D12250: Install okularpart with the rest of kparts.

There's more desktop files pointing to okularpart

Apr 17 2018, 12:14 AM · Okular

Apr 16 2018

apol updated the diff for D12250: Install okularpart with the rest of kparts.

Unsure why it worked for me, point to the library like katepart does

Apr 16 2018, 7:04 PM · Okular
apol updated the diff for D12177: Make some frameworks optional so okular can be built on Android.

Oops

Apr 16 2018, 7:03 PM · Okular
apol updated the diff for D12177: Make some frameworks optional so okular can be built on Android.

Unsure why it works on my system, adopt the same way to point to the path katepart uses

Apr 16 2018, 7:01 PM · Okular
apol added a comment to D12249: Update knsrc to use kpackagetool5 commands.

+1

Apr 16 2018, 6:57 PM · KWin
apol committed R256:0fa537fca2d0: Drop wayland support (authored by apol).
Drop wayland support
Apr 16 2018, 6:53 PM
apol closed D12142: Drop wayland support.
Apr 16 2018, 6:53 PM
apol added a comment to T8529: Announce enbaled plugins to remote device.

Can you please distil this description into something readable?

Apr 16 2018, 6:52 PM · KDE Connect
apol added a comment to D11694: Add a dark theme.

Changing the header is out of scope for this patch and I would suggest doing it at least in a later patch.

Apr 16 2018, 6:52 PM · KDE Connect
apol added a comment to D12251: Integrate with androiddeployqt dependencies files.

Related and reason of albert's comment: https://phabricator.kde.org/D12250

Apr 16 2018, 5:36 PM · Frameworks
apol updated the diff for D12251: Integrate with androiddeployqt dependencies files.

Document installation process

Apr 16 2018, 5:35 PM · Frameworks
apol updated the diff for D12177: Make some frameworks optional so okular can be built on Android.

Shouldn't comment the include...

Apr 16 2018, 4:39 PM · Okular
apol updated the diff for D12177: Make some frameworks optional so okular can be built on Android.

Typo

Apr 16 2018, 4:37 PM · Okular
apol requested review of D12251: Integrate with androiddeployqt dependencies files.
Apr 16 2018, 4:35 PM · Frameworks
apol requested review of D12250: Install okularpart with the rest of kparts.
Apr 16 2018, 4:29 PM · Okular
apol updated the diff for D12177: Make some frameworks optional so okular can be built on Android.

Address Albert's concern

Apr 16 2018, 3:13 PM · Okular
apol committed R249:9c32bdab29b3: Don't need to run previous iterations commands again (authored by apol).
Don't need to run previous iterations commands again
Apr 16 2018, 1:12 PM
apol closed D12216: Don't need to run previous iterations commands again.
Apr 16 2018, 1:12 PM · Frameworks