- Queries
- All Stories
- Search
- Advanced Search
Advanced Search
Apr 21 2018
oops
In D12367#250464, @cmollekopf wrote:Assuming setting the sha256 to a name is a thing now?
Thanks for the patch!
Apr 20 2018
^^' this won't work though. If the object gets deleted you will get a null pointer in the list.
Apr 19 2018
- what compiler is used?
I'm using clang for all my projects.
Improve description
Here's an etherpad with @valorie's text and @derkits corrections: https://notes.kde.org/p/akademy-2019-callforlocations
It broke my system... It's looking for all classes in my projects into std::, failing and complaining about it. :'(
+1 from my side, I'm running it locally, didn't really have problems earlier don't seem to have them now. Will get back on the Android work and see how it works there soonish, but it's no reason to stop this patch, especially if it fixes bugs.
Included Nico's patch
I don't really see why we need a special path for parts.
Apr 18 2018
Patch looks good to me, I'd say let's merge it so we can start testing.
In D11136#248120, @mschwarz wrote:see also: https://bugs.kde.org/show_bug.cgi?id=387005
In that bug report we (presumably) get bitten by clang-5.0 (which is used for parsing) failing to understand clang-3.8 system headers (autodetected compiler).
I second @aaronpuchert - it would be better to remove support for other compilers than the one that is actually used for parsing.
Hey, looking into it, context.h doesn't include pulse/volume.h.
Address Ben's comment
Don't generate the xml file in the sources dir
Apr 17 2018
Looks good to me, definitely a step forward.
Small observations, looks really good!
The shell needs to know where the plugin is
And another
There's more desktop files pointing to okularpart
Apr 16 2018
Unsure why it worked for me, point to the library like katepart does
Oops
Unsure why it works on my system, adopt the same way to point to the path katepart uses
+1
Can you please distil this description into something readable?
Changing the header is out of scope for this patch and I would suggest doing it at least in a later patch.
Related and reason of albert's comment: https://phabricator.kde.org/D12250
Document installation process
Shouldn't comment the include...
Typo
Address Albert's concern