Differential D12304

Make it possible for pipelines to include a dependency
ClosedPublic
Actions

Authored by apol on Apr 18 2018, 11:01 AM.

Details

Reviewers
bcooksley
Group Reviewers
Sysadmin
Commits
R993:1a8500d62836: Make it possible for pipelines to include a dependency
Summary

For example in the case of okular, it needs building poppler first

Diff Detail

Repository
R993 Binary Factory Tooling
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
apol requested review of this revision.Apr 18 2018, 11:01 AM
apol created this revision.
bcooksley added a comment.Apr 18 2018, 11:04 AM

This is okay, however you'll also need to update dsl/android_jobs.groovy to ensure dependency is passed through.

Once that is done please make sure i'm around when you push this as changes to the Groovy scripts will require the approval of a Jenkins administrator before it will execute them.
(The Pipelines, Python scripts and JSON/YAML files elsewhere in binary-factory-tooling don't have this restriction - only the scripts in the dsl/ folder do, and it isn't something we can easily disable i'm afraid)

apol updated this revision to Diff 32464.Apr 18 2018, 12:18 PM

Address Ben's comment

bcooksley accepted this revision.Apr 19 2018, 10:26 AM

Thanks, looks perfect.

This revision is now accepted and ready to land.Apr 19 2018, 10:26 AM
Closed by commit R993:1a8500d62836: Make it possible for pipelines to include a dependency (authored by apol). · Explain WhyApr 19 2018, 11:09 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 32548

View Options

android/current-jobs.json

Loading...
View Options

android/generic-build.pipeline

Loading...
View Options

dsl/android_jobs.groovy

Loading...