Tell androiddeployqt where to look instead of just installing everything
Details
Details
- Reviewers
vkrause aacid - Group Reviewers
Frameworks
okularpart gets in okular apk when building okular apk
Diff Detail
Diff Detail
- Repository
- R306 KParts
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage
| src/part.h | ||
|---|---|---|
| 69 | "to be installed to be installed " <-- dupe | |
| 72 | I don't really see why we need a special path for parts. I understand you're doing it to be able to just get everything from that folder and then put it on the apk Now without knowing anything about cmake, wouldn't it make more sense put on the apk every single thing i'm installing? I mean if i do add_library(okularpart SHARED ${okularpart_SRCS})
install(TARGETS okularpart DESTINATION ${KDE_INSTALL_PLUGINDIR})it's surely because i'm interesting in having okularpart in my apk, otherwise why would i spend precious time compiling and installing it? | |
Comment Actions
I don't really see why we need a special path for parts.
I understand you're doing it to be able to just get everything from that folder and then put it on the apk
Now without knowing anything about cmake, wouldn't it make more sense put on the apk every single thing i'm installing?
I mean if i do
add_library(okularpart SHARED ${okularpart_SRCS})
install(TARGETS okularpart DESTINATION ${KDE_INSTALL_PLUGINDIR})
it's surely because i'm interesting in having okularpart in my apk, otherwise why would i spend precious time compiling and installing it?
That's not a bad point, I think having all plugins in the same subdirectory is a good idea because it simplifies the process of looking for them. Instead of having a complex cache such as sycoca that knows about all the desktop files, we can embed the plugin metadata in them. It's what we do with most plugin systems in KDE in fact, and we've ported some this way. It's not the case for all such as kparts.
Regarding pulling everything, I don't necessarily disagree, I already proposed it on D12172. I do agree though that having some kind of control over what goes in can be useful, especially if we can include this information.
In case you are curious, after building kf5 and okular (we are using kde-build-metadata information to bring dependencies which include kf5umbrella) these are the contents of the plugins folder:
/opt/kdeandroid-deps/plugins/kcm_webshortcuts.so /opt/kdeandroid-deps/plugins/kauth/helper/kauth_helper_plugin.so /opt/kdeandroid-deps/plugins/kcm_kio.so /opt/kdeandroid-deps/plugins/okular/generators/okularGenerator_comicbook.so /opt/kdeandroid-deps/plugins/okular/generators/okularGenerator_txt.so /opt/kdeandroid-deps/plugins/okular/generators/okularGenerator_ooo.so /opt/kdeandroid-deps/plugins/okular/generators/okularGenerator_dvi.so /opt/kdeandroid-deps/plugins/okular/generators/okularGenerator_fb.so /opt/kdeandroid-deps/plugins/okular/generators/okularGenerator_fax.so /opt/kdeandroid-deps/plugins/okular/generators/okularGenerator_xps.so /opt/kdeandroid-deps/plugins/krossmodulekdetranslation.so /opt/kdeandroid-deps/plugins/krossmoduleforms.so /opt/kdeandroid-deps/plugins/kf5/urifilters/localdomainurifilter.so /opt/kdeandroid-deps/plugins/kf5/urifilters/kuriikwsfilter.so /opt/kdeandroid-deps/plugins/kf5/urifilters/kurisearchfilter.so /opt/kdeandroid-deps/plugins/kf5/urifilters/fixhosturifilter.so /opt/kdeandroid-deps/plugins/kf5/urifilters/kshorturifilter.so /opt/kdeandroid-deps/plugins/kf5/kirigami/org.kde.desktop.so /opt/kdeandroid-deps/plugins/kf5/ktranscript.so /opt/kdeandroid-deps/plugins/kf5/parts/katepart.so /opt/kdeandroid-deps/plugins/kf5/kio/trash.so /opt/kdeandroid-deps/plugins/kf5/kio/http.so /opt/kdeandroid-deps/plugins/kf5/kio/ftp.so /opt/kdeandroid-deps/plugins/kf5/kio/file.so /opt/kdeandroid-deps/plugins/kf5/kio/remote.so /opt/kdeandroid-deps/plugins/kf5/emoticonsthemes/kde.so /opt/kdeandroid-deps/plugins/kf5/emoticonsthemes/xmpp.so /opt/kdeandroid-deps/plugins/kf5/emoticonsthemes/adium.so /opt/kdeandroid-deps/plugins/kf5/emoticonsthemes/pidgin.so /opt/kdeandroid-deps/plugins/kf5/kded/kcookiejar.so /opt/kdeandroid-deps/plugins/kf5/kded/remotenotifier.so /opt/kdeandroid-deps/plugins/kf5/org.kde.kwindowsystem.platforms/KF5WindowSystemWaylandPlugin.so /opt/kdeandroid-deps/plugins/kf5/kiod/kssld.so /opt/kdeandroid-deps/plugins/kf5/kiod/kpasswdserver.so /opt/kdeandroid-deps/plugins/kf5/kiod/kioexecd.so /opt/kdeandroid-deps/plugins/kf5/KEmoticonsIntegrationPlugin.so /opt/kdeandroid-deps/plugins/kf5/FrameworkIntegrationPlugin.so /opt/kdeandroid-deps/plugins/kcm_trash.so /opt/kdeandroid-deps/plugins/imageformats/kimg_ras.so /opt/kdeandroid-deps/plugins/imageformats/kimg_psd.so /opt/kdeandroid-deps/plugins/imageformats/kimg_kra.so /opt/kdeandroid-deps/plugins/imageformats/kimg_xcf.so /opt/kdeandroid-deps/plugins/imageformats/kimg_eps.so /opt/kdeandroid-deps/plugins/imageformats/kimg_tga.so /opt/kdeandroid-deps/plugins/imageformats/kimg_pcx.so /opt/kdeandroid-deps/plugins/imageformats/kimg_ora.so /opt/kdeandroid-deps/plugins/imageformats/kimg_rgb.so /opt/kdeandroid-deps/plugins/imageformats/kimg_pic.so /opt/kdeandroid-deps/plugins/krossqts.so /opt/kdeandroid-deps/plugins/script/krossqtsplugin.so /opt/kdeandroid-deps/plugins/okularpart.so
So yes, it could be an over-kill. Maybe not.
Comment Actions
threre's not so many unneded stuff in there to be honest, maybe kross, kate and the emoticonthemes, but doesn't seem terrible. One would improve that by not depending on the whole kf5umbrella probably?