Differential D12264

Make bluetooth payload upload work & asynchronous
ClosedPublic
Actions

Authored by mtijink on Apr 16 2018, 8:18 PM.

Details

Reviewers
apol
Group Reviewers
KDE Connect
Commits
R224:1b570d4719e4: Make bluetooth payload upload work & asynchronous
Summary

Sharing files to the Android bluetooth backend now works. The code is asynchronous now too.

Test Plan

I tested several files, and they all get transferred correctly. The socket gets destroyed correctly too.

Diff Detail

Repository
R224 KDE Connect
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mtijink created this revision.Apr 16 2018, 8:18 PM
Restricted Application added a project: KDE Connect. · View Herald TranscriptApr 16 2018, 8:18 PM
mtijink requested review of this revision.Apr 16 2018, 8:18 PM
apol requested changes to this revision.Apr 17 2018, 11:36 AM
apol added a subscriber: apol.

Small observations, looks really good!

core/backends/bluetooth/bluetoothuploadjob.cpp
56

Can you use the new syntax?

73–74

qMin<qint64>() reads better imho, then you can drop the ugly cast.

98

remove this debug? call finishWrites() directly?

114

If it didn't end we leak?

This revision now requires changes to proceed.Apr 17 2018, 11:36 AM
mtijink updated this revision to Diff 32405.Apr 17 2018, 4:58 PM

Make some requested changes, and better error handling

mtijink marked 3 inline comments as done.Apr 17 2018, 5:01 PM

I'll do some more testing with the current changes, to make sure edge cases are handled correctly.

core/backends/bluetooth/bluetoothuploadjob.cpp
114

We'll get called again if more bytes are written, so it eventually either disconnects (when some error happens) or all bytes have been written. Either case, we'll close it and destroy the job.

apol accepted this revision.Apr 17 2018, 10:56 PM

Looks good to me, definitely a step forward.

core/backends/bluetooth/bluetoothuploadjob.cpp
110

Just connect to closeConnection, let's not add cruft, makes for readability.

This revision is now accepted and ready to land.Apr 17 2018, 10:56 PM
Closed by commit R224:1b570d4719e4: Make bluetooth payload upload work & asynchronous (authored by mtijink). · Explain WhyApr 24 2018, 6:33 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 33005

View Options

core/backends/bluetooth/bluetoothdevicelink.cpp

Loading...
View Options

core/backends/bluetooth/bluetoothuploadjob.h

Loading...
View Options

core/backends/bluetooth/bluetoothuploadjob.cpp

Loading...