In fact, kirigami2 has the same version than other KF5 frameworks. I will land your patch without the CMakeLists.txt change. Sorry for that.
Sure, name is David Koermendi, email is nilsolm(at)vivaldi(dot)net.
In D20880#458660, @Nilsolm wrote:In D20880#458531, @mgallien wrote:Thanks for your work.
Please can you add the required version for Kirigami in the CMakeLists.txt file ?
Apart from that, this is fine for meGladly. That would just mean setting the required Kirigami version to 2.5.0 instead of using the required KF5 version, right?
In fact, kirigami2 has the same version than other KF5 frameworks. I will land your patch without the CMakeLists.txt change. Sorry for that.
In D20880#458546, @ngraham wrote:Sure, name is David Koermendi, email is nilsolm(at)vivaldi(dot)net.
It would be nice to fix it without re-importing, yes. If that's necessary, it should happen automatically. Does that already happen for people who upgrade from one stable release to another?
In D20879#457489, @ngraham wrote:Yep, confirmed that this fixes the issue for all of my albums that lacked art, after re-importing the library. Thanks!
In D20879#457489, @ngraham wrote:Yep, confirmed that this fixes the issue for all of my albums that lacked art, after re-importing the library. Thanks!
Yep, confirmed that this fixes the issue for all of my albums that lacked art, after re-importing the library. Thanks!
@bcooksley thanks for your help
First jobs started - https://build.kde.org/job/Extragear/job/elisa/
Thanks for the information.
I have added a stable branch.
Could you please run the DSL Job Seed job?
The lack of stable builds for Elisa is due to a lack of stable branch definitions in logical-module-structure in the kde-build-metadata repository.
(See the existing Elisa section)
Thanks @bcooksley for your help.
Hello,
In T7567#181665, @jguidon wrote:Hi,
According to the libvlc documentation, the method libvlc_media_new_location should be nice with some URL: https://www.videolan.org/developers/vlc/doc/doxygen/html/group__libvlc__media.html#gae1d3baee3f4610c6fe5818defcad3e6f .
I am motivated to take a look.
In D19610#448568, @jguidon wrote:Hi,
I am deeply sorry for the silence, I was quite busy these days and did not see the notifications going on.
According to the libvlc documentation, the method libvlc_media_new_location should be nice with some URL: https://www.videolan.org/developers/vlc/doc/doxygen/html/group__libvlc__media.html#gae1d3baee3f4610c6fe5818defcad3e6f .
I am deeply sorry for the silence, I was quite busy these days and did not see the notifications going on.
With libvlc playing an audio stream should be fairly easy to achieve. The URL just needs to be passed in the right form. So all we need is a way to add a stream to the playlist.
@jguidon I hope everything is fine for you. It would really great to have your contribution land in master branch. This is a really nice improvement.
It seems you are not yet a KDE contributor. I should land your branch but there is very small issues to fix. Do you want me to finish the work or are you able to do it ?
In T5375#181307, @astippich wrote:FYI, writing rating information was added to KF 5.57 via the TagLib writer plugin
FYI, writing rating information was added to KF 5.57 via the TagLib writer plugin
Ping
Thanks for your work.
Please fix the small issues.
Do you have a contributor account or do you need somebody to land your patch ?
Thanks a lot for your feedback
In D14018#437689, @januz wrote:@mgallien Hey, sure! Thanks for finishing it
@mgallien Hey, sure! Thanks for finishing it
@januz are you OK with me landing your patch ?
Nice work.
Thanks for your work. I will try to provide feedback as soon as I can. Sorry for the delay.
Fixed use of the closeButton of Kirigami.InlineMessage with Connections in qml. I asked to Marco Martin and I thank him for his help.
In D19610#429944, @jguidon wrote:
Hi, I would like to participate in this task, what is necessary? Could you give me an explanation?
Thank you for your feedback !
Thanks for your work, I have been able to successfully test it.
rebase on top of master
rebase on top of master
In D19610#427753, @jguidon wrote:
Thanks!
Use Kirigami InlineMessage instead of the system notification
Thanks, I can take a look at the Kirigami InlineMessage.
Instead of using a system notification, I would recommend showing a Kirigami InlineMessage at the bottom of the playlist pane with an Undo button in it.
Thank you for your replies, I could push a diff: https://phabricator.kde.org/D19610 . I tried to follow the instructions as much as possible :)
Sorry to have missed your first questions.
Sorry, I had missed your questions,
Finally, I could use KNotification to generate on the clear action a system notification with an undo choice (the file elisa.notifyrc may be particular for the packaging, KNotificationGlobalConfigFile).
Thank you, I have indeed a few questions after a first look at the code :
In T5376#176298, @jguidon wrote:Hi !
I am new here and I am very motivated to invest !
Thank you sir.
I will do it and i need some more information
and I'm new to this so it will be better if i get some guidance.