I already added a .htaccess to the jekyll branch with some redirection so that the user don't get 404 errors.

Keeping existing URLs might be interesting in one or the other case, probably not all of them.

Should we use https://github.com/jekyll/jekyll-redirect-from to avoid breaking existing URLs, or it does not matter?

I'm sure we can work together :) I'm currently doing the support page (documentation, faq, ...), if you want you can do the homepage ;)

@ognarb I see you started already. Do you want help with this one, or should I pick a different website to port? (I’m not sure how fleasible parallel work on this is)

Ping?

I have not yet checked, but this would be a good time to be sure all the available Payee fields in the UI match those available in the check-printing plugin.

See D24233 for the implementation work

I will fix this

Corrected variable name numSplits.

Please change NumSplits into numSplits before you commit. Or do you want me do add it to the repository?

Changed all sahres to value and updated currency to print the currency symbol.

Added the currency for the accout=nt/transaction

questions

This should now give the proper amount.

I have replaced shares with value in: checkHTML.replace( valueVariable, MyMoneyUtils::formatMoney((*it).transaction().splits()[i].value().abs(), currency));.
As has been pointed out if one or more of the splits are in a different currency shares will give the wrong amount for the split.

Thanks for the review, please look at my changes.

Thanks for the feedback, my C++ skills are way out of date. I have made two of the three changes that were suggested. I do not understand the one about the currency and you reference line 206. That line gives the value in text not numbers. Line 207 gives the value in numbers and should be modified by the currency. My line 214 should give the value in numbers and is identical to line 207. It should be modified by the currency. If I am wrong please let me know.

Please review

Looks OK to me.

This looks fine to me.

This is now confirmed as fixed.

therefore it would be good to have context in the i18n() calls

According to https://techbase.kde.org/Development/Tutorials/Localization/i18n#Standard_Context_For_Common_Phrases you are refering to

https://dict.leo.org/englisch-deutsch/shares says:
shares Pl. (Brit.) [FINAN.] die Aktien Pl. [Börse]
shares Pl. [FINAN.] die Anteile Pl.
therefore it would be good to have context in the i18n() calls
otherwise +1

Yes, it is german only. I should have made the diff from the whole path.

I certainly can't comment on the German, but as long as this is only changing the German translation, I have no problem with it.

Is the crashing AppImage available for download? I'd like to have a look at it.

Closed manually after I landed the change manually as dffdf76750f74ad6e8741abe5ed4b7380f9b65e3

In case you don't have write access let me know.

Added your suggestions (and fixed the patch)

Thanks for your suggestions! I hope, I included them correctly.
First time contributing to KDE after 21 years of using it ;-)

included Thomas' suggestions

In general a good idea and a cool addition to the application.

• use local path first in readme.cmake
• add note why not using ECM 5.38

Just a hint: running kmymoney from build dir is useful inside an IDE like QtCreator

• fixed issues
• todo: creating symlink need to be checked on windows