These changes add the ability to set the payee's city and state
AcceptedPublic

Authored by philhopkins on Sep 26 2019, 3:28 AM.

Details

Reviewers
tbaumgart
Summary

I revomed the lines that Thomas flagged. After testing I found that they were not necessary. Also I checked and now all of the fields in the XML and SQL database are able to be edited and changed with this patch.

IS there a way that this patch can be reviewed and landed?

Diff Detail

Repository
R261 KMyMoney
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 17055
Build 17073: arc lint + arc unit
philhopkins requested review of this revision.Sep 26 2019, 3:28 AM
philhopkins created this revision.
tbaumgart requested changes to this revision.Sep 26 2019, 11:32 AM

Other than that, it seems fine. I have not run any of that yet.

kmymoney/views/kpayeesview.cpp
490–491

Don't know, if we need those here. We do have the city and state in their own input fields now. This would enter them twice into the payee, or am I missing something?

This revision now requires changes to proceed.Sep 26 2019, 11:32 AM

Removig superfluous lines in kpayeesview.cpp

philhopkins edited the summary of this revision. (Show Details)Sep 26 2019, 4:12 PM
philhopkins edited the summary of this revision. (Show Details)Tue, Oct 29, 3:03 AM
tbaumgart accepted this revision.Fri, Nov 1, 2:18 PM

Looks good to me.

This revision is now accepted and ready to land.Fri, Nov 1, 2:18 PM