Fixes "In German, the dialog uses "share" if it is actually shares and/or bonds (i.e. securities).
ClosedPublic

Authored by habacker on Tue, Jan 29, 12:11 PM.

Diff Detail

Repository
R883 Subversion
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
habacker requested review of this revision.Tue, Jan 29, 12:11 PM
habacker created this revision.

I certainly can't comment on the German, but as long as this is only changing the German translation, I have no problem with it.

Yes, it is german only. I should have made the diff from the whole path.

habacker retitled this revision from Fixed "Dialog uses 'share' when in fact referring to shares and/or bonds (i.e., securities)" to Fixes "In German, the dialog uses "share" if it is actually shares and/or bonds (i.e. securities)..Tue, Jan 29, 4:53 PM
lueck accepted this revision.Tue, Jan 29, 5:33 PM

https://dict.leo.org/englisch-deutsch/shares says:
shares Pl. (Brit.) [FINAN.] die Aktien Pl. [Börse]
shares Pl. [FINAN.] die Anteile Pl.
therefore it would be good to have context in the i18n() calls
otherwise +1

This revision is now accepted and ready to land.Tue, Jan 29, 5:33 PM

According to https://techbase.kde.org/Development/Tutorials/Localization/i18n#Standard_Context_For_Common_Phrases you are refering to

i18nc("financial", "...")

or

i18nc("financial share", "..")

or

i18nc("finances", "..")

or something else in all cases ?

This revision was automatically updated to reflect the committed changes.

therefore it would be good to have context in the i18n() calls

I tried that with lokalize/kf5. Unfortunally it does not support jumping to the related source code line (see https://bugs.kde.org/show_bug.cgi?id=403743 for a related report)