- User Since
- Aug 21 2019, 5:06 PM (11 w, 5 d)
Tue, Oct 29
Sep 26 2019
Removig superfluous lines in kpayeesview.cpp
I will fix this
Aug 26 2019
Corrected variable name numSplits.
Changed all sahres to value and updated currency to print the currency symbol.
Added the currency for the accout=nt/transaction
This should now give the proper amount.
I have replaced shares with value in: checkHTML.replace( valueVariable, MyMoneyUtils::formatMoney((*it).transaction().splits()[i].value().abs(), currency));.
As has been pointed out if one or more of the splits are in a different currency shares will give the wrong amount for the split.
Aug 24 2019
Thanks for the review, please look at my changes.
Thanks for the feedback, my C++ skills are way out of date. I have made two of the three changes that were suggested. I do not understand the one about the currency and you reference line 206. That line gives the value in text not numbers. Line 207 gives the value in numbers and should be modified by the currency. My line 214 should give the value in numbers and is identical to line 207. It should be modified by the currency. If I am wrong please let me know.
Aug 23 2019