philhopkins (Phil Hopkins)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Wed, Aug 21, 5:06 PM (4 w, 1 d)
Availability
Available

Recent Activity

Mon, Aug 26

philhopkins updated the diff for D23369: Adding additional variable to check printing.

Corrected variable name numSplits.

Mon, Aug 26, 9:39 PM · KMyMoney
philhopkins added inline comments to D23369: Adding additional variable to check printing.
Mon, Aug 26, 6:27 PM · KMyMoney
philhopkins updated the diff for D23369: Adding additional variable to check printing.

Changed all sahres to value and updated currency to print the currency symbol.

Mon, Aug 26, 6:25 PM · KMyMoney
philhopkins added inline comments to D23369: Adding additional variable to check printing.
Mon, Aug 26, 5:54 PM · KMyMoney
philhopkins updated the diff for D23369: Adding additional variable to check printing.

Added the currency for the accout=nt/transaction

Mon, Aug 26, 5:06 PM · KMyMoney
philhopkins added inline comments to D23369: Adding additional variable to check printing.
Mon, Aug 26, 4:30 PM · KMyMoney
philhopkins added inline comments to D23369: Adding additional variable to check printing.
Mon, Aug 26, 4:21 PM · KMyMoney
philhopkins added a comment to D23369: Adding additional variable to check printing.

questions

Mon, Aug 26, 3:51 PM · KMyMoney
philhopkins added a comment to D23369: Adding additional variable to check printing.

This should now give the proper amount.

Mon, Aug 26, 3:02 AM · KMyMoney
philhopkins added inline comments to D23369: Adding additional variable to check printing.
Mon, Aug 26, 3:02 AM · KMyMoney
philhopkins updated the diff for D23369: Adding additional variable to check printing.

I have replaced shares with value in: checkHTML.replace( valueVariable, MyMoneyUtils::formatMoney((*it).transaction().splits()[i].value().abs(), currency));.
As has been pointed out if one or more of the splits are in a different currency shares will give the wrong amount for the split.

Mon, Aug 26, 2:59 AM · KMyMoney

Sat, Aug 24

philhopkins added a comment to D23369: Adding additional variable to check printing.

Thanks for the review, please look at my changes.

Sat, Aug 24, 3:36 AM · KMyMoney
philhopkins added inline comments to D23369: Adding additional variable to check printing.
Sat, Aug 24, 3:35 AM · KMyMoney
philhopkins updated the diff for D23369: Adding additional variable to check printing.

Thanks for the feedback, my C++ skills are way out of date. I have made two of the three changes that were suggested. I do not understand the one about the currency and you reference line 206. That line gives the value in text not numbers. Line 207 gives the value in numbers and should be modified by the currency. My line 214 should give the value in numbers and is identical to line 207. It should be modified by the currency. If I am wrong please let me know.

Sat, Aug 24, 3:30 AM · KMyMoney

Fri, Aug 23

philhopkins added a comment to D23369: Adding additional variable to check printing.

Please review

Fri, Aug 23, 3:20 AM · KMyMoney
philhopkins added a reviewer for D23369: Adding additional variable to check printing: KMyMoney.
Fri, Aug 23, 3:18 AM · KMyMoney
philhopkins requested review of D23369: Adding additional variable to check printing.
Fri, Aug 23, 3:17 AM · KMyMoney

Wed, Aug 21

philhopkins added a member for KMyMoney: philhopkins.
Wed, Aug 21, 5:07 PM