philhopkins (Phil Hopkins)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Aug 21 2019, 5:06 PM (11 w, 5 d)
Availability
Available

Recent Activity

Tue, Oct 29

philhopkins added a reviewer for D25029: This patch add a No/100 to the text when a check has not fratcoinal part Also it captalizes the first letter to all on the number in text to be printed.: KMyMoney.
Tue, Oct 29, 3:25 AM
philhopkins updated the summary of D25029: This patch add a No/100 to the text when a check has not fratcoinal part Also it captalizes the first letter to all on the number in text to be printed..
Tue, Oct 29, 3:25 AM
philhopkins requested review of D25029: This patch add a No/100 to the text when a check has not fratcoinal part Also it captalizes the first letter to all on the number in text to be printed..
Tue, Oct 29, 3:20 AM
philhopkins updated the summary of D24233: These changes add the ability to set the payee's city and state.
Tue, Oct 29, 3:03 AM

Sep 26 2019

philhopkins updated the summary of D24233: These changes add the ability to set the payee's city and state.
Sep 26 2019, 4:12 PM
philhopkins updated the diff for D24233: These changes add the ability to set the payee's city and state.

Removig superfluous lines in kpayeesview.cpp

Sep 26 2019, 4:09 PM
philhopkins requested review of D24233: These changes add the ability to set the payee's city and state.
Sep 26 2019, 3:28 AM
philhopkins moved T11777: add ability to set payee city and payee state from Backlog to In progress on the KMyMoney board.
Sep 26 2019, 3:19 AM · KMyMoney
philhopkins raised the priority of T11777: add ability to set payee city and payee state from Wishlist to Normal.

I will fix this

Sep 26 2019, 3:07 AM · KMyMoney
philhopkins triaged T11777: add ability to set payee city and payee state as Wishlist priority.
Sep 26 2019, 3:04 AM · KMyMoney

Aug 26 2019

philhopkins updated the diff for D23369: Adding additional variable to check printing.

Corrected variable name numSplits.

Aug 26 2019, 9:39 PM · KMyMoney
philhopkins added inline comments to D23369: Adding additional variable to check printing.
Aug 26 2019, 6:27 PM · KMyMoney
philhopkins updated the diff for D23369: Adding additional variable to check printing.

Changed all sahres to value and updated currency to print the currency symbol.

Aug 26 2019, 6:25 PM · KMyMoney
philhopkins added inline comments to D23369: Adding additional variable to check printing.
Aug 26 2019, 5:54 PM · KMyMoney
philhopkins updated the diff for D23369: Adding additional variable to check printing.

Added the currency for the accout=nt/transaction

Aug 26 2019, 5:06 PM · KMyMoney
philhopkins added inline comments to D23369: Adding additional variable to check printing.
Aug 26 2019, 4:30 PM · KMyMoney
philhopkins added inline comments to D23369: Adding additional variable to check printing.
Aug 26 2019, 4:21 PM · KMyMoney
philhopkins added a comment to D23369: Adding additional variable to check printing.

questions

Aug 26 2019, 3:51 PM · KMyMoney
philhopkins added a comment to D23369: Adding additional variable to check printing.

This should now give the proper amount.

Aug 26 2019, 3:02 AM · KMyMoney
philhopkins added inline comments to D23369: Adding additional variable to check printing.
Aug 26 2019, 3:02 AM · KMyMoney
philhopkins updated the diff for D23369: Adding additional variable to check printing.

I have replaced shares with value in: checkHTML.replace( valueVariable, MyMoneyUtils::formatMoney((*it).transaction().splits()[i].value().abs(), currency));.
As has been pointed out if one or more of the splits are in a different currency shares will give the wrong amount for the split.

Aug 26 2019, 2:59 AM · KMyMoney

Aug 24 2019

philhopkins added a comment to D23369: Adding additional variable to check printing.

Thanks for the review, please look at my changes.

Aug 24 2019, 3:36 AM · KMyMoney
philhopkins added inline comments to D23369: Adding additional variable to check printing.
Aug 24 2019, 3:35 AM · KMyMoney
philhopkins updated the diff for D23369: Adding additional variable to check printing.

Thanks for the feedback, my C++ skills are way out of date. I have made two of the three changes that were suggested. I do not understand the one about the currency and you reference line 206. That line gives the value in text not numbers. Line 207 gives the value in numbers and should be modified by the currency. My line 214 should give the value in numbers and is identical to line 207. It should be modified by the currency. If I am wrong please let me know.

Aug 24 2019, 3:30 AM · KMyMoney

Aug 23 2019

philhopkins added a comment to D23369: Adding additional variable to check printing.

Please review

Aug 23 2019, 3:20 AM · KMyMoney
philhopkins added a reviewer for D23369: Adding additional variable to check printing: KMyMoney.
Aug 23 2019, 3:18 AM · KMyMoney
philhopkins requested review of D23369: Adding additional variable to check printing.
Aug 23 2019, 3:17 AM · KMyMoney

Aug 21 2019

philhopkins added a member for KMyMoney: philhopkins.
Aug 21 2019, 5:07 PM