Corrected variable name numSplits.
- Queries
- All Stories
- Search
- Advanced Search
Advanced Search
Sep 16 2019
Sep 15 2019
Sep 7 2019
Aug 29 2019
Aug 28 2019
Aug 26 2019
Please change NumSplits into numSplits before you commit. Or do you want me do add it to the repository?
Changed all sahres to value and updated currency to print the currency symbol.
Added the currency for the accout=nt/transaction
questions
This should now give the proper amount.
I have replaced shares with value in: checkHTML.replace( valueVariable, MyMoneyUtils::formatMoney((*it).transaction().splits()[i].value().abs(), currency));.
As has been pointed out if one or more of the splits are in a different currency shares will give the wrong amount for the split.
Aug 24 2019
Thanks for the review, please look at my changes.
Thanks for the feedback, my C++ skills are way out of date. I have made two of the three changes that were suggested. I do not understand the one about the currency and you reference line 206. That line gives the value in text not numbers. Line 207 gives the value in numbers and should be modified by the currency. My line 214 should give the value in numbers and is identical to line 207. It should be modified by the currency. If I am wrong please let me know.
Aug 23 2019
Please review
Aug 21 2019
Aug 14 2019
Aug 7 2019
Jun 27 2019
Looks OK to me.
May 4 2019
Mar 24 2019
Mar 10 2019
Mar 3 2019
Feb 23 2019
Feb 12 2019
Feb 2 2019
This looks fine to me.
Feb 1 2019
This is now confirmed as fixed.
Jan 31 2019
therefore it would be good to have context in the i18n() calls
Jan 29 2019
According to https://techbase.kde.org/Development/Tutorials/Localization/i18n#Standard_Context_For_Common_Phrases you are refering to
https://dict.leo.org/englisch-deutsch/shares says:
shares Pl. (Brit.) [FINAN.] die Aktien Pl. [Börse]
shares Pl. [FINAN.] die Anteile Pl.
therefore it would be good to have context in the i18n() calls
otherwise +1
Yes, it is german only. I should have made the diff from the whole path.
I certainly can't comment on the German, but as long as this is only changing the German translation, I have no problem with it.
Jan 16 2019
Jan 1 2019
Dec 6 2018
Is the crashing AppImage available for download? I'd like to have a look at it.
Nov 30 2018
Closed manually after I landed the change manually as dffdf76750f74ad6e8741abe5ed4b7380f9b65e3
In case you don't have write access let me know.
Added your suggestions (and fixed the patch)
Nov 29 2018
Thanks for your suggestions! I hope, I included them correctly.
First time contributing to KDE after 21 years of using it ;-)
included Thomas' suggestions
In general a good idea and a cool addition to the application.
Nov 27 2018
Nov 25 2018
- use local path first in readme.cmake
- add note why not using ECM 5.38
Nov 24 2018
Nov 21 2018
Nov 16 2018
Just a hint: running kmymoney from build dir is useful inside an IDE like QtCreator
- fixed issues
- todo: creating symlink need to be checked on windows
Nov 15 2018
Nov 11 2018
In D14522#357923, @ostroffjh wrote:There are several people who are against this, and only one in favor. Would you please consider others' opinions, and defer this further, or put it in a separate branch?
There are several people who are against this, and only one in favor. Would you please consider others' opinions, and defer this further, or put it in a separate branch?
I rebased the patch to fit the latest master branch.
Please test and approve.
Oct 27 2018
Oct 26 2018
Oct 16 2018
Sep 22 2018
Sep 21 2018
Worked here on my openSUSE system.