Why not change the recentdocuments runner?

I hate Qt... defining operator* without operator-> ... ugh

Yes, the wrapper just serves for keyval iterators to be usable with a range-based for loop. Quite useful if there are a lot of these. In this case, where it is only one loop I agree it might be an overkill.

Something like this:

TBH, I'd like more to have dirs always end with a slash, but I guess this is fine as well.

For some reason, hiding this icon when there are no vaults was deemed undesired before. I don't recall why as I think it is a good idea. :)

Just add TODO and you are free to push

I'm not thrilled about having default shortcuts set. We have the shortcuts space quite polluted as it is.

Add the same for directories for completeness

Filtering can be done as far as the KAStats is concerned. The question is how to know inside the KIO slave which application requested its services.

Change everything to plural.

You can also use set*/add* member functions for this so that David doesn't complain. As I said, pipes are mainly there for chaining - easy query creation API to simplify the alternative of set set set set set. But if you set a single field, I'd say set*/add* is a fine option.

This is something I did have initally in kastats, it was killed because while this is tempting

Sorry I missed this one. If I don't react on a ping here, just send me a direct mail.

Looks OK to me, I guess some of our resident KIO experts should review it. What do you think?

Another tiny change, and I think it is ready to land. Unless someone else sees other issues.

Thanks for geting involved this much!

If @kossebau is satisfied, go for it

Joining with ResourceEvent is a problem. At least make it not get joined if the date filter is not present.

Inserting/Removing/Updating a sorted list does not need to resort every time - removing is easy, adding a new item is std::lower_bound (a binary search), and updating is a combination of the two.

You are right, they are randomized.

I think it would be better to put it into kio-extras - activities kio is also there.

I'd add support for HighScoredFirst and RecentlyCreatedFirst. Maybe the protocol could be something like "used:/" or something.

WRT implementation, I'd also add a link to KMountPoint (https://api.kde.org/frameworks/kio/html/classKMountPoint.html) which provides an interface to fstab/mtab so that Solid/FuseMounts plugin does not need to do any parsing by itself.

I guess that is the main point of this patch. I don't think that anyone is against that. :)

I'm torn between two approaches:

Thanks for working on this.

Accepted, but incomplete ;)

Incorporated David's advice