Improve the look of the Activities KCM UI
ClosedPublic

Authored by GB_2 on Aug 15 2019, 11:14 AM.

Details

Summary

Apply the KDE HIG, port to QQC2 and Kirigami, make the KCM look better and make the KCM show up in search results.



Test Plan

Open the Activities KCM and change some settings. Everything that was working before should still work.

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
GB_2 created this revision.Aug 15 2019, 11:14 AM
Restricted Application added a project: Plasma. · View Herald TranscriptAug 15 2019, 11:14 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
GB_2 requested review of this revision.Aug 15 2019, 11:14 AM
GB_2 updated this revision to Diff 63793.Aug 15 2019, 11:15 AM

Remove unneeded import

UI is super better now, wow.

kcms/activities/ui/PrivacyTabBase.ui
60

I'd add a colon after this (Only for specific applications:) because the grid of specific applications is right after it.

GB_2 updated this revision to Diff 63800.Aug 15 2019, 2:20 PM

"Only for specific applications" -> "Only for specific applications:"

GB_2 marked an inline comment as done.Aug 15 2019, 2:25 PM
GB_2 added a reviewer: ivan.Aug 15 2019, 2:29 PM

As a further improvement, I might even merge the contents of the "Switching" tab into the main "Activities" tab. There's room below the Activities list because typically people are going to have 1-4 activities at most; it's not generally going to be a huge tall list of dozens of items.

I can understand if that presents tech problems because one is QML and the other is QWidgets though.

Very nice work. This is close to a "shipit" already IMO from my perspective. I just have a few more comments:

kcms/activities/imports/qml/activityDialog/GeneralTab.qml
26

You're importing two different things with the same name

kcms/activities/qml/activitiesTab/ActivitiesView.qml
66

Maybe "Configure <activity name> activity..."?

73

Maybe "Delete <activity name> activity"?

84

How about "Create New..." just to emphasize that a new one is being made

kcms/activities/qml/privacyTab/BlacklistApplicationView.qml
69

emblem-unavailable looks nicer and seems more semantically correct. If we use it, it should be located in the bottom-right corner of the icon to be consistent with other emblem placement.

GB_2 updated this revision to Diff 63817.Aug 15 2019, 4:00 PM

Address comments

GB_2 updated this revision to Diff 63818.Aug 15 2019, 4:08 PM

Fix "blocked" emblem icon

ngraham accepted this revision.Aug 15 2019, 4:30 PM

Fantastic.

This revision is now accepted and ready to land.Aug 15 2019, 4:30 PM
GB_2 added a project: KActivities.
GB_2 added subscribers: ivan, KActivities.
ivan accepted this revision.Mon, Aug 26, 5:07 PM
This revision was automatically updated to reflect the committed changes.

Hooray!

Next, do you think you could clean up the applications list so there aren't all those duplicates and they all get icons?

GB_2 added a comment.EditedSun, Sep 1, 6:27 AM

Hooray!

Next, do you think you could clean up the applications list so there aren't all those duplicates and they all get icons?

Unfortunately, I don't know the code base well enough to fix that. Maybe @ivan can fix it or you can file a bug.